Does any of you remember any change in the 1.0.3 code that admins should be reminded about or that requires admin actions?
Do new text strings count?
hmm... do we have new strings? I missed them... :-[
I was thinking about things like the avatars for 1.0.2, where admins were supposed to check the settings and fix anything not good for them.
Ah ... not that I can think of (wrt a settings change that the admin needs to know about)
Just a few text strings, nothing major.
$editortxt['Close'] = 'Close';
$txt['pm_approve_warning'] = 'Approve this personal message with CAUTION!
The PM being replied to has been REMOVED.
The system attempts to find others in that conversation but the results are not 100% accurate.
If in doubt, its better to bounce!';
$txt['mentions_what'] = 'Message';
$txt['whoall_pm_byemail'] = 'Sending a personal message by email.';
$txt['mark_these_as_read'] = 'Mark THESE messages as read';
We should also update define('CACHE_STALE', '?102'); to 103 I believe, I think we had a couple of JS changes? (had to look, thats a yup :P)
Ouch!
Forgot about the stale... :-\
Updated the stale and I have the patch ready.
I just don't have a clean forum to test it. xD
Well, I attached it here, I'm not sure it even works, so test with care. ;)
ETA: removed the patch to avoid confusion.
Couple of small bugs that need to be fixed, will update tomorrow ...
one simple on is the language edits need to point to /english/ in the .xml file. One edit is missing but I think I forgot to update one area with the new langauge string :(
Also the unzipo and untgz files are placed in /sources/sources/subs instead of /sources/subs
Also seeing the following in a quick test
Undefined index: href
/public_html/forum/sources/Subs.php
Line: 2562
Undefined index: image
public_html/forum/sources/Subs.php
Line: 2563
...which brings us back to this:
lol
I won't be able to touch it until Sunday (if I will be able on Sunday).
New language strings may count in the sense of "hey admin there are new strings, if you have another language you should consider updating it".
A short notice may be worth, to consider.
Here is an updated package that fixes the install errors that I noted above.
However:
- It does not have the PR that I submitted to tweak a couple areas, that can wait to 1.0.4 as well
- It does not fix the undefined errors that I was getting as noted above, have not had time to look at that :(
/me marks as unread
Found the undefined index issue.
In a couple of cases, determineAvatar returns an empty array, and this is the cause of the undefined index.
About the fix: one way to fix it would be to always return an array of data, but I feel in some cases the avatar index is checked as not empty, and returning something would break these checks.
So, for 1.0.3 I'd just add a pair of !empty to the new code in Subs.php.
!empty() it is then :D
:D
I'm finishing to add stuff to the xml.
I'll upload a new version before evening (CET).
Faster than expected.
Attached a new version of the patch. :D
I'll start committing this to the repo, so there is a starting point (and hopefully and ending one).
I moved the milestone at github to Thursday (the 19th), though, if there are no other issues it can be released.
Just did a test, it installed fine on 1.0.2 ... and the site is still running :P ;D
/me added an easter egg that blows the site only when it becomes non-obvious. :P
https://github.com/elkarte/Elkarte/releases/edit/untagged-ad19a1794626ade72ee5 <= (empty) draft of the release announcement...
@Spuds do you know what we changed in 1.0.3 worth of mention?
Hummm 114 commits and 78 files changed, you would have thought we did something of mention :P but really it was a bunch of smallish or esoteric bug fixes with some very nice tweaks here and there. Probably best just to point to the commit list instead?
One thing we may want to note is that due to a change in parse_bbc, IF you are using SP you should uninstall it before installing this patch, then install the latest version of SP.
So my feeling was not wrong at all! LOL
Good point about SP.
Arg... sorry, today I had another round of problems and I didn't find the time to prepare the release... tomorrow! For sure... I hope. :P
Now it is tomorrow, I've fixed the text of the release announcement. I'm preparing the package now hoping I didn't break anything in the meantime. :P
After updating to 1.0.3 I download the italian translation but the text for "Mark THESE messages as read" it's not included. I think new phrases should be included. I did not checked the others strings.
Beside that I don't understand why it was added this new string and what is the difference betweem the old "Mark ALL messages as read" and the new "Mark THESE messages as read". Once you used the "Mark THESE messages as read" all unread messages are marked as read. Am I missing something?
http://www.elkarte.net/community/index.php?topic=2401.msg15793#msg15793
I guess the files should be uploaded at transifex... :-[