ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: Lou on February 20, 2016, 07:45:04 pm

Title: Missing help string for Newsletter>Editor
Post by: Lou on February 20, 2016, 07:45:04 pm
A really minor little critter, I would think.  When in the editor for Newsletters, click on the ? icon for Newsletters and you will see the empty string. 

Title: Re: Missing help string for Newsletter>Editor
Post by: emanuele on February 21, 2016, 03:36:05 am
Good catch!
Maybe we are lucky it's just a change in the index, otherwise... what should be there?
Title: Re: Missing help string for Newsletter>Editor
Post by: Lou on February 21, 2016, 07:59:34 am
Well....I do not believe the second Help icon is needed at all for that h3 header tag and can be removed. The first h3 titled 'News and Newsletters' Help popup contains just about all needed information.

I would vote to remove the Help icon from the second h3 titled 'Newsletters'.
Title: Re: Missing help string for Newsletter>Editor
Post by: emanuele on March 23, 2016, 05:43:16 pm
If I'm not wrong this is the fix:
https://github.com/elkarte/Elkarte/commit/d7cb75f68df85c7e691427591400e6aefe6ec24f
Title: Re: Missing help string for Newsletter>Editor
Post by: Spuds on March 23, 2016, 09:09:32 pm
That was it, did not need two icons, in close proximity, that showed the same text.