The mentions counter for the menu says that I have 1 unread mention. However it doesn't appear in the list at mentions action. I'm guessing that it's either a bug in the mentions counter or you guys have been talking about me behind the closed doors I can't access.
Another little issue, if I may; the "Started by author" thing might be okay for the sorting options but it looks and reads awful in the topic lists. I mean "Started by author [SiNaN]" looks pretty bad; "Started by [SiNaN]" makes a lot more sense.
Another one I've just spotted; the additional options container in the post action seems to need some top margin.
Oddity!! :'(
/me hates debugging
/me feels more tests are necessary
/me hates writing tests LOL
I just didn't notice it. lol
It's very unlikely I read texts like that one, I usually focus on the right side of the screen on the last message area and... odd: since when did we drop the "I posted in this topic" icon?
/me thinks this is another bug...
I think currently what you do is increasing or decreasing the counter. Maybe doing a full recount of mentions would be a lot less likely to go wrong.
Overall the templates here feel incomplete to me. It's like they need plenty of little touches here and there.
Although I don't think it matters in this case, the maintenance task "Users Mentions Access" is not enabled on the site. I do remember the mention to [SiNaN] in the internal board (don't worry, it was just eman being to lazy to type your name :P so he used mention) so it should not have shown up in your counter.
Oh... I forgot about that... lol
Well, at least now it really looks like a bug. ::)
So you really were gossiping about me?! :P I haven't read it thoroughly but Users Mentions Access task looks a little weird to me. I wonder if the whole access thing with mentions could be handled more differently.
It may be. I just realised that it may be possible to check "immediately" without compromising too much performances (using the same trick of the scheduled task (I wonder why I didn't do that check at the beginning... no idea).
Then the scheduled task itself: it may be removed, yes, there are "consequences" of course: if you "mention" a user in a board he cannot see, but then he gains access to that board, without a kind of scheduled task it would be not easily possible (at least I don't have any good idea) to recover those mentions. If instead the opposite happens (i.e. a user lose access to a certain board), he will still see the mentions around without having the possibility to see the topic/message/whatever.
Actually, that second part is not very important, and TBH I tend to think it may be more correct to keep them visible to the user.
What would you prefer in similar cases?