Re: IRC Reply #240 – May 28, 2013, 06:42:26 am (12:09:00 PM) elk_core: [Elkarte] eurich opened pull request #455: Fixes for the red variant (master...fixes_red) http://git.io/Cn_wMQ(07:37:56 PM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/u-POng(07:37:56 PM) elk_core: Elkarte/master 32b5d91 Thorsten Eurich: make it easier to use custom menu layouts for variants.....(07:37:56 PM) elk_core: Elkarte/master 8aaf20a Thorsten Eurich: fixes the menu from the red variant...(07:37:56 PM) elk_core: Elkarte/master b8c170d Norv: Merge pull request #455 from eurich/fixes_red...(11:14:28 PM) elk_core: [Elkarte] norv opened pull request #456: Cleanups (master...cleanups) http://git.io/7vvoJA(11:16:56 PM) elk_core: [Elkarte] norv pushed 4 new commits to master: http://git.io/U5YRTA(11:16:56 PM) elk_core: Elkarte/master 04e5533 Joshua Dickerson: Commit refactoring of Recent controller using the topicsParticipation() function....(11:16:56 PM) elk_core: Elkarte/master 91e69f6 Joshua Dickerson: Add topics participation to search controller as well....(11:16:56 PM) elk_core: Elkarte/master c74bf03 Norv: Update subs functions for more consistency: messagesSince() and countMessagesSince()....(10:04:54 AM) elk_core: [Elkarte] norv opened pull request #457: Error log fix (master...cleanups) http://git.io/ibV4sw(07:42:39 PM) elk_core: [Elkarte] eurich opened pull request #459: Html5 additions (master...html5_additions) http://git.io/-9glDw(10:32:27 PM) elk_core: [Elkarte] norv pushed 14 new commits to master: http://git.io/BwcpMQ(10:32:28 PM) elk_core: Elkarte/master b24e2af Thorsten Eurich: some HTML5 additions for profile and registration...(10:32:28 PM) elk_core: Elkarte/master 4ae9cd9 Thorsten Eurich: more HTML5 additions (required attribute) for profile and registration...(10:32:28 PM) elk_core: Elkarte/master 03971cd Thorsten Eurich: unused global....(11:48:25 PM) elk_core: [Elkarte] eurich opened pull request #460: Members controller refactoring (master...members_overhaul) http://git.io/4NE7BA(03:55:39 PM) elk_core: [Elkarte] norv opened pull request #461: Add jquery_source to install and upgrade. (master...jquery) http://git.io/M0m_eA(03:56:40 PM) elk_core [~elk_core@router1-ext.rs.github.com] entered the room.(03:56:41 PM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/fGxtFQ(03:56:41 PM) elk_core: Elkarte/master b4268a6 Norv: Add jquery_source to install and upgrade....(03:56:41 PM) elk_core: Elkarte/master 7531b66 Norv: Merge pull request #461 from norv/jquery...(04:08:27 PM) elk_core: [Elkarte] norv pushed 1 new commit to master: http://git.io/06R_DA(04:08:27 PM) elk_core: Elkarte/master 8d38ed1 Norv: Commit amend fail: add jquery to postgresql....
Re: IRC Reply #241 – May 28, 2013, 02:18:04 pm (09:51:19 PM) elk_core: [Elkarte] norv opened pull request #462: Fixes up (master...fixes_up) http://git.io/Oi7A6w(09:57:36 PM) elk_core: Elkarte/master 6108fcd Norv: Missing global in auth....(09:57:36 PM) elk_core: Elkarte/master 89fa45e Norv: Fix topic notification....(09:57:36 PM) elk_core: Elkarte/master b7c18ce Norv: Merge pull request #462 from norv/fixes_up...(10:22:26 PM) emanuele [~chatzilla] entered the room.(10:25:27 PM) Norv: An emanuele!!(10:25:30 PM) Norv: Just in time.(10:26:09 PM) ***emanuele is looking around for who broke the site (10:26:17 PM) Norv: Undefined index: page_index_template(10:26:56 PM) Norv: I did! Fixing things... And there are several.(10:27:08 PM) emanuele: lol(10:27:14 PM) emanuele: we suck at testing!(10:29:15 PM) emanuele: but locally works...apparently..(11:06:26 PM) elk_core: [Elkarte] norv opened pull request #465: Fixes up (master...fixes_up) http://git.io/8d3Q6Q(11:09:03 PM) elk_core: Elkarte/master 7056e86 Norv: Missed guest links....(11:09:03 PM) elk_core: Elkarte/master 785e6bc Norv: Pfft....(11:09:03 PM) elk_core: Elkarte/master 7c31d0b Norv: Merge pull request #465 from norv/fixes_up...
Re: IRC Reply #242 – May 29, 2013, 04:45:52 pm (11:12:07 PM) Norv: Ema, ideas on undefined $first_subject? For getFormMsgSubject()(11:13:09 PM) emanuele: Are you using master?(11:13:36 PM) Norv: yes(11:15:03 PM) emanuele: mmm.... headscratch ...it doesn't make much sense, it has a default value...(11:16:02 PM) Norv: it has a default value in the called function, but it's undefined in the caller(11:17:27 PM) Norv: So it can be ignored? I did at some point on the site, but now I'm back to restoring hacks to fix the rest.(11:17:43 PM) emanuele: ahhh...okay, that sounds more easy to debug! (11:24:21 PM) ***emanuele guesses preview of new topics with an error(11:24:43 PM) emanuele: ahh...directly new topics(11:25:16 PM) emanuele: I don't like that much that function TBH...(11:26:04 PM) emanuele: A quick fix would be to simply initialize empty $first_subject just before:(11:26:08 PM) emanuele: // Check if it's locked. It isn't locked if no topic is specified.
Re: IRC Reply #243 – May 29, 2013, 04:52:25 pm (11:35:16 PM) elk_core: [Elkarte] eurich opened pull request #466: quick fix for the broken top bar (master...theme_fixins) http://git.io/vKClEQ(11:38:52 PM) elk_core: Elkarte/master 615c8c9 Thorsten Eurich: with "search_dropdown" enabled the top section bar was broken....(11:50:32 PM) elk_core: [Elkarte] eurich opened pull request #467: fixes for MessageIndex.subs (master...messageIndex) http://git.io/aRnLIQ(11:52:22 PM) elk_core: Elkarte/master 3cbfca0 Thorsten Eurich: - $topics needs to be initialized (undefined index error when board is empty)...(11:53:52 PM) elk_core: [Elkarte] norv opened pull request #468: Fix required files to SSI. (master...fixes_up) http://git.io/gzlG-w(11:54:52 PM) elk_core: Elkarte/master 4c9e5fc Norv: Fix required files to SSI....(11:55:38 PM) Norv: TE_: I fixed your access, if you want to take a look(11:59:57 PM) emanuele: Norv, if you start from the quick reply and click "preview" the body remains empty (I think it appears with errors too)(05/28/2013 12:48:47 AM) Norv: ffs we should log more. And debug mode, log things.(12:51:11 AM) Norv: I can replicate that locally, Ema. Trying to look at, but I still don't get the session issue. Is it possible a form doesn't send the field? Are layers correctly set up?(12:53:11 AM) emanuele: the input tag is there just before </form>(12:53:24 AM) emanuele: (I mean at elk.net)(12:54:23 AM) emanuele: I can't replicate the session locally...(12:54:38 AM) emanuele: is there anything in particular I should set up(12:57:27 AM) Norv: No... (12:57:53 AM) Norv: Bad moment for db structure backup to be broken too!(12:58:20 AM) emanuele: xD(12:59:59 AM) Norv: Ok, so from quick reply I can post, with the same sessionid. From modify/post, I can't. Does js mess with it... wait(01:00:21 AM) emanuele: drafts?(01:00:50 AM) emanuele: I can post! lol(01:05:25 AM) elk_core: [Elkarte] norv opened pull request #469: Fix database backup. (master...fixes_up) http://git.io/BOJGJQ(01:05:50 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/IhqUag(01:05:50 AM) elk_core: Elkarte/master daaacc1 Norv: Fix database backup....
Re: IRC Reply #244 – May 29, 2013, 04:55:10 pm (01:01:20 AM) emanuele: but not modify: Wrong value type sent to the database. Integer expected. (current_topic)(09:02:01 PM) elk_core: [Elkarte] norv opened pull request #470: Fix post edit issues (master...fixes_up) http://git.io/Uecu0g(09:09:03 PM) elk_core: [Elkarte] norv pushed 6 new commits to master: http://git.io/_olRIQ(09:09:03 PM) elk_core: Elkarte/master bbc8bea Norv: Post modify bug: wrong function used to get message data. (and a few other places)....(09:09:03 PM) elk_core: Elkarte/master c2d5e4f Norv: Try to fix names for these functions... basicMessageInfo() (argh still bad)......(09:36:55 PM) elk_core: Elkarte/master bcdef22 Norv: Dangling free_result() after the query was reworked....(09:09:46 PM) Norv: Oy, Ema! You're still Teh winner! (09:11:48 PM) Norv: Quickly: what does messageInfo(), getMessageInfo() and getExistingMessage() ? ROFL...(09:34:00 PM) emanuele: ...mmm...ehm...NFI(09:36:20 PM) Norv: https://github.com/norv/elkarte/commit/bbc8bea32d794e1ddbf43216ac32c05a955e77e7(09:40:18 PM) emanuele: messageInfo seems just a simpler version of getMessageInfo...(09:50:32 PM) Norv: https://github.com/elkarte/Elkarte/pull/470/files headscratch(09:51:13 PM) Norv: Gief better idea... (03:21:06 PM) elk_net: [elkarte.net] norv opened pull request #4: Sync (master...sync) http://git.io/LHNNmQ(03:58:28 PM) elk_net: [elkarte.net] norv pushed 3 new commits to master: http://git.io/rm4F1A(03:58:28 PM) elk_net: elkarte.net/master ae51e03 Norv: Site sync. (version on-site)...(03:58:28 PM) elk_net: elkarte.net/master 9e0aa06 Norv: Remove some debugging stuff. Update /install, for convenience of installation from the site repo....(10:13:48 PM) elk_core: [Elkarte] eurich opened pull request #473: fixes (master...more_fixes) http://git.io/hPhhOg(10:37:54 PM) elk_core: Elkarte/master 0c99660 Thorsten Eurich: wrong global used .....(10:37:54 PM) elk_core: Elkarte/master 148bb58 Thorsten Eurich: no need to initialize the db...(10:37:54 PM) elk_core: Elkarte/master 0d14ef9 Thorsten Eurich: uneeded code.....
Re: IRC Reply #245 – May 29, 2013, 04:57:56 pm (10:17:00 PM) emanuele: Norv there is still something broken somewhere...(10:17:39 PM) emanuele: If I have new messages in bug reports, I see the board marked "not read", but when I enter the topic doesn't have the "new" icon(10:18:13 PM) emanuele: also: http://www.elkarte.net/index.php?action=unread;board=1.0;children(10:23:16 PM) emanuele: that last one is my fault again! (10:24:05 PM) emanuele: require_once(SUBSDIR . '/Boards.subs.php');(10:24:06 PM) emanuele: just before: addChildBoards($boards);(10:24:08 PM) emanuele: in Recent.controller.php (sorry, I can't commit it at the moment... (10:32:10 PM) Norv: Fixed(10:42:42 PM) Norv: http://www.elkarte.net/index.php?action=markasread;sa=all;xml;api this doesn't go to xml apparently...(10:45:54 PM) emanuele: the xml part should be redundant, though guessing I'd say it's a syntax error somewhere...(10:46:09 PM) emanuele: Warning</strong>: Invalid argument supplied for foreach() in (10:46:17 PM) emanuele: themes/default/Xml.template.php(10:46:49 PM) emanuele: 343(10:47:19 PM) Norv: Yes, 'xml_data' is not xml(10:49:16 PM) emanuele: ahhh...mmm...meh...(10:50:10 PM) emanuele: initially I started thinking to allow multiple buttons in the xml(10:50:36 PM) emanuele: but then at some point I did something different...dunno if theme-wise or what(10:50:55 PM) emanuele: do you think make sense to allow return info related to multiple buttons at once?...(10:51:02 PM) emanuele: I think easy is better for now(10:51:33 PM) emanuele: change the template to:(10:51:35 PM) emanuele: http://pastebin.com/04Ad7eu4(10:52:07 PM) emanuele: and maybe change the <buttons> tag to <button>
Re: IRC Reply #246 – May 29, 2013, 05:01:36 pm (10:54:47 PM) emanuele: Not sure how to deal with that: markBoardsRead is used in MessageIndex.controller but the function does more than is should, in particular it updates log_mark_read(11:01:11 PM) Norv: and shouldn't it?(11:02:09 PM) Norv: Actually, I've done this... umm, wait, is this creating a bug? (sorry, trying to do several things at the time)(11:03:35 PM) emanuele: lol(11:04:18 PM) emanuele: yes, it creates a bug(11:04:41 PM) emanuele: when you enter a board the "new" tags disappear even if new topics are there(11:05:05 PM) Norv: Umm, no, that's expected(11:05:12 PM) emanuele: ?(11:05:35 PM) emanuele: it's expected than when you visit ?board=1.0 all the "new" should not be there?(11:05:46 PM) emanuele: that sounds strange to me...(11:05:48 PM) Norv: No, the board itself(11:05:59 PM) Norv: The topics are 'new' of course(11:06:41 PM) emanuele: IFNULL(lt.id_msg, IFNULL(lmr.id_msg, -1)) + 1') . ' AS new_from(11:07:17 PM) emanuele: if lt.id_msg is null then lmr.id_msg is used and if you update it to the latest message of the board...(11:07:21 PM) emanuele: the new disappears(11:10:21 PM) emanuele: (and lt.id_msg is null if the single topic has not been marked as read)(11:15:30 PM) Norv: You're right... I think this is very broken(11:17:06 PM) Norv: The thing is... What is it that you mean, when you 'mark board read'?(11:19:21 PM) emanuele: mark the board read, not the topics in there. (11:19:30 PM) emanuele: lol(11:19:40 PM) emanuele: in fact it has two interpretations(11:21:04 PM) emanuele: 1) mark all the topics in a certain board as read(11:21:30 PM) Norv: I think... that at this time, the function is used with three kinds of expectations, that it updates log_boards, that it updates log_mark_read too (mark the entire board as read and dont bother me with it), and there's also that attempt to clear log_topics(11:21:31 PM) emanuele: 2) remove the "unread" icon from the board(11:21:35 PM) Norv: yes(11:22:05 PM) Norv: That's the problem, and I'd say 3 - at least, it is used with all 3...(11:22:53 PM) emanuele: well, then maybe three different functions are better in that case... (11:23:06 PM) Norv: So if we use a single function for it, lets have markBoardsRead and markBoardsUnread separate, and with each have parameters or functions for those cases(11:24:36 PM) Norv: like, markBoardRead($id_boards, $include_topics = false, $clear_topics_logs = false) (11:37:39 PM) Norv: You fix this or I fix it, Ema?(11:37:52 PM) Norv: MessageIndex and Display I think, were affected(11:37:56 PM) Norv: (badly)(11:38:01 PM) ***emanuele is destroying the template_layers class, if you want feel free to! (11:38:06 PM) Norv: k(11:52:03 PM) Norv: I need the fix for membergroups... the $id_group thing(11:52:17 PM) emanuele: arg...(11:52:24 PM) Norv: but I don't dare to merge your PR as it is!(11:52:35 PM) emanuele: lol(11:52:30 PM) emanuele: well, you can apply the quick fix in the branch(12:05:50 AM) elk_core: [Elkarte] norv opened pull request #475: More from site errors. (master...fixes_up) http://git.io/KTEg8A(12:55:07 AM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/zHXOsQ(12:55:07 AM) elk_core: Elkarte/master 0c4fb3a Norv: Variable was initialized on a conditional branch....(12:55:07 AM) elk_core: Elkarte/master d02a9d8 emanuele45: Missing file for unread....(12:32:53 AM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/scwkJw(12:32:53 AM) elk_core: Elkarte/master 8d62de0 Norv: Back to LF. Add .gitattributes, to keep eol LF (this may need attention and tweaks)...(12:32:53 AM) elk_core: Elkarte/master 3cba7e2 Norv: Remove extra .txt...
Re: IRC Reply #247 – May 29, 2013, 05:04:31 pm (12:54:02 AM) elk_core: [Elkarte] norv pushed 57 new commits to master: http://git.io/pNOWOQ(12:54:02 AM) elk_core: Elkarte/master dcac7a1 Spuds: ! likes permissions...(12:54:02 AM) elk_core: Elkarte/master d02363e Spuds: ! likes language strings...(12:54:02 AM) elk_core: Elkarte/master c3357da Spuds: ! likes ACP feature page...(01:01:25 AM) emanuele: Is Earl still relevant for the avatars?(01:36:29 AM) elk_core: [Elkarte] norv opened pull request #476: Remove old fonts. (master...old_fonts) http://git.io/PguK7g(02:29:28 AM) elk_core: [Elkarte] Spuds opened pull request #477: Yup, removing code ... Me ... really ! (master...LessCode) http://git.io/JrQsFA(12:14:39 PM) elk_core: Elkarte/master 4588131 Spuds: ! Its either markdownify or html2md ... right now its html2md...(10:47:23 AM) groundup: ugh, uploading to AWS. It has got to be the slowest connection I've ever had while working on servers(07:40:03 PM) elk_core: [Elkarte] eurich opened pull request #478: Code cleaning (master...code_cleaning) http://git.io/pxqmFQ(08:13:20 PM) elk_net: [elkarte.net] norv opened pull request #5: Quick fixes made on site. (master...fix) http://git.io/zNVssA(08:14:05 PM) elk_net: elkarte.net/master 575dca9 Norv: Fix wrong function used...(08:14:05 PM) elk_net: elkarte.net/master 46a87ae Norv: Variable initialized in the wrong place...(08:14:05 PM) elk_net: elkarte.net/master 143c799 Norv: Correct name of the db method....(10:15:48 PM) elk_core: [Elkarte] norv pushed 21 new commits to master: http://git.io/tib3JQ(10:15:48 PM) elk_core: Elkarte/master e589d2e Thorsten Eurich: var was unused in its scope....(10:15:48 PM) elk_core: Elkarte/master 91a688d Thorsten Eurich: unused global...(10:15:48 PM) elk_core: Elkarte/master 87b2cfc Thorsten Eurich: missing docs.....
Re: IRC Reply #248 – May 29, 2013, 05:13:35 pm (05:35:45 PM) emanuele: https://github.com/SimpleMachines/SMF2.1/issues/379(07:38:57 PM) Norv: Well, can you currently remove first post, and thereby make the second "first"?(07:39:25 PM) Norv: (I remember we discussed this in the past, but don't remember the outcome lol)(07:41:02 PM) emanuele: Yep, we discussed about delete the first message and the decision was not to allow it(07:42:01 PM) Norv: So we took first message as "the topic" in a sense(07:41:39 PM) Norv: just to note, > or those that are moderators that reply.(07:41:39 PM) Norv: This quite makes sense to me... The rest seems overkill in more than one sense: I'm not against it, but we might need even more flexibility of code and UI than we have in Elk even. As for SMF2.1...(07:44:08 PM) emanuele: Yep, though when you try to delete the first message you get the error: no you can't, use "remove topic"(07:44:19 PM) emanuele: so in a way or another is a bit inconsistent...(07:44:27 PM) emanuele: overkill is probably true too(07:44:58 PM) Norv: Oh yes... why doesn't delete message redirect itself to topic removal anyway? (with the clear warning of course)(07:45:28 PM) emanuele: fail safe?(07:45:40 PM) Norv: Dunno, Ema, you seem to feel that more flexibility (and breaking limits) between posts and topics would be useful... Me doesn't quite know. When would it be useful? You can already split, then remove...(07:46:09 PM) Norv: Well, then just hide it from the first post...(07:46:28 PM) emanuele: Well, I'm not really concerned by delete at that point... (07:48:21 PM) Norv: lol(07:49:22 PM) Norv: you said it yourself, they're related in a way. If you unapprove first post only, and leave the rest visible, what you do is create a topic from the second...(07:49:34 PM) ***Norv thinks it's a bigger code change than it may seem(07:49:42 PM) emanuele: oh...nope(07:49:48 PM) Norv: No?(07:50:17 PM) emanuele: if a member post an unapproved topic only the first message is "unapproved", all the answers may or may not be approved(07:50:42 PM) emanuele: when you unapprove a topic all the messages in the topic are marked unapproved(07:51:13 PM) Norv: A normal user won't see any in both cases.(07:51:48 PM) emanuele: true, but the OP can view the answer if they are not unapproved(07:52:17 PM) Norv: Or they belong to moderators: this is probably the issue(07:54:17 PM) Norv: It's not consistent, sure, that the poster no longer sees mods answers in the the second case. In the first case they would only see mods answers anyway.(07:56:17 PM) emanuele: Obviously, since mods are anyway the only ones that should be able to post in an unapproved topic(07:57:44 PM) emanuele: (and the OP)(07:59:41 PM) Norv: IMO, it makes sense to behave the same way the first case does... That leaves unanswered the question on other posters and their posts (which may exist in the second case)(08:01:36 PM) Norv: It'd be probably nice to allow the initial poster to see those too (since they did anyway at one point), I just dunno how relevant it is in practical terms.(08:01:20 PM) emanuele: To have it consistent with the delete, we should have an useless button in the first message that tells "to unapprove do something else" and an "unapprove topic" button the unapprove only the topic (in {db_prefix}topics) and the first message (in {db_prefix}messages)(08:01:39 PM) Norv: LOL(08:01:44 PM) Norv: Noez(08:02:14 PM) Norv: But they should see mods answers, both existing and newer...(08:02:46 PM) emanuele: then it should do what I said above. (08:03:10 PM) emanuele: (i.e. it should set the topic as if it was started as unapproved)(08:04:02 PM) Norv: If you do that, how will be the consequences on the other posters and their posts?(08:04:21 PM) Norv: (Agree anyway)(08:04:35 PM) emanuele: You mean in terms of post counts?(08:04:48 PM) emanuele: Or what?(08:05:25 PM) ***emanuele goes away for a while(08:05:34 PM) Norv: No, as in: the poster sees them or not (I think it's yes), the other posters see their own messages or not, the other posters can modify/reply to their own messages
Re: IRC Reply #249 – May 29, 2013, 06:10:42 pm Just to note. (on the run, sorry, just pasting and re-reading the logs)Quote from: TestMonkey – May 29, 2013, 04:45:52 pm(11:12:07 PM) Norv: [...] For getFormMsgSubject()(11:25:16 PM) emanuele: I don't like that much that function TBH...Agree. Looks like this one does two things ($editing as param, and $_REQUEST['msg'] used... I'd use something like $id_msg to make the difference, in the vein of others... i.e. formSubject(..., $id_msg = null)Also, it doesn't do it for other calls for some similar things, such as action_quotefast() (or, not sure, even action_jsmodify?).And, it uses more of them superglobals.Just to note, perhaps something to look at, next pass. Also I was doing a rework of action_quotefast() somewhere in a branch, will be back on it.
Re: IRC Reply #250 – May 30, 2013, 06:49:25 pm (06:01:14 AM) elk_core: [Elkarte] Spuds opened pull request #479: Minor fix to likes, topic_id is in the array, not a seperate var (master...lf) http://git.io/tKKOsw(09:24:35 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/uWEmxw(09:24:35 AM) elk_core: Elkarte/master bce01e0 Spuds: ! Wrong variable used in the topic like...(05:37:45 PM) elk_core: [Elkarte] norv pushed 6 new commits to master: http://git.io/7jvwKQ(05:37:46 PM) elk_core: Elkarte/master b101d6e Thorsten Eurich: basic cleaning / methods visibility...(05:37:46 PM) elk_core: Elkarte/master 022af76 Thorsten Eurich: make sure we use an integer.....(05:37:46 PM) elk_core: Elkarte/master 8793d66 Thorsten Eurich: moved db query to subs....(06:49:39 PM) emanuele: The package manager is badly broken too!! (06:56:40 PM) emanuele: Norv: DbTable-mysql.php, function __construct, $db_prefix is undefined, I suppose a global is enough, right?(07:01:07 PM) Norv: yes(07:01:15 PM) Norv: but I thought I fixed that...(07:01:28 PM) ***Norv has lost count in which repo when(07:02:20 PM) emanuele: lol(07:03:20 PM) emanuele: there is also a require_once missing and another undefined index error in Packages.php(07:03:24 PM) emanuele: I'll send a PR later(07:16:54 PM) emanuele: smf_scripturl(07:17:00 PM) ***emanuele whistles innocently(07:17:32 PM) Norv: we haz yet a bunch of js to rename, huh?(07:18:02 PM) emanuele: yups(07:33:26 PM) ***emanuele doesn't understand what "stateObj" is in history.pushState...(09:09:33 PM) elk_core: [Elkarte] eurich opened pull request #480: small fixes (master...theme_fixes) http://git.io/09LgZQ
Re: IRC Reply #251 – May 30, 2013, 07:48:14 pm (09:32:11 PM) ***emanuele downloads WBB(09:34:47 PM) ***emanuele tries to install WBB(09:35:31 PM) ***emanuele got an Access forbidden on his own computer... lol(09:35:48 PM) Norv: It could be interesting. I have countless databases of these proprietary-paid forums software, but never an install lol(09:35:50 PM) Norv: LOL! They guessed ya! (09:36:27 PM) emanuele: headscratch(09:42:48 PM) emanuele: meh...it doesn't even create the database when installing...(09:43:23 PM) Norv: Yah, seen that to others... requires you to have it already, right?(09:43:34 PM) emanuele: yep(09:43:53 PM) emanuele: 108 tables...not bad...(09:45:04 PM) emanuele: is it trying to kill my hard-disk?...(09:57:19 PM) emanuele: strike bbcode doesn't work in the wysiwyg editor (wbb)(09:58:48 PM) Norv: bulk processing of threads and posts, interesting.(10:02:15 PM) ***Norv doesn't get this... For a 'forum', I haz a tab for permissions, which says 'enter username or group'. Manually. Erm?(10:02:32 PM) emanuele: yeah...I skipped that one... lol(10:05:19 PM) emanuele: do you have any idea of how I'm supposed to reach the admin panel from the forum?(10:05:34 PM) emanuele: found(10:05:49 PM) Norv: Mmm... (10:06:21 PM) emanuele: The location of the link doesn't sound logic to me... lol(10:06:33 PM) Norv: It haz topic tags!(10:06:39 PM) ***Norv wonders what it does with them(10:06:58 PM) emanuele: (one of the most useless things in history? )(10:07:20 PM) emanuele: Hey TehCraw you like tags don't you? (10:07:45 PM) TehCraw: Don't even go there right now.(10:07:53 PM) emanuele: lol
Re: IRC Reply #252 – May 30, 2013, 07:50:20 pm (10:11:16 PM) ***Norv wonders what means undone threads(10:11:55 PM) emanuele: where?(10:12:06 PM) emanuele: ahhh...(10:12:08 PM) emanuele: no idea(10:12:15 PM) emanuele: and how do you delete one?(10:12:43 PM) emanuele: the reply is nice(10:13:46 PM) emanuele: okay...so to delete a topic I have first to "mark" everything? (10:14:11 PM) ***Norv haz no clue yet...(10:14:21 PM) Norv: You're in an advanced stage! LOL(10:14:45 PM) ***emanuele is just clicking around with the basic stuff(10:14:47 PM) emanuele: lol(10:15:41 PM) Norv: I have some errors, probably it affected some stuffs... mmm(10:18:25 PM) ***emanuele wonders if there is a debug mode that shows queries...(10:22:11 PM) Norv: > Find threads tagged with “info”(10:22:19 PM) Norv: Cool(10:23:25 PM) Norv: Profile 'wall'(10:23:43 PM) ***Norv starts to understand why the ~120 db tables (10:24:05 PM) emanuele: meh...why FB should rule the interwebz...(10:25:02 PM) emanuele: found a debug mode, now I have to understand where it is used...(10:27:42 PM) ***Norv doesnt get the UI... a tabbed 'dashboard' it keeps returning to(10:28:08 PM) emanuele: Nice all the drag and drops, but how do you swap the order of two smiles on two different pages? (10:28:22 PM) Norv: LOL!(10:29:19 PM) Norv: Ah, small thing: I think, when you go to profile, you have three tabs, and first time you click on each they're js loaded(10:29:58 PM) emanuele: yep(10:30:01 PM) emanuele: they are(10:30:13 PM) emanuele: like the menus at the top(10:30:22 PM) emanuele: notifications, moderation and conversation(10:30:40 PM) emanuele: when you click it loads something through ajax(10:35:27 PM) Norv: sidebar... drag and drop boxes for it. Not bad as idea, although hmm, I enabled everything and I haz only 3 on dashboard and 1 on 'forum' ...(10:37:08 PM) ***emanuele stops playing and goes push the template layers changes... (10:38:45 PM) emanuele: where?(10:38:48 PM) emanuele: the sidebar I mean(10:44:07 PM) emanuele: You mean that page: http://img69.imageshack.us/img69/9393/screen97c.png ?(10:48:04 PM) Norv: No, in system(10:48:07 PM) Norv: acp/index.php/Option/54/(10:48:31 PM) Norv: (you are under Community)(10:50:10 PM) Norv: Lol... System > Options > Dashboard, on one hand.(10:50:10 PM) Norv: Community > Dashboard > Configuration, on the other. headscratch (is the user supposed to just know the difference?)(10:53:18 PM) emanuele: ...is there a difference?(10:54:16 PM) Norv: ...(10:54:19 PM) Norv: lol(10:55:42 PM) Norv: (I probably miss how to configure those blocks or something)(10:54:51 PM) Norv: Hey I am seeing this right! On the forum view, the title of the thread in the listing is linked to first unread!
Re: IRC Reply #253 – May 30, 2013, 07:52:53 pm (11:03:00 PM) elk_core: [Elkarte] emanuele45 opened pull request #481: Template layers v2 (master...template_layers_v2) http://git.io/CNnDVA(11:26:08 PM) emanuele: Norv, what do you think: http://pastebin.com/KgHdqjbC(11:27:47 PM) emanuele: It's for https://github.com/elkarte/Elkarte/pull/450(11:28:39 PM) ***Norv gets a bit dizzy from the infinite recursion (11:29:18 PM) emanuele: there is a 1 letter difference! (11:29:33 PM) Norv: LOL(11:29:49 PM) Norv: I think I like it(11:29:51 PM) Norv: (11:29:55 PM) emanuele: lol(11:30:06 PM) ***emanuele comes back when you are sure you like it (11:30:11 PM) Norv: haha(11:37:13 PM) Norv: Seriously, I think it's better than any other option(11:37:45 PM) Norv: Implementations one near the other, you'd always know what you're dealing with
Re: IRC Reply #254 – May 30, 2013, 07:53:52 pm (11:49:24 PM) Norv: IMHO, 450 would be great if rebased: with the first few fixes squashed into the first commit, similar for the funny membergroupby, your friend(11:50:36 PM) emanuele: (11:50:38 PM) emanuele: lol(11:51:54 PM) emanuele: to do it now I'd have to save a branch, reset --hard to remove the merge, rebase, cherry-pick (rebase again to remove the other ooops) ... (11:52:26 PM) Norv: no cherry(11:53:15 PM) Norv: I'd try this: another branch from it (for safety of experiment); then, rebase -i master(11:53:36 PM) emanuele: but I already merged master...(11:57:14 PM) ***Norv tries(05/31/2013 12:00:12 AM) emanuele: Did you see the mod I wrote using the layers_v2 branch before elk.net disappeared?(12:00:47 AM) emanuele: http://imageshack.us/a/img694/2870/screen97w.png(12:00:51 AM) emanuele: http://imageshack.us/a/img825/7818/screen97h.png(12:01:28 AM) Norv: Yes, it's very cool!(12:02:15 AM) Norv: oh, elk must be back, looked like a fluke of slowness here...(12:02:43 AM) emanuele: opendns is still not happy... (12:03:22 AM) emanuele: BTW I think I'd prefer to test the layers branch just another time because I'm not 100% sure I tested the mod with the very final version...(12:28:58 AM) Norv: Mmm, pekbac. It works as expected - it includes initially the rest of the merged commits (so twice) but they can be safely commented out.(12:48:25 AM) elk_core: [Elkarte] norv opened pull request #482: reorg_function (Ema) (master...ema_r) http://git.io/aiyoKw(12:49:25 AM) elk_core: [Elkarte] norv pushed 13 new commits to master: http://git.io/3UAxkQ(12:49:25 AM) elk_core: Elkarte/master 538a273 emanuele: Rework of retrieveMemberData, approveMembers and enforceReactivation to make them more flexible...(12:49:25 AM) elk_core: Elkarte/master b77feba emanuele: No, this is correct like this, otherwise the last check is broken...(12:49:25 AM) elk_core: Elkarte/master c51946c emanuele: Fixed topic announcement, added group_name to the query in getGroups and removed the redundant query in Announce_Controller->action_selectgroup...
Modern, Free, Powerful