ElkArte Community

Elk Development => Feature Discussion => Exterminated Features => Topic started by: Spuds on October 24, 2013, 02:30:48 pm

Title: Profile Summary
Post by: Spuds on October 24, 2013, 02:30:48 pm
Got around to taking a look at things which may jazz that screen up a bit.  In addition to finding a few more bugs :P here is a screen shot that shows it as a block style layout, much like the moderation and admin landing pages.  We can also add in a hook so addional blocks could be added and/or existing ones removed.

The buddies block at the top is only shown for your own profile ... there is also a moderation block (not shown in the screen capture) that will show up if you have those permissions.

Anyway before I did much more wanted to get feedback if this is a direction we want to go or not!
Title: Re: Profile Summary
Post by: emanuele on October 24, 2013, 03:01:29 pm
/me thinks it looks already much better than the current one! :D
Title: Re: Profile Summary
Post by: IchBin on October 24, 2013, 03:16:09 pm
Agree with ema. However, I'm not sure I like the buddies at the top of my profile. Not that I look at my profile all that often, just seems like the more important info should first be visible.
Title: Re: Profile Summary
Post by: Spuds on October 24, 2013, 03:24:50 pm

Quote from: IchBin – Agree with ema. However, I'm not sure I like the buddies at the top of my profile. Not that I look at my profile all that often, just seems like the more important info should first be visible.
So move it down to just above the attachments or other options?   I could also make it a narrow block but it gets pretty packed up that way.
Title: Re: Profile Summary
Post by: emanuele on October 24, 2013, 05:15:02 pm
There may be some kind of updates from buddies?...

/me runs!
Title: Re: Profile Summary
Post by: [SiNaN] on October 24, 2013, 05:41:57 pm
I guess it looks a little too blocky, if I may say. I'd rather have a kind of sidebar on the left and put avatar and some of the personal information there. I'd also list the buddies there, vertically, along with profile visitors, if the feature is added. As far as the right main part goes, what I'd expect is user's content. Attachments are a start but that is the last thing when I think of content. I think some of the posts and topics of the user should be listed there, along with attachments, possibly tabbed. Data from likes feature would be very useful as well, like listing liked stuff or user's stuff liked by other members. I know that they're all available as sub sections but as a user I expect to see a part of the content right on that main profile page and if want to further look into a particular type of content, I'll use the sub sections. I guess I expect the page to be kind of like a member portal, if you know what I mean. Also, I think profile comments would be a very important addition. It really enhances the community feeling. These two are good examples of what I mean: GitHub (https://github.com/silentguardian) and MyAnimeList (http://myanimelist.net/profile/basmimarsinan).
Title: Re: Profile Summary
Post by: Spuds on October 24, 2013, 07:41:54 pm

Quote from: [SiNaN] – I guess it looks a little too blocky, if I may say.
Coming from the "block king" thats harsh :'( ;D ;D
Quote I'd rather have a kind of sidebar on the left and put avatar and some of the personal information there. I'd also list the buddies there, vertically, along with profile visitors, if the feature is added.
I can do a more compact buddies list and place it on the left.  We have not added any profile visitors option to the code, that would be for a 1.1 should there be a desire for it as we are actually trying to wrap up 1.0 features.
QuoteAs far as the right main part goes, what I'd expect is user's content. Attachments are a start but that is the last thing when I think of content. I think some of the posts and topics of the user should be listed there, along with attachments, possibly tabbed. Data from likes feature would be very useful as well, like listing liked stuff or user's stuff liked by other members.
Humm those are good ideas for some additional blocks,  like the last 5-10 or so posts, liked, liked by, topics etc ... Don't know about tabbed at this point, maybe if Ant gets some time.  If I make all the "main" blocks wider I could add a simple drag sortable option as well (could do that with the current arrangement as well but it can lead to some broken things that I don't want to deal with ATM)

QuoteAlso, I think profile comments would be a very important addition. It really enhances the community feeling.
Thats a good idea as well, and another thing for 1.1 !  

Darn, right in front of my face every day !  Need to do some more thinking of what I can do ... there is a freeze warning looming ;)  Thanks for your input, great feedback.
Title: Re: Profile Summary
Post by: [SiNaN] on October 25, 2013, 04:22:40 pm
Quote from: Spuds – Coming from the "block king" thats harsh :'( ;D ;D
I guess it sounds weird coming from me, lol. To be honest, I've been hoping to get rid of the blocky layout with SimplePortal for quite some time too, which was inspired by PHP-Nuke.

And you're welcome. Good luck with implementing those!
Title: Re: Profile Summary
Post by: Antechinus on October 25, 2013, 04:29:50 pm
Problem with sidebars of any sort is varying screen res. At some point it'll start looking borked.

Agree about the "blocky". The overall look reminds me of the old Ultimate Profile mod, which to my eye always looked like a bit of a mess due to the block heights being all over the place.

How about (random thought) keeping the two column layout but using fewer visible wrappers? Sort of like the change I made to the old stats page.
Title: Re: Profile Summary
Post by: Spuds on October 25, 2013, 04:32:55 pm
Played around with this a bit more ...

Still have not replaced the block's on the summary page as I'm still deciding what to do

Also gave tabs a try,  I could not find a css only solution that did not have some sort of problem, either not working in <ie9 or if it did, the tabs did not fallback cleanly or had accessibility issues.  So in the end I just used good old jQuery, which leaves the markup very clean, the css is a bit ugly due to all the selectors jQuery adds but thats the way it goes

I did add in recent posts and recent topics started by "blocks" and placed them in a seperate tab with the attachments

Moved buddies to its own tab


QuoteHow about (random thought) keeping the two column layout but using fewer visible wrappers? Sort of like the change I made to the old stats page.
I'll take a look at that ... right now it was modeled after the mod and admin landing pages (had to start somewhere)

Todays screen shots attached.
Title: Re: Profile Summary
Post by: Spuds on October 25, 2013, 10:46:39 pm
And here is a less block like version (I hope !)

This keeps the same left sidebar on all the pages (at a glimpse sidebar view), then the main section is based on the tab you choose ...
Title: Re: Profile Summary
Post by: IchBin on October 25, 2013, 11:20:00 pm
That looks pretty nice! Nice work Spudz!
Title: Re: Profile Summary
Post by: TE on October 26, 2013, 03:39:32 am

Quote from: IchBin – That looks pretty nice! Nice work Spudz!
+1. 
My favourite would be tabs with blocks (reply #9, [font='Segoe UI', 'Helvetica Neue', 'Liberation Sans', 'Nimbus Sans L', Arial, sans-serif]http://www.elkarte.net/index.php?topic=692.msg4894#msg4894)[/font],  but all of them are way better than the old "SMF" profile. Great work...
Title: Re: Profile Summary
Post by: Antechinus on October 26, 2013, 04:31:02 pm
Looks pretty good on the whole, but given the problems the sidebar is likely to cause on some screens, I'd be more inclined to have the basic info/avatar across the top. If someone wants to use the sidebar menu on a 1024 (yes, people do that fudge nuggets) the proposed layout is going to be really cramped.
Title: Re: Profile Summary
Post by: emanuele on October 26, 2013, 04:36:28 pm
s/Data/Recent activity/?
Title: Re: Profile Summary
Post by: Spuds on October 26, 2013, 04:39:33 pm
I did one last "tweak" so to speak .. dropped the sidebar for the moment as it does seem to lead to some problems.


The blocks now have the same background as the parent div, so when there is whitespace due to size differences its not so odd looking.  I'm sure it can be improved but for now its what I have ... I'll make a PR with the changes soon ... found a few buggies while doing all this so trying to sort that out plus clean up some of my mess in the CSS O:-)

Quotes/Data/Recent activity/?
Thanks for the reminder, thats all hard coded in ATM, need to move it to $txt and give it a better name than data lol
Title: Re: Profile Summary
Post by: emanuele on October 26, 2013, 05:52:18 pm
ARG!!
Hardcoded!! :P
Title: Re: Profile Summary
Post by: TE on November 01, 2013, 07:16:58 am
while fixing some other template related bugs I've played with the buddies on the profile summary page.

Like or switch back to the older one?
Title: Re: Profile Summary
Post by: emanuele on November 01, 2013, 09:42:25 am
/me likes
Title: Re: Profile Summary
Post by: TE on November 01, 2013, 10:43:53 am
Reworked recent attachments, too.  Attachment is two messages above.

Spuds did a great job, it's just a little bit fine tuning.
Title: Re: Profile Summary
Post by: Spuds on November 01, 2013, 10:54:49 am
Looks 8) ... the attachments is a nice update, may need to consider that look for the post attachments O:-) 

I was going to add more tabs but then figured thats a 1.1 option as I'd like to make the tab "load" an ajax thing so the intial page load is not so large, (not so many querys).  Not bad now since its a profile view, but tabs for likes, notifications, etc for the future.  Since the tabs are already jQuery it shoudl nto be to much to ajaxify the content ... must resist urge :P

Quoteemanuele likes
There is a button for that too! :D
Title: Re: Profile Summary
Post by: TE on November 01, 2013, 11:08:09 am
 :)  Send a PR with this and some fixes:
https://github.com/elkarte/Elkarte/pull/961