ElkArte Community

Ok, I'm making this my official code dump thread. Keep it all in one place.  ;)
I'll just keep adding zips to this post, and I'll reference them from an update post (including a link to any relevant Github issues).
Anyone who wants to can just grab a zip and turn it into a PR. As long as we're going frontwards it's all good. :)

ETA: Deleted the four oldest zips, as they are no longer relevant.
ETA2: Removed the next four oldest.

K, fourth zip (http://www.elkarte.net/index.php?action=dlattach;topic=468.0;attach=235) is up in the OP.

This is just the stuff that was talked about here (http://www.elkarte.net/index.php?topic=439.msg3242#msg3242) and the next posts.

Shouldn't cause any problems. I'm loving the contents and section headers stuff. I can find things now (usually).

Indeed, commits per issue to fix is the preferred way, for easier diff, checking out by others, understanding them, investigating history and eventual merge/revert. Thank you for trying to propose updates one at the time.

Re:
I'm sure you understand that we may get to attachments posted on forum when we get to them. Don't take it for granted that we'd get to attachments on forum "now".
Please remember, zipped batches are outside the normal development process, and they need someone to apply them on a certain point in repo history, to diff and check and commit. I appreciate the assistance Spuds has offered with it, and made it possible for Elk core to get the updates, and split more understandably at that.


Now, updates in small batches makes it easier for everyone. I really appreciate the current thread for this reason too. I hope it's a good compromise.
One more bit: could you please specify the commit? (because it's a replace of files, to avoid missing things).

Re: the name of this thread:
Sorry, but I won't usually have time to assist (and I don't usually keep tabs on css/theming). I will be clear on this: don't rely on Norv 'cause Norv is caught in reworking the core, breaking Ema's fixes (yes, it's possible!), writing long posts at times, and other must-do's. Grumbling on mooses is an extra. Theming shouldn't wait for me, that'd be a very bad idea (tm).
But, people have offered to assist with the necessary, and have done so, thus far.  It just won't be "now". It's when we get to them. Someone will (or give an answer), when we can get to it.

---

That said. I've taken in this round. It's a really cool one IMHO: the cleaning and resorting, and the separation issue by issue, and with copious readme's. With these, you've just upped the standard on good and detailed commits comments! ;D  Note taken! (btw, now you realize we expect the same, right? lol)

Thank you for the work on it. Turn this thing around, if that's what you want, it needs it. Just do it so that us mortals can follow it.

For the record, I'll cross-ref here:
For a set of fixes proposed here we took into Elk, https://github.com/elkarte/Elkarte/pull/589.
For the css refactoring, https://github.com/elkarte/Elkarte/pull/591.

Thanks Norv. Was a little confusing for me to find where things were posted and what needed to be put into the code for a PR, since I'm not here every day. I started this topic for ant to post his updates to theme stuff. If he can manage to post any updates to that topic, I'll be glad to do the code merges for him into our repo's.

http://www.elkarte.net/index.php?topic=472.0

Strike that. Somehow I didn't see your OP here Ant. clicked the unread to only see Norv's last post. I'll mark this topic notify and will watch this topic from now on!

Maybe someone can add me as moderator so I can change the icon on Ant's posts to indicate I've taken care of the code update? Not sure of the best way to handle the indication, so if you have suggestions I'm all ears. :)

Yes I realise that. I was just a tad worried it may have been overlooked by mistake, since the one after it had been grabbed. I wasn't meaning to give anyone a hard time about it.


Not sure what you mean here (about specifying the commit).


No prob but, as I understand it, either yourself or Spuds is responsible for the final sign off on merges that are accepted for the main repo, so making my code dumps more comprehensible is still being nice to Norv and Spuds, yes? :D

I'm not saying I expect you to handle all the PR's.


ETA: IchBin as local mod sounds like a plan.

Maybe I'll just edit your posts and put a note in that I've taken care of things from here on out.

Hmm, actually that glow tag one could probably do with a slight revision. It's outputting the bbc like this:

[glow=red,2,300]Vestibulum pharetra vitae elit ac scelerisque[/glow]

Really it should just do the $1 and nothing else. The extra ,2,300 should be ditched. Not sure how to do that.

Ok, got those Subs tweaks amalgamated into one fle, and added a few other things (@todo notes worth having, and a flash fix).

Zip is this one (http://www.elkarte.net/index.php?action=dlattach;topic=468.0;attach=259).  :)

--edit-- PR request #596
https://github.com/elkarte/Elkarte/pull/596

I'll push the changes later this day (I'm @work and it is early in the morning in germany) :P