Being nice to Spuds and Norv (just for a change).

Topic: Being nice to Spuds and Norv (just for a change). (Read 21590 times) previous topic - next topic

0 Members and 1 Guest are viewing this topic.

Being nice to Spuds and Norv (just for a change).

June 24, 2013, 04:31:20 am

Ok, I'm making this my official code dump thread. Keep it all in one place.

I'll just keep adding zips to this post, and I'll reference them from an update post (including a link to any relevant Github issues).
Anyone who wants to can just grab a zip and turn it into a PR. As long as we're going frontwards it's all good.

ETA: Deleted the four oldest zips, as they are no longer relevant.
ETA2: Removed the next four oldest.

Re: Being nice to Spuds and Norv (just for a change).

Reply #1 – June 24, 2013, 11:10:58 pm

K, fourth zip is up in the OP.

This is just the stuff that was talked about here and the next posts.

Shouldn't cause any problems. I'm loving the contents and section headers stuff. I can find things now (usually).

Re: Being nice to Spuds and Norv (just for a change).

Reply #2 – June 25, 2013, 09:30:16 pm

Indeed, commits per issue to fix is the preferred way, for easier diff, checking out by others, understanding them, investigating history and eventual merge/revert. Thank you for trying to propose updates one at the time.

Re:

Quote from: Antechinus – June 22, 2013, 08:16:24 amAlso, is anyone going to downlaod the pile of code I did? It's been sitting there for over 48 hours without being touched, but the tiny zip for the editor has already been downloaded.

I'm sure you understand that we may get to attachments posted on forum when we get to them. Don't take it for granted that we'd get to attachments on forum "now".
Please remember, zipped batches are outside the normal development process, and they need someone to apply them on a certain point in repo history, to diff and check and commit. I appreciate the assistance Spuds has offered with it, and made it possible for Elk core to get the updates, and split more understandably at that.

Now, updates in small batches makes it easier for everyone. I really appreciate the current thread for this reason too. I hope it's a good compromise.
One more bit: could you please specify the commit? (because it's a replace of files, to avoid missing things).

Re: the name of this thread:
Sorry, but I won't usually have time to assist (and I don't usually keep tabs on css/theming). I will be clear on this: don't rely on Norv 'cause Norv is caught in reworking the core, breaking Ema's fixes (yes, it's possible!), writing long posts at times, and other must-do's. Grumbling on mooses is an extra. Theming shouldn't wait for me, that'd be a very bad idea (tm).
But, people have offered to assist with the necessary, and have done so, thus far. It just won't be "now". It's when we get to them. Someone will (or give an answer), when we can get to it.

That said. I've taken in this round. It's a really cool one IMHO: the cleaning and resorting, and the separation issue by issue, and with copious readme's. With these, you've just upped the standard on good and detailed commits comments!

Note taken! (btw, now you realize we expect the same, right? lol)

Thank you for the work on it. Turn this thing around, if that's what you want, it needs it. Just do it so that us mortals can follow it.

For the record, I'll cross-ref here:
For a set of fixes proposed here we took into Elk, https://github.com/elkarte/Elkarte/pull/589.
For the css refactoring, https://github.com/elkarte/Elkarte/pull/591.

Re: Being nice to Spuds and Norv (just for a change).

Reply #3 – June 25, 2013, 09:35:04 pm

Thanks Norv. Was a little confusing for me to find where things were posted and what needed to be put into the code for a PR, since I'm not here every day. I started this topic for ant to post his updates to theme stuff. If he can manage to post any updates to that topic, I'll be glad to do the code merges for him into our repo's.

http://www.elkarte.net/index.php?topic=472.0

Strike that. Somehow I didn't see your OP here Ant. clicked the unread to only see Norv's last post. I'll mark this topic notify and will watch this topic from now on!

Re: Being nice to Spuds and Norv (just for a change).

Reply #4 – June 25, 2013, 09:55:48 pm

Maybe someone can add me as moderator so I can change the icon on Ant's posts to indicate I've taken care of the code update? Not sure of the best way to handle the indication, so if you have suggestions I'm all ears.

Re: Being nice to Spuds and Norv (just for a change).

Reply #5 – June 25, 2013, 10:00:00 pm

Quote from: TestMonkey – June 25, 2013, 09:30:16 pm
Quote from: Antechinus – June 22, 2013, 08:16:24 amAlso, is anyone going to download the pile of code I did? It's been sitting there for over 48 hours without being touched, but the tiny zip for the editor has already been downloaded.
I'm sure you understand that we may get to attachments posted on forum when we get to them. Don't take it for granted that we'd get to attachments on forum "now".

Yes I realise that. I was just a tad worried it may have been overlooked by mistake, since the one after it had been grabbed. I wasn't meaning to give anyone a hard time about it.

QuoteNow, updates in small batches makes it easier for everyone. I really appreciate the current thread for this reason too. I hope it's a good compromise.
One more bit: could you please specify the commit? (because it's a replace of files, to avoid missing things).

Not sure what you mean here (about specifying the commit).

QuoteRe: the name of this thread:
Sorry, but I won't usually have time to assist (and I don't usually keep tabs on css/theming). I will be clear on this: don't rely on Norv 'cause Norv is caught in reworking the core, breaking Ema's fixes (yes, it's possible!), writing long posts at times, and other must-do's. Grumbling on mooses is an extra. Theming shouldn't wait for me, that'd be a very bad idea (tm).
But, people have offered to assist with the necessary, and have done so, thus far. It just won't be "now". It's when we get to them. Someone will (or give an answer), when we can get to it.

No prob but, as I understand it, either yourself or Spuds is responsible for the final sign off on merges that are accepted for the main repo, so making my code dumps more comprehensible is still being nice to Norv and Spuds, yes?

I'm not saying I expect you to handle all the PR's.

ETA: IchBin as local mod sounds like a plan.

Re: Being nice to Spuds and Norv (just for a change).

Reply #6 – June 26, 2013, 08:49:42 pm

Maybe I'll just edit your posts and put a note in that I've taken care of things from here on out.

Re: Being nice to Spuds and Norv (just for a change).

Reply #7 – June 26, 2013, 09:11:32 pm

Hmm, actually that glow tag one could probably do with a slight revision. It's outputting the bbc like this:

Code: [Select]

[glow=red,2,300]Vestibulum pharetra vitae elit ac scelerisque[/glow]

Really it should just do the $1 and nothing else. The extra ,2,300 should be ditched. Not sure how to do that.

Re: Being nice to Spuds and Norv (just for a change).

Reply #8 – June 28, 2013, 07:08:11 pm

Ok, got those Subs tweaks amalgamated into one fle, and added a few other things (@todo notes worth having, and a flash fix).

Zip is this one.

--edit-- PR request #596
https://github.com/elkarte/Elkarte/pull/596

Re: Being nice to Spuds and Norv (just for a change).

Reply #9 – July 01, 2013, 09:49:21 pm

Another one up: http://www.elkarte.net/index.php?action=dlattach;topic=468.0;attach=262

Includes a fix for #583. Otherwise fairly minor stuff.*

The markup in several areas was related, so I thought I should hit them all in this lot. It's still not too scary.

Will probably get onto the board index rebuild tonight, but thought that should be separate.

*ETA: Just thought of something. Don't worry if the some of message index table rows are missing some of their styling after applying this one. I've already got the code for the board and message index rebuilds sorted, which will include the relevant css. I'm going with a simplified setup that will cut code and look better. I can transfer it over from my local host backup to my test site tonight pretty quickly, then get another zip up. Once both are in it should all be good.

Also: just remembered that in index.css I had the max-wdth restricted while testing layout. People might be happier with that set back to 95em instead of 72em (Line 58 of index.css).

It'll make walls of text harder to read of course, because it goes against all typography principles, but people tend to think their themes should be spread across the page anyway.

Edit: PR #605
https://github.com/elkarte/Elkarte/pull/605

Re: Being nice to Spuds and Norv (just for a change).

Reply #10 – July 02, 2013, 05:28:16 am

Got board index (and child boards bitz) done. Topic "tables" (wot aren't gonna be tables) next. Will post that lot up in a few hours.

Re: Being nice to Spuds and Norv (just for a change).

Reply #11 – July 02, 2013, 09:48:18 am

Ok, table-less board index, message index, and unread stuffz pages. Yippee!

Teh zip: http://www.elkarte.net/index.php?action=dlattach;topic=468.0;attach=263

If this one goes in straight after the template tweaks one, it should all be good.

Edit: PR #605
https://github.com/elkarte/Elkarte/pull/605

Re: Being nice to Spuds and Norv (just for a change).

Reply #12 – July 02, 2013, 11:30:18 am

yes sir, PR is on the road: https://github.com/elkarte/Elkarte/pull/605

Re: Being nice to Spuds and Norv (just for a change).

Reply #13 – July 03, 2013, 07:44:23 pm

http://www.elkarte.net/index.php?action=dlattach;topic=468.0;attach=276

Easy one. Just a fix for Issue #573, and some minor cleaning up of editor css (fixed missing left group border, got rid of some crud, better active button highlighting for wysiwyg mode).

-edit PR #609

Re: Being nice to Spuds and Norv (just for a change).

Reply #14 – July 04, 2013, 03:27:37 am

Ok, better throw this one in too: http://www.elkarte.net/index.php?action=dlattach;topic=468.0;attach=277

Readme says it all.

Edit by TE: https://github.com/elkarte/Elkarte/pull/614