ElkArte Community

Elk Development => Bug Reports => Topic started by: ahrasis on December 20, 2014, 03:54:12 am

Title: Mention From The Same Topic
Post by: ahrasis on December 20, 2014, 03:54:12 am
This one is quite obvious I think. Like just now, I read 3 mentions. 2 likes and one mention in the same post / topic. I realized that while I have opened the said post / topic, the 3 mentions didn't turn off. Even if I follow one of the mentions (by clicking it), it won't immediately remove the followed mention until refresh. The other two will remain after refresh until I either follow them or mark them as read.

Can it be given some sort of enhancement so that, it will be removed if respective topic is opened via its link or otherwise? If it is not so much trouble, that is.
Title: Re: Mention From The Same Topic
Post by: emanuele on December 20, 2014, 04:38:11 am
It should already. (Unless it's buggy.)

Can you mention me and like this message?
And then someone else can like this message?
Title: Re: Mention From The Same Topic
Post by: ahrasis on December 20, 2014, 05:54:56 am
@emanuele. Testing...
Title: Re: Mention From The Same Topic
Post by: radu81 on December 20, 2014, 06:57:18 am
another test... @emanuele and @ahrasis ;)
Title: Re: Mention From The Same Topic
Post by: emanuele on December 20, 2014, 07:41:45 am
Looks good here, see the sequence before => after => end.
Title: Re: Mention From The Same Topic
Post by: meetdilip on December 20, 2014, 08:05:41 am
@emanuele , @ahrasis , @radu81
Title: Re: Mention From The Same Topic
Post by: ahrasis on December 20, 2014, 08:29:24 am
I posted 7 images. I am using chrome version 39.0.2171.95 m. Seriously, on even the same topic, it won't remove any mention unless coming from mention page and refresh. And while posting this, I still have one more mention from this same topic.
Title: Re: Mention From The Same Topic
Post by: radu81 on December 20, 2014, 08:29:47 am
it works for me ;) thank you dilip
Title: Re: Mention From The Same Topic
Post by: emanuele on December 20, 2014, 10:10:53 am
Ohhh okay, now I understand what you mean @ahrasis.
You would like that when you are reading the topic and a mention/like/whatever passes on your screen the corresponding "alert" is marked as read. Did I get it right?
Title: Re: Mention From The Same Topic
Post by: ahrasis on December 20, 2014, 10:16:06 am
Yes.

I thought when I follow a link in mention, it should be smart enough to clear that mention upon opening a new link. And if the new link page consists of several items (like and mention) that is in the mention page, it should clear all of the relevant mention / like. Is like going more than one time to one same place.

Or at least, it clears the one we follow the link. That should be fine with me. (I do think others may want other mentions/likes not to be cleared until their links are followed).
Title: Re: Mention From The Same Topic
Post by: emanuele on December 20, 2014, 11:57:19 am
Quote from: ahrasis – Or at least, it clears the one we follow the link. That should be fine with me. (I do think others may want other mentions/likes not to be cleared until their links are followed).
This is already doing, you demonstrated it yourself with images 5, 6 and 7.

As per the general behaviour, I "copied" what other software do.
The only big difference is that all the other software have dropdowns (similar to this (http://www.elkarte.net/community/index.php?topic=1604.0)) that mark as read the notifications when the dropdown is opened.
This will likely be added to 1.1 (unless of objections)... at least I hope.

I have to investigate the possibility to mark as read all the notifications related to a single message when clicking a link, it should be possible, but I'm not entirely sure.
Title: Re: Mention From The Same Topic
Post by: ahrasis on December 20, 2014, 12:51:31 pm
3-7 only clear on refresh of current or going to other page (including back to mention). I mean it should clear the mention (the one we follow its link) upon opening its link without a need to refresh or going to other page.
Title: Re: Mention From The Same Topic
Post by: emanuele on December 20, 2014, 02:30:19 pm
I think I don't understand something.
When you click on the link in the mentions page, you are refreshing (moving to another page).
So, I'm not sure we are talking about the same thing.
Title: Re: Mention From The Same Topic
Post by: ahrasis on December 20, 2014, 10:34:21 pm
Yes. That is what I mean and supposed to be. But in my case, the mention is not counting down or reducing when the new followed page is opened. It remain the same number until I refresh that page or go to another page.
Title: Re: Mention From The Same Topic
Post by: emanuele on December 21, 2014, 04:51:19 am
And here again I don't understand the part where you say you have to refresh or follow another page.

I mean, to open a page, you have to go to another page, I don't understand that point, sorry, I'm a bit slow certain times...
Can you describe it really step by step what you mean? Like you were talking to someone that don't know anything about what you are talking.
... wait, you are not talking about the listing of mentions, but you are talking about the number of mentions in the menu popup that is delayed by 1 page?
Ooookay! now I got it. You see, it takes quite a while from time to time until I get what someone else wants to tell me... :-[
Next time, I'd suggest to make some circles in the pictures, to highlight what you are looking at, because we were really looking at two different things, sorry the misunderstanding. :-[

The only way is to change the "mark read when you click" to a redirectexit, because the number is added to the menu before the mention is marked as read and the counter decreased.
Another option, but that would be for 1.1 or even 2.0, is to create a way to show all these bits (and maybe other things as well) via AJAX calls only after the main page has been loaded, something to consider.
Title: Re: Mention From The Same Topic
Post by: Spuds on December 21, 2014, 08:19:36 am
What I see it doing is this:

- I have a new mention, I see a [1] count over the mention tab
- I click on mentions, I see my new mention in the list, its a like in this example
- I click on the mention title from the list, I am taken to the post that was liked
- The mention counter still shows a [1] count on this new page
- If I refresh the page only then does the counter go away (or if I click on mentions again of course its gone)
Title: Re: Mention From The Same Topic
Post by: emanuele on July 19, 2015, 12:06:40 pm
I think the only "clean" way to fix that would be to redirectexit to the message url.
Title: Re: Mention From The Same Topic
Post by: radu81 on July 19, 2015, 05:26:05 pm
Think if you have 2 or more likes for the same post ;)

You will still see the notification ;)