Since release of 1.0.2 is coming closer (originally I set it to December the 1st, but since the date is almost arrived I postponed it to December the 8th), I'd like to have a reminder of all the things still pending for it (I don't mean bug reports, for those there is the bug tracker :P).
One important thing is that the way avatars work changed quite a bit, and it requires to run some code during the update.
Unfortunately there is no good way to "port" the old settings, so the settings will be the "default" and we will have to tell admins to check their avatar settings.
This code is still not written. I'll try to have a look (since I did the "mess" :P).
The file version have to be updated.
The patch has to be packed. Once file versions are updated I can run again the script to auto-generate the patch.
Implement the gallery. :P ;)
Give me a day of 48 hours! :P :P
Getting excited for 1.02 ;D ;D Lots of goodness in there !
Oh well, working on something else I ended up updating the file versions... xD
And I merged it :P
Anything special planned for 1.0.2 ?
This is the current list of updates https://github.com/elkarte/Elkarte/compare/master...patch_1-0-2 somewhere around 100 commits since 1.0.1
Since its point release its intended to fix reported bugs, both functional and layout. There was one area where security was tightened around the db backup tool.
In terms of "new", not to much since its a x.x.X release. There were a few additional hooks added to help with addon writing, as authors report areas where we can help with additional hooks. The split quote function which was only keyboard activated was added to the toolbar to make it more prominent, and the confusing plethora of avatar permissions was cleaned up.
I think thats the general scope at this time (and the site here is running most of that 1.0.2 code as wel)
I noticed the 100 commits as well and thought that maybe this time we went a bit too far with for a micro. LOL
Lol, and there are still two bugs which needs to be fixed (Sorry, haven't reported until now):
1) the drop_area breaks the layout on mobile devices (how to reproduce: just create a new post with a low screen device)
2) the new Avatar handling is great, but on mobile devices the size needs to be reduced (Display template).
Does it even make sense to have the drop zone there for phones? Should that just be reduced to the click to add function?
@media avatar the selector can/may be changed to:
.avatar, .avatar.avatarresize {that should cover past and current situations (I hope).
Drop area... I didn't even know it was breaking the layout. :P
I was looking for the broken layout of the drop area, but I'm not exactly sure what I should look at...
I can't see anything really broken, I see that the area inherits the "!important" settings of the dl's (80% wide one aligned left, one right). Is it that that you mean with broken?
I'd also say change the 3 column additional check boxes and make that two (set width to 50%), that will stop those from wrapping (well limit it). Past that it seemed like what you said, plus loose the padding, make it go full width for those 360 screens (IMO).
I'd do some work on that but its brewing day ... Chocolate milk stout and a Belgian triple, have to get done before the revenuers find me ;D
You slacker!! :P
It seems you know what to do, I'll leave that to you or TE, I'll put together modification.xml. ;)
This evening I started preparing the modifications.xml, though this time there is a small problem.
One of the changes require to remove a chunk of code that contains some javascript (ManageAttachments.template.php, the first function), and this javascript is included in CDATA stuff.
Of course the CDATA conflicts with the CDATA of the xml and it fails...
I have not investigated yet very deeply the situation, a couple of options that come to my mind are:
1) to split the operations so that the CDATA and the closing ]]> are split across multiple operations,
2) one operation to "break" the CDATA and another one to replace everything in one go.
Both may be a little weak in regards to the reverting the patch.
Well, now it's time to go sleep. ;D
"know what to do" ... me ... sweet, I may have to add that to my sig :P
I'll take a look in the AM, to tired from my day of brewing ... but at least I have the Triple bottled and the Stout in the primary fermenter :D
Ouu, add gravatar :p
Go to your profile and add it by yourself. :P
I put an updated css on the site with the various media tweaks, lets see how that works before I make the PR O:-)
the main issue seems to be the margin / padding from
drop_area_fileselect.Anyone remember why it was added at some point?
width: 220px;
padding-left: 220px;
Oh, it already exists? Well, epic fail Mst. XD
If I recall that was when we consolidated the select box and D&D area to that single element. To move the browse button outside the file select box, which is hidden behind the "or selecting them" (turn off the opacity and you will see what I mean).
So the problem seems to appear when that text is split across two lines, at least in a test if I get selecting on one line and them on the other, the actual hidden file selector is with the them. Maybe just changing that space to   would work there ... unless there is another problem I'm not seeing
It existed for about 20 months. :P
So that text has a class associated with it, so
.drop_area_fileselect_text {
white-space: nowrap;
}should have it always be on a single line (like the control that is behind it).
That px is a bit fragile since its set to be about the length of "selecting them" You could use em but that has the same frailty when the text string is translated. Not sure there is a way to set that other than get the length of the drop_area_fileselect_text and then update the control to match?
I added the nowrap css to the site to see if that helps, it did on my emulator but thats an emulator :P
Hmm, now that I think of it, I remember using a gravatar on the test forum I made using EA :P
Added two screenshots, the problem is the scrollbar... removing some classes seem to fix it, however I'm not sure if that breaks something else..
Edit: PR sent ->https://github.com/elkarte/Elkarte/pull/1897
interesting ! ... off the top of my head it would just be ie8 (no opacity) that will get messed up by that.
I'll take a look at that under ie8 later today (have to remove the other things I did like the two column other options and padding tweaks that are on this site as well) unless someone has that handy.
Fortunately we already disable ie8 from D&D so you just get the old select box, forgot we had put the FormData && onprogres checks in place :D I did force it to work under ie8 and as expected it looks bad, but it does not matter ! I'll check some moar browsers now.
Now I've checked under some other desktop browsers, the problem is the "hidden" by opacity file select input box is no longer behind the text that says "or selecting yhem"
Clicking on "selecting them" does nothing but cause a page jump (since is an href #). The input file control is somewhere to the right or under that line of text not over it.
The original idea was the hidden file select control was over the text but since its transparent, all you see if the text (what github does). So when you click you are really clicking on the file input, not the link.
I still don't know if there is any use to the D&D area for a phone, so the easiest may be to simply due what we do with ie8 (and ie9) and thats not enable D&D which results in the old fallback of a standard file input. Granted that looks old fashioned, so maybe there is still something that will prevent that scrollbar yet.
And one more post in my line here:
The left padding was added here: https://github.com/eurich/Elkarte/commit/5a8faa7a4ccaba50d64755e1a3679de4e4c8dea2
Although it seems to work without that, chrome does not change the cursor pointer when you are over the text. Could add that just for chrome browsers and I think removing that stops the broken layout (the control size can be reduced a bit, seems generously sized now as well. So maybe the following will work.
.drop_area_fileselect {
cursor: pointer;
margin-left: -160px;
opacity: 0.0001;
position: absolute;
width: 160px;
}
#chrome .drop_area_fileselect, #safari .drop_area_fileselect {
padding-left: 160px;
}
.drop_area_fileselect_text {
white-space: nowrap;
}You need the nowrap on the text, one phone I tested was 320 wide and that caused "selecting them" to be on two lines, but the control was on "them" so pressing "selecting" was the link not the control (I hope that makes sense).
updated the PR with some changes (hiding the D&D box for low-res devices) .. I doubt D&D will work on mobile devices at all (never tested myself)..
Nope, doesn't work.
I think the way to handle that is going to have to be with JS since that is what is showing / hiding those areas. Specifically JS will show the .drop_area and hide the .drop_attachments_no_js area based on capability not practicality.
So my thought is to add
// Don't attach D&D on small screens
if (!window.matchMedia || window.matchMedia('(max-width: 33.750em)').matches)
return;
in the dropAttachments js, that will stop the DD function from ever attaching / activating when we are below 540 (or pick your number, that was just a random pick) screen width
Whats cool about matchMedia is we could even attach a listener to it so its screen size change aware :D
Code-wise I think it's settled.
I started the tracking issue for the release:
https://github.com/elkarte/Elkarte/issues/1905
ETA: I started packing the stuff.
Attached to this message there is both an install and a patch, if you can, please give them a try, because I recently had some issues while creating zip files... :-\
ETA2: packages removed.
I tried the patch package and get this error:
./sources/CurlFetchWebdata.class.php
Search for:
* copyright: 2011 Simple Machines (http://www.simplemachines.org)
* license: BSD, See included LICENSE.TXT for terms and conditions.
*
* @version 1.0
*
*/
Replace with:
* copyright: 2011 Simple Machines (http://www.simplemachines.org)
* license: BSD, See included LICENSE.TXT for terms and conditions.
*
* @version 1.0.2
*
*/
./sources/subs/Action.class.php
Search for:
* copyright: 2011 Simple Machines (http://www.simplemachines.org)
* license: BSD, See included LICENSE.TXT for terms and conditions.
*
* @version 1.0
*
*/
Replace with:
* copyright: 2011 Simple Machines (http://www.simplemachines.org)
* license: BSD, See included LICENSE.TXT for terms and conditions.
*
* @version 1.0.2
*
*/
./themes/default/index.template.php
Search for:
* copyright: 2011 Simple Machines (http://www.simplemachines.org)
* license: BSD, See included LICENSE.TXT for terms and conditions.
*
* @version 1.0.1
*
*/
Replace with:
* copyright: 2011 Simple Machines (http://www.simplemachines.org)
* license: BSD, See included LICENSE.TXT for terms and conditions.
*
* @version 1.0.2
*
*/
Plus some more errors in my theme. :o
Oh, and in index_light.css you have this:
/* The active one */
.buttonlist li a.active {
box-shadow: 1px 1px 2px #ccc;
box-shadow: 1px 1px 2px #e5e5e5, 0 -1px 0 #3d6e32 inset;
}
Isn't this a duplicated row?
ARG!
Darn copy&paste as usual! >:(
Thanks for testing!
https://github.com/elkarte/Elkarte/pull/1909
About the css, I don't know... it looks.
Found two other things and made the PR
looks like BoardIndex was still at 1.0 in the 1.0.1 patch, and one line needed to be space space tab and not tab tab ..... bleh!
Installed it on a "pure" 1.0.1 and it installed fine ... will test on a 1.0.1 that was a patched version in a bit.
ETA: seemed to go fine on an upgraded to 1.0.1 site as well
I'll generate the new packages today.
Oh, I just noticed:
https://github.com/ichord/At.js/commit/e1f65668e311c06d845164c49f303fdb6093cca6
what do you think? Worth a "last-minute" sneak in? O:-)
Looks like a safe change, you will have to back port it since we are not on the same rev at this point but I don't think that area has changed from our rev to the current one.
Reading it again I think it's better wait on that one.
There are too many places where the darn version requires to be updated for a release. >:(
Maybe Sunday is a good day for releasing?
/me hopes so. :P
Why not release it on new years? New year, new version. ;)
The advantage to release it before Christmas is that people could have more free time to test it and report the eventually bugs. Imo...
It's "ready", the more we wait, the more stuff goes in there and a bit more time it requires (to adjust things and in case fix regressions), so better send it out "ASAP" and move back to coding 1.1... also I would like not to do a release during holidays, I may be drunk. :P
Oook.
Attached the hopefully final version of the patch.
It should work, but another pair of eyes looking at it is not a bad thing.
It already includes https://github.com/elkarte/Elkarte/pull/1920
Ye old quick test,
I installed it on two site that had the previous 1.0.2 test, the uninstall of the old and install of the new package ran fine.
Good! :D
I'll try to finish up the release today unless something else if found. O:-)
My test went well. Currently running 1.0.2 in my test "subforum" sites. All subforums are working fine too. ;)
Hopefully nothing is badly broken. :P
Just one question: is this update the same as that published officialy on github? I am asking this because I install this patch today on my test forum, and if the patch is not the same I should update it.
It's not exactly 100% the same, I spotted a small mistake while uploading it and so I had to fix it.
It's nothing too important, in fact it's just a notice that you have updated and there are some noteworthy changes. In other words something you can live without, if you want to read it you can just go to the admin panel in support and credits and see the list of things. ;)