ElkArte Community

Project Support => Support => Topic started by: stanstrup on May 14, 2016, 04:31:07 pm

Title: All "Extract Tree" operations get "Modification parse error"
Post by: stanstrup on May 14, 2016, 04:31:07 pm
I previously managed to install a couple of addons but when I tried to install the "Solve Topics" one I got "Modification parse error" for every "Extract Tree" operation.

It seems this should normally be a permission issue but all folders are 777.
I then tried to uninstall some of the packages I already had and now they have the same problems!  :'(

What can be the cause of this?
Title: Re: All "Extract Tree" operations get "Modification parse error"
Post by: emanuele on May 14, 2016, 04:47:19 pm
At the bottom of the page, there should be a box telling you to insert ftp data, in the message there should be a "if you want to know the files having problems, click here", can you have a look if there is any hint?
Title: Re: All "Extract Tree" operations get "Modification parse error"
Post by: stanstrup on May 14, 2016, 04:55:29 pm
I have gotten these messages before that allowed me to fix permissions manually but now I don't see any.
Title: Re: All "Extract Tree" operations get "Modification parse error"
Post by: emanuele on May 14, 2016, 06:04:41 pm
Oh... I thought the problem was another one, but looking at the code, I feel it's a small bug. O:-)

I just proposed the fix (https://github.com/Spuds/Elk-Solved-Topics/pull/2).
Title: Re: All "Extract Tree" operations get "Modification parse error"
Post by: stanstrup on May 14, 2016, 06:20:26 pm
Thanks. The screenshot was for simpleportal, though, if that was not clear.

I tried the solve mod again and your fix solved it for "./sources/controllers/SolveTopic.controller.php"
But I still get errors for:
./sources/admin/ManageSolveTopic.controller.php
./sources/subs/SolveTopic.subs.php
./themes/default/SolveTopic.template.php
Title: Re: All "Extract Tree" operations get "Modification parse error"
Post by: Flavio93Zena on May 14, 2016, 09:57:38 pm
Quote from: emanuele – Oh... I thought the problem was another one, but looking at the code, I feel it's a small bug. O:-)

I just proposed the fix (https://github.com/Spuds/Elk-Solved-Topics/pull/2).
/me looks at the code, and sees the uninstall part has the old code, asks himself if it's right or not, thinking it's not :-X
Title: Re: All "Extract Tree" operations get "Modification parse error"
Post by: ahrasis on May 15, 2016, 06:44:56 am
Strange, I think I remember I haven't got that problem during my update and I was using the 1.0.7 patch. Or may be, my mind is just playing the trick. :P

But to OP, thank you for using FaceIt. Feel free to suggest any changes to that theme. :D
Title: Re: All "Extract Tree" operations get "Modification parse error"
Post by: stanstrup on May 15, 2016, 08:03:09 am
This happened with v 1.0.6 too. I only updated in hopes that it would solve this...
Title: Re: All "Extract Tree" operations get "Modification parse error"
Post by: emanuele on May 16, 2016, 03:13:50 am
You should update irrespective of bugs you may find. You should update because it's the thing to do (usually each and every update has several bug fixes and maybe improvements, for the moment only one or two security-related issues, but still is good habit to update any time a new patch comes out).

The but is in the addon, delete the one you have on the server and download it again, it should be fixed now. ;)
Title: Re: All "Extract Tree" operations get "Modification parse error"
Post by: stanstrup on May 16, 2016, 04:54:37 am
Unfortunately that didn't solve the problem for me.

(Link-3691)
Title: Re: All "Extract Tree" operations get "Modification parse error"
Post by: emanuele on May 16, 2016, 05:47:45 am
Sorry, I was probably dreaming when I proposed the fix... :-[

I have to dig more into it.
Title: Re: All "Extract Tree" operations get "Modification parse error"
Post by: stanstrup on May 19, 2016, 07:45:21 am
Hi again,

I know you are doing this work for free so this is not to be pushy, but do you have an guesstimate of when I could hope for this to be figured out?
Title: Re: All "Extract Tree" operations get "Modification parse error"
Post by: emanuele on May 19, 2016, 08:09:25 am
More than time, in this specific case, it's the fact I hate the package manager code from the bottom of my heart[1][2] and I have to be in a very good mood to take a look at it (and these last two days I had few things in RL that needed some attention).

I'll try to check today or tomorrow[3], if you don't hear anything before the weekend feel free to nudge again. :)
That's the reason I'm trying to find any possible way to change how addons work in order not to have to rely on that code. :P
And the meaning of "hate" in this sentence includes the fact I barely understand that piece of code, and follow it's intricacies is a darn pain.
Unless someone beats me. O:-) <= looks like smiley do not work in footnotes...
Title: Re: All "Extract Tree" operations get "Modification parse error"
Post by: live627 on May 19, 2016, 08:42:04 pm
Can you try https://github.com/Spuds/Elk-Solved-Topics/archive/0bb07e9db853bc529b30ac4355d55cae14e39883.zip
Title: Re: All "Extract Tree" operations get "Modification parse error"
Post by: stanstrup on May 21, 2016, 06:37:54 am
Sorry. Same errors for:
./sources/controllers/SolveTopic.controller.php
./sources/admin/ManageSolveTopic.controller.php
./sources/subs/SolveTopic.subs.php
./themes/default/SolveTopic.template.php
Title: Re: All "Extract Tree" operations get "Modification parse error"
Post by: live627 on May 21, 2016, 05:51:51 pm
Is it double-foldered? It spews out tons of errors unless package-info.xml is in the root.

I did that in the attached package. All files copied with no errors.
Title: Re: All "Extract Tree" operations get "Modification parse error"
Post by: stanstrup on May 21, 2016, 06:02:25 pm
What do you mean by double foldered? I tried the attached zip with same result as before.
Title: Re: All "Extract Tree" operations get "Modification parse error"
Post by: ahrasis on May 21, 2016, 09:24:24 pm
That is strange. Somehow your files have been changed. I guess you'd better try to overwrite with full installation files then.
Title: Re: All "Extract Tree" operations get "Modification parse error"
Post by: emanuele on May 22, 2016, 08:10:48 am
@live627 double folding should not be an issue, it should work as well.

It's the "usual" problem with the temp directory in packages that is not created properly.
First of all, get rid of the latest version with my fix. Just delete it.
Download the file from:
Quote from: live627 – Can you try https://github.com/Spuds/Elk-Solved-Topics/archive/0bb07e9db853bc529b30ac4355d55cae14e39883.zip
then, via ftp, go to your forum directory, then in "packages" and there, create a directory named "temp". If you want you can give it permissions 777, but it should not be necessary.

Go back to admin panel and repeat the install.
Title: Re: All "Extract Tree" operations get "Modification parse error"
Post by: stanstrup on May 22, 2016, 08:59:56 am
Yeah! I am not sure what fixed it... It all seems very strange. I followed your instruction (I was aware of the temp folder issue and that was never the issue). Didn't work.
I then copied over the forum software overwriting my files. Still no good.

Then I did a browser refresh on the packages page and tried the installation again. Now everything worked.
Isn't that mighty strange?


Whatever made this work thanks a lot for looking into this.
Title: Re: All "Extract Tree" operations get "Modification parse error"
Post by: live627 on May 22, 2016, 10:43:11 am
Quote@live627 double folding should not be an issue, it should work as well.
Even in  Elk 1.1?
Title: Re: All "Extract Tree" operations get "Modification parse error"
Post by: emanuele on May 22, 2016, 01:24:40 pm
As far as I know, yes.
If it doesn't then it's a bug... and Spuds' fault. :P
Title: Re: All "Extract Tree" operations get "Modification parse error"
Post by: live627 on May 22, 2016, 04:35:56 pm
Says the self-proclaimed bug creator :P

Yeah, this mods package errors out with double folding.
Title: Re: All "Extract Tree" operations get "Modification parse error"
Post by: emanuele on May 22, 2016, 05:21:35 pm
/me is innocent O:-)
Title: Re: All "Extract Tree" operations get "Modification parse error"
Post by: meetdilip on May 23, 2016, 05:19:36 am

Always.. :P
Title: Re: All "Extract Tree" operations get "Modification parse error"
Post by: Spuds on May 23, 2016, 09:54:06 am
It well may be my fault ! But this bug is above my pay grade  ;D
Title: Re: All "Extract Tree" operations get "Modification parse error"
Post by: live627 on May 24, 2016, 06:29:58 am
Not above mine, so... time to file through a mess,  then.

/me just realised that the /me icon is a peace sign
Title: Re: All "Extract Tree" operations get "Modification parse error"
Post by: Spuds on May 24, 2016, 05:38:05 pm
 8)  Hope you are able to find something, pacman can be a difficult little beast at times.