ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: gevv on December 19, 2016, 01:51:08 pm

Title: It does not appear RAR file icon
Post by: gevv on December 19, 2016, 01:51:08 pm
hi, 

mini bug  upload rar file  no file icon (There may be problems within different file extensions)


It may be better to use the generic icon set for all extensions
Title: Re: It does not appear RAR file icon
Post by: Spuds on December 19, 2016, 05:35:18 pm
I think I fixed that in the last couple of weeks ... it should show the default mime icon when it does not have one for a given file extension.   

What I'm thinking of doing before rc1  is adding defaults "per type" vs a single generic default.  So compressed files, e.g. rar, 7z etc get a generic compressed icon.  Same for music files wav, mp3, wma etc get the music note icon, etc etc  This expands the support without adding in a bunch of files.



Title: Re: It does not appear RAR file icon
Post by: Spuds on December 21, 2016, 03:23:02 pm
This time I did fix it :P

https://github.com/Spuds/Elkarte/commit/e9b4e59beb9275a7739d9b45eaf70df39ecd78ea
and
https://github.com/Spuds/Elkarte/commit/5c0d0ade276084f611737b717ea1f4d72fe7f54a