ElkArte Community

Elk Development => Feature Discussion => Topic started by: wintstar on August 28, 2015, 01:50:29 am

Title: agreement.txt
Post by: wintstar on August 28, 2015, 01:50:29 am
I have 2 ideas for this text file. Since this text file is accessible via a URL, it should be moved or removed.
Look here (http://forum-alternative-antriebe.de/agreement.txt), or here. (http://www.elkarte.net/community/agreement.txt)
It could also lead to a security problem.

1. Move
Insert this text file in the respective language folder.

2. Remove
Remove and store in the database. Since there are an ID for each language installed, it would be possible to retrieve from the database in various languages.

 
Title: Re: agreement.txt
Post by: Flavio93Zena on August 28, 2015, 09:35:01 pm
I'd say move it (no queries for something that is loaded a billion times by bots), but I can't see how someone could edit it with proper CHMOD :P
Title: Re: agreement.txt
Post by: Joshua Dickerson on August 28, 2015, 10:07:37 pm
It's not a security issue at all.
Title: Re: agreement.txt
Post by: emanuele on August 29, 2015, 01:14:18 am
Any language folder is (unless you add specific server-side restrictions) accessible directly by URL, so it's nothing different.
It's a "txt" file, so unless you attached the php-handler to txt files as well, it should not run anything on the server, just show the text, so not really a security issue. ;)

That said, I never saw the point of having it outside the language directory, so I'd favour the moving of the file to the languages directory. nods
Title: Re: agreement.txt
Post by: Flavio93Zena on August 29, 2015, 02:04:04 am
/me feels cool coz emanuele said the same thing he said :D
Title: Re: agreement.txt
Post by: Flavio93Zena on August 29, 2015, 06:28:15 am
/me feels derived didn't understand anything of the topic O:-)
Title: Re: agreement.txt
Post by: wintstar on August 29, 2015, 11:02:11 am
I put on github an issue https://github.com/elkarte/Elkarte/issues/2196, for point 1. Move in the respective language folder.