ElkArte Community

Project Support => Support => Topic started by: Zioclive on November 24, 2020, 05:04:29 am

Title: Attachment Repair
Post by: Zioclive on November 24, 2020, 05:04:29 am
Hy everyone, I'm using Elk 1.1.6 .

I've noticed that the feature "repair attachment" in "Administration > Panel dose not work in my case.

After checking and repairing the errors are still found  by Elkarte ( and probably still there).

Any suggestion ?

Thanks  :)

(Link-6811)
Title: Re: Attachment Repair
Post by: emanuele on November 24, 2020, 04:45:56 pm
hmm... could you check the log to see if any error is reported that could be linked to that?
Title: Re: Attachment Repair
Post by: Zioclive on November 25, 2020, 04:26:50 pm
Thanks Emanulele, looking the log errors I find a lot of this kind of errors

(Link-6813)

Code: [Select]
	
// The only special case is 'html', which doesn't need to close things.
285:
if ($tag[Codes::ATTR_BLOCK_LEVEL] && $tag[Codes::ATTR_TAG] !== 'html' && !$this->inside_tag[Codes::ATTR_BLOCK_LEVEL])
286:
{
287:
$this->closeNonBlockLevel();

Actually I'm using php 7.4.13 

This version has been automatically set by my  provider  "One" ... >:(
When elkarte was insalled in 2018  I did the choice of   php version 7.2 .

Now I changed from 7.4 to 7.3 lets see if it can be of any differenze  :)
Title: Re: Attachment Repair
Post by: Zioclive on November 26, 2020, 02:12:24 pm
Update: changing from php 7.4 to 7.3  the errors at line 285 have stopped.

Unfortunately nothing has changed in fixing the attachments errors
Title: Re: Attachment Repair
Post by: ahrasis on November 26, 2020, 11:36:49 pm
I am afraid that ElkArte is currently only suitable up to php7.2. I haven't tested this thorougly with php7.3 to php8.0 but there are reports of bugs for php7.3 and php7.4 already.
Title: Re: Attachment Repair
Post by: Zioclive on November 28, 2020, 03:40:48 am
https://www.php.net/supported-versions.php

seems php  7.2's security  support will end on 30 November 2020, so I'll keep my forum on php 7.3 until I can.

Unfortunately my provider www.One.com  "simply" removes a php version from being available  "for security reasons"   :-X  as soon as the security supports ends.
Title: Re: Attachment Repair
Post by: ahrasis on November 28, 2020, 05:07:46 am
We noted that already. Actually it is best to report for bugs in the github. Until it is fixed, nothing much can be done.
Title: Re: Attachment Repair
Post by: Zioclive on November 28, 2020, 01:59:18 pm
Anyway I have all the time I need for changing my actual internet provider    to another one less... how can I say...  less uncompromising  ;) .
Title: Re: Attachment Repair
Post by: Spuds on December 12, 2020, 04:28:13 pm
I have this fixed on my local, twas a bug! ... There are two line to change ...

https://github.com/Spuds/Elkarte/commit/4b52dcc129b45318c16bb96e06ec0dff3e5724c8
Title: Re: Attachment Repair
Post by: Zioclive on December 28, 2020, 12:02:41 pm
Thank you !!!!  :D