Skip to main content
Topic: Non-existing groups not showing any error (Read 2217 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Non-existing groups not showing any error

If you manually point the browser to let's say: http://www.elkarte.net/community/index.php?action=groups;sa=members;group=123456789 it doesn't throw an error telling you that it doesn't exist (I don't really think you got THAT many groups ;D), it just shows an empty group page, saying that the group is empty, when in fact it doesn't exist at all.
I consider this a bug because the proper response should be this: http://www.elkarte.net/community/index.php?action=groups;sa=members;group=10 which is very much likely a deleted membergroup, so I can think it works with deleted membergroups but not with yet-to-be-created ones...?

P.S.: LOLLED hard when I saw this --> http://www.elkarte.net/community/index.php?action=groups;sa=members;group=9 ;D ;D ;D
P.P.S.: I know I am a cursed glitcher, that's why I am here for :P
~ SimplePortal Support Team ~

Re: Non-existing groups not showing any error

Reply #1

 Burke Knight wonders why someone would enter a group number that long, into their browser URL field, in the first place. :P

Re: Non-existing groups not showing any error

Reply #2

'Coz
Quote from: Flavio93Zena – I am a cursed glitcher, that's why I am here for :P

Besides I wanted to be ironic :P I was trying to figure out which membergroups are present and found out about this thing :)
~ SimplePortal Support Team ~

Re: Non-existing groups not showing any error

Reply #3

@emanuele @Spuds pls no miss me ;D
~ SimplePortal Support Team ~

Re: Non-existing groups not showing any error

Reply #4

Seems like it should show the non existent group screen for invalid numbers.

Also not sure it should show those screens at all unless you have permissions, probably keyed of member view permission, but not sure it should show unless you have some form of group alter permissions :/

Re: Non-existing groups not showing any error

Reply #5

IMHO the smf default behavior is the most appropriate one, it throws error when the group doesn't exist/has been deleted and shows empty group when the group is really empty.
Not sure how you refactored the code to handle that action but something went in an unexpected way for sure :P As for the "what"... No idea.
~ SimplePortal Support Team ~

 

Re: Non-existing groups not showing any error

Reply #6

Tracked: https://github.com/elkarte/Elkarte/issues/2115

And fixed (see github).
Last Edit: July 18, 2015, 04:04:22 am by emanuele
Bugs creator.
Features destroyer.
Template killer.