ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: Auctor Lucan on April 01, 2017, 10:53:04 am

Title: News Fader Error
Post by: Auctor Lucan on April 01, 2017, 10:53:04 am
Another problem I am having, heh heh. I have come to frequent this forum because of the outstanding help I have gotten so far.

Check the image. No matter what delay I put into the news fader's delay on top of the page, it remains at 6 seconds. I tried three times as much, and still no change. Do you think it can be hard-coded into like 10 seconds since the user interface to change the time isn't working for me?

Problem is that I have no idea where I should look for this bug, whether it is theme-related or something. Any directions and help would be awesome, and it would be great if this could simply start working instead of putting it into 10 seconds permanently.

Best,

Auctor Lucan
Title: Re: News Fader Error
Post by: emanuele on April 01, 2017, 02:45:39 pm
/me feels like "someone" (hint <=) forgot to add the time as parameter of the newsfader initialization call

Code: [Select]
$(\'#elkFadeScroller\').Elk_NewsFader();', true);
should be something like:
Code: [Select]
$(\'#elkFadeScroller\').Elk_NewsFader(' . (empty($settings['newsfader_time']) ? '' : '{\'iFadeDelay\': ' . $settings['newsfader_time'] . '}') . ');', true);
Title: Re: News Fader Error
Post by: Auctor Lucan on April 01, 2017, 02:53:24 pm
Ah, awesome! Which file is it though?
Title: Re: News Fader Error
Post by: Adrek on April 01, 2017, 04:26:52 pm
@Auctor Lucan ./themes/default/index.template.php or ./themes/YOUR_THEME/index.template.php
Title: Re: News Fader Error
Post by: Spuds on April 01, 2017, 06:15:45 pm
I may be that certain someone  ;D
Title: Re: News Fader Error
Post by: emanuele on April 02, 2017, 01:07:58 pm
Actually, I was thinking it was me that didn't write it there... who knows. :P
Title: Re: News Fader Error
Post by: emanuele on April 02, 2017, 05:38:00 pm
https://github.com/elkarte/Elkarte/pull/2898/commits/3178978168fd4739672e80af8df6b8b77c12bf92
Title: Re: News Fader Error
Post by: Auctor Lucan on April 02, 2017, 07:00:45 pm
Thanks for the help with this!