Skip to main content
Topic: Send out Newsletter failed (Read 8955 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Re: Send out Newsletter failed

Reply #15

Try the one attached.
Replace the one in sources/admin/

ETA: also, secondary groups are not considered at all... should they?

ETA2: attachment removed
Last Edit: December 16, 2013, 02:53:52 pm by emanuele
Bugs creator.
Features destroyer.
Template killer.

Re: Send out Newsletter failed

Reply #16

Quote from: emanuele – Try the one attached.
Replace the one in sources/admin/
Sourcefile can not be read. Tried 5 times. 5 minutes later i get it.

Quote from: emanuele – ETA: also, secondary groups are not considered at all... should they?
Brood...for my logical understanding, yes. Otherwise for me it is very irritating.

Edit:
Unfortunately, the attached file does not work. Same as before.
Last Edit: December 16, 2013, 01:21:37 pm by NetFlag

Re: Send out Newsletter failed

Reply #17

Can you check the error log to see if there is anything there that could be related?
Bugs creator.
Features destroyer.
Template killer.

Re: Send out Newsletter failed

Reply #18

Nothing in there. Strange....

Can someone else reproduce this?

Re: Send out Newsletter failed

Reply #19

Quote from: NetFlag –
Quote from: emanuele –
Quote from: emanuele – ETA: also, secondary groups are not considered at all... should they?
Brood...for my logical understanding, yes. Otherwise for me it is very irritating.
Never mind, I was looking at the wrong line... sorry.
Additional groups are included.

Can you try for debugging the one attached?
When the process is finished it will show you a message with a code block, can you copy and paste the content of the block here?

Re: Send out Newsletter failed

Reply #20

QuoteSourcefile can not be read. Tried 5 times. 5 minutes later i get it.

Sorry for all the downloads on that file, that was me testing to find out why it was doing that ... Figured it out  :)

Re: Send out Newsletter failed

Reply #21

Quote from: emanuele – Can you try for debugging the one attached?
When the process is finished it will show you a message with a code block, can you copy and paste the content of the block here?
Members to include see attachment. (3 Members)

This is the result:
Code: [Select]
members_collected: 1
members_sent: 1

completed



Re: Send out Newsletter failed

Reply #22

Found it!!
It was a bug introduced last summer in SMF [1], these two changes should fix it:
https://github.com/emanuele45/Dialogo/commit/304e22dd368c6386428c1b65583a4da593a32215

now the ethical question: I've been suggested to "mind my own business", should I report this bug or not?...I think I'm too stupid not to point them at the fix...
Bugs creator.
Features destroyer.
Template killer.

Re: Send out Newsletter failed

Reply #23

Sorry, no success message.  :( 
Groups to receive: Newsletter (2 Member)
Only one receive the mail.

Groups to receive: Newbie (3 Member in)
Only two of them receive the mail.

Groups to receive: All checked (3 Member overall)
Only two receive the mail.

Big thanks for your tireless assignment!!

Re: Send out Newsletter failed

Reply #24

I found some other bugs around and a mostly duplicated function, now is a bit late, I'll try to fix everything tomorrow... :(
Bugs creator.
Features destroyer.
Template killer.

 

Re: Send out Newsletter failed

Reply #25

NetFlag, just to be 100% sure, are all the three members activated?
If you go to the member list (the public one at ?action=memberlist) do you see the three of them?

I'm asking because there was a bug that was counting non-active members too, but apart from that I can't reproduce the issue... :-\
Bugs creator.
Features destroyer.
Template killer.

Re: Send out Newsletter failed

Reply #26

All members are activated and visible in public meberlist.

New upload overall files from current available Github:
https://github.com/elkarte/Elkarte

Patch included:
https://github.com/emanuele45/Dialogo/commit/304e22dd368c6386428c1b65583a4da593a32215

Apparently I'm the only one had the problem. No one else??

Re: Send out Newsletter failed

Reply #27

Compared with SMF there is a missing variable called $normalGroups. Cant find another approach.

I have installed an test SMF too. No problems with send out newsletter.

 NetFlag php != php
ElkArtes' Code is much different to mybb. For me some difficulties to read it.

Still learning...

Re: Send out Newsletter failed

Reply #28

Okay, let's try to reproduce the thing on a similar system.
You have a clean install, right?
3 users: one admin and two in a group "newsletter"? (Is it a normal group? Something special about it in terms of settings?)
Other "special" settings? (Dunno, deny permissions on, or post-based groups permissions? Things like that.)
Bugs creator.
Features destroyer.
Template killer.

Re: Send out Newsletter failed

Reply #29

No special settings. The group "Newsletter" is additionel, inherit from "normal members".
One admin.
The other two are members in "normal menbers" and "Newsletter". The goal is to send emails only to members of group "Newsletter".
The problem, only one of them recieve.