There are some active topics with reported errors in elkarte log, I'll try to post only the ones there aren't reported, sorry if I'll report something that was already reported.
from members:
Type of error: General
Warning: filesize(): stat failed for /public/cache/data__a02fe4740023f74aa19cdfc21c227202-ELK-permissions-0,7.php
/index.php?board=3.0
File: /public/sources/subs/CacheMethod/Filebased.php
Line: 105
Type of error: Undefined
Exception: Call to undefined function hasTopicNotification()
index.php?action=notify;topic=6418.0
File: /public/sources/controllers/Notify.controller.php
Line: 68
from a guest:
Guest
Type of error: General
Warning: file_get_contents(/public/cache/data__a02fe4740023f74aa19cdfc21c227202-ELK-permissions--1.php): failed to open stream: No such file or directory
/index.php?action=dlattach;topic=4604.0;attach=37617;image
File: /public/sources/subs/CacheMethod/Filebased.php
Line: 107
from a guest:
no_session_data
Type of error: Critical
The database value you're trying to insert does not exist: group_list
Function: boardsAllowedTo
/index.php?action=dlattach;attach=1334;type=avatar
File: /public/sources/Security.php
Line: 1231
from a guest:
Type of error: Undefined
Notice: Undefined index: actual_theme_dir
index.php?action=register;sa=usernamecheck;xml;username=MauroK
File: /public/sources/Load.php
Line: 2454
from my account:
Type of error: General
Notice: A non well formed numeric value encountered
index.php?action=profile;area=statistics;u=1
File: /default/ProfileInfo.template.php
Line: 445
from a member:
Type of error: General
Warning: array_merge(): Argument #2 is not an array
/index.php?action=dlattach;topic=11490.0;attach=43454;image
File: /public/sources/subs/Cache.class.php
Line: 119
from member:
Type of error: General
Notice: Trying to get property 'expiration' of non-object
/index.php?action=dlattach;topic=11490.0;attach=43458;image
File: /public/sources/subs/CacheMethod/Filebased.php
Line: 109
snicker .... radu81 uses filebased caching ... snicker :P
Thanks for the reports, looks like
@emanuele has been busy O:-)
I've done some tests on a test vps and I was able to install and use memcached. Should I use it instead of filebased cache?
Well php7.2 already have opcache which you can use but installing and using memcached won't hurt, I think.
The OpCache is really for storing "precompiled " versions of the php scripts. Precompiling removies the need for PHP to load and parse scripts on each request.
memcached saves user "data" ... results of user and common db queries. This reducers the load on the database, maybe some other benefits buts that is basically it ... Most of that data is cached for say 30 - 120 seconds, some shorter some longer, but that is the scope of the benefit. So useful if you have a somewhat active site, otherwise probably neutral or a minor determent.
memcached is a good choice as is apcu for filling the user data purpose. Filebased can be a help, better if you are using ssd's. We could improve the filebased somewhat but I've never felt it was the best solution for standard shared or basic vps setups (thats an IMO) so I've stuck with memcached or apcu.
The last was already reported (and fixed somewhere by
@Spuds I think), the others are now tracked.
I have a fix for the last one in my repo ... now I've installed 7.2 on my local as well :'(
Another one: if I select all topics from Recycle board and then I delete them I get " Call to undefined function updateMemberData()" error. The topics are deleted from Recycle board.
Type of error: Undefined
Exception: Call to undefined function updateMemberData()
/index.php?action=quickmod;board=15.0
File: /sources/subs/Likes.subs.php
Line: 1156
Adding
require_once(SUBSDIR . '/Members.subs.php');
Just before the foreach should solve that issue.
@radu could you please open a new topic when you report a new bug? Otherwise it may be lost. :)
I thought this one was in extermineted...never mind.
@radu81 have you tried this:
If you did, do report its result. Thank you.
there is more than one foreach in Likes.subs.php, where exactly should I add that?
https://github.com/elkarte/Elkarte/pull/3188/commits/7299161dbbc9a4d9674566b83ff4a313645bbd11
Why not use Database caching ?
Wie have implemented that and it's much faster the Filecache (5x)
Speed in the oder:
APCU
MemCached
Database caching
File based caching
If you have PHP 7.2 Opcode caching and your Hoster allowed that, you can use this also as custom cache .. very fast !!
Fel
TBH, in most of the cases, anything is faster than file-based caching.
Even non-cached code (actually verified in live servers).
Anyway I don't plan to spend much time on the caching code, I'd prefer at some point to swap it for some maintained library.
Anyway:
https://addons.elkarte.net/enhancement/MySQL-cache.html
https://addons.elkarte.net/enhancement/PostgreSQL-cache.html
thanks to
@tino :D
Another list of errors using Elkarte 1.1.5 and PHP 7.2.8
I don't have a privacy policy yet, and I did not asked members to accept the policy. The GDPR part is still "inactive" on my forum
Guest
Type of error: Critical
Wrong value type sent to the database. Integer expected. (id_member)
Function: accept
index.php?action=register;sa=register2
File: sources/subs/Agreement.class.php
Line: 217
Guest
Type of error: Undefined
Notice: Undefined index: total_time_logged_in
index.php?action=dlattach;topic=11713.0;attach=53318;image
File: /public/themes/default/Theme.php
Line: 665
Guest
Type of error: Undefined
Notice: Undefined index: time_format
/index.php?action=dlattach;topic=11488.0;attach=43613;image
File: /sources/Subs.php
Line: 478
Guest
Type of error: Undefined
Notice: Undefined index: language
/index.php?action=dlattach;topic=11791.0;attach=53646;image
File: sources/subs/Exception/ElkException.class.php
Line: 168
Guest
Type of error: Undefined
Notice: Undefined index: mentions
/index.php?action=dlattach;topic=11488.0;attach=43613;image
File: /sources/subs/UserNotification.class.php
Line: 58
What type of registration do you have?
Activation by email
(https://i.imgur.com/H4cVQMq.png)
*** edit ***
I see different undefined index errors, I am wondering if it's the best way to paste them here or should I open an issue for every undefined index error on github?
Those reported here are of 2 types:
1) something at registration due to accept the agreement,
2) something in view attachments by guests
In terms of errors repprted is okay, now it's just to understand the conditions to trigger them.
In my forum guests can see the attachments, the only strange case is that I have some attachments that are reposted in other topics using the attach code. I will check if those errors are related to those attachments.
hmm... could be an attachment from a private board posted in a public one?
I don't think this one is tracked yet for 1.1.6.
The agreement part was fixed.
The attachments one... I still don't know what the problem could be.
I'm not sure how do describe the error, could you log your understanding of the problem on github O:-)