Skip to main content
Topic: loadCustomFields (Read 5952 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

loadCustomFields

At the moment we have two functions with the same name that do something similar, but not exactly the same.

loadCustomFields in Themes.subs.php (that I changed a bit in one of my commits)
loadCustomFields in Profile.subs.php

I'm tempted to say that we should try to unify the two or make their names different. What do you think?
Bugs creator.
Features destroyer.
Template killer.

Re: loadCustomFields

Reply #1

Sure seems like we could at least combine the db calls in to a single function ... then rename what remains like loadCustomFields in Profile.subs.php goes to setupCustomFieldContext or whatever (I'm not good with function names :P )

Re: loadCustomFields

Reply #2

 /me neither... :P
Bugs creator.
Features destroyer.
Template killer.