Skip to main content
Topic: [1.0 - blocker] expandIPv6 fails (Read 1867 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

[1.0 - blocker] expandIPv6 fails

Just in the error log...

expandIPv6 is not able to properly expand the following:
Code: [Select]
'::ffff:179.43.134.165'

According to for example http://www.find-ipv6.com/ipv6-expand/ the correct expansion would be:
Code: [Select]
0000:0000:0000:0000:0000:FFFF:B32B:86A5
what we obtain, instead, is:
Code: [Select]
0000:0000:0000:0000:0000:0000:ffff:179.43.134.165
so the IPv4 part is not converted to IPv6.
Bugs creator.
Features destroyer.
Template killer.

Re: [1.0 - blocker] expandIPv6 fails

Reply #1

https://github.com/elkarte/Elkarte/pull/1633

Should fix it, though I'm not entirely sure about all the combinations... :-\
I was looking for some set of IPs to do testing, but I didn't find anything.
Bugs creator.
Features destroyer.
Template killer.

Re: [1.0 - blocker] expandIPv6 fails

Reply #2

Good catch!  Was that in the error log?

 

Re: [1.0 - blocker] expandIPv6 fails

Reply #3

Yep, one of the query in Security.php using constructBanQueryIP was failing due to nothing being set in the return of convertIPv6toInts.
Bugs creator.
Features destroyer.
Template killer.