ElkArte Community

Project Support => Support => Topic started by: Jorin on January 06, 2016, 07:27:47 am

Title: buttons not in a row
Post by: Jorin on January 06, 2016, 07:27:47 am
Don't you think it would look better if all the buttons under the text field would be in a row?
Title: Re: buttons not in a row
Post by: Nifty on January 06, 2016, 07:39:19 am
It would be in a row if your Screen would be larger.
Title: Re: buttons not in a row
Post by: Jorin on January 06, 2016, 07:42:37 am
Definitely not.  ;)
Title: Re: buttons not in a row
Post by: emanuele on January 06, 2016, 08:17:16 am
What do these buttons say? O:-)
From what I can tell here the buttons are all on the same line.
Title: Re: buttons not in a row
Post by: Jorin on January 06, 2016, 08:20:40 am
When the word correction is activated, the button for saving a draft uses a new row. The button for adding a poll uses a new row too (everytime).

Will it look better if all buttons will be shown in a single row and the text on the left under the text field would be under them, if there's not enough space? I think so.  ;)
Title: Re: buttons not in a row
Post by: emanuele on January 08, 2016, 04:23:59 am
IIRC this was somehow intentional: the three buttons related to "posting" (preview/save/draft) on the same line, all the others (poll/spellcheck/etc.) below.
Of course there was a technical reason that was a pain to fix (and that I don't remember exactly, but I think it was related to having the "draft last saved" string making buttons jump around, so we made up a technical reasoning to make the solution acceptable. :P
Title: Re: buttons not in a row
Post by: Jorin on January 08, 2016, 04:26:58 am
Can you at least code a little space between the rows then?  O:-)
Title: Re: buttons not in a row
Post by: Flavio93Zena on January 11, 2016, 09:16:22 pm
Quote from: Jorin – Can you at least code a little space between the rows then?  O:-)
You can throw a little margin via css between them, shouldn't be hard.

Quote from: emanuele – IIRC this was somehow intentional: the three buttons related to "posting" (preview/save/draft) on the same line, all the others (poll/spellcheck/etc.) below.
Of course there was a technical reason that was a pain to fix (and that I don't remember exactly, but I think it was related to having the "draft last saved" string making buttons jump around, so we made up a technical reasoning to make the solution acceptable. :P
You sneaky little... EHM ;D
Title: Re: buttons not in a row
Post by: Jorin on January 12, 2016, 01:24:50 am
Quote from: Flavio93Zena (#OpIsis) –
Quote from: Jorin – Can you at least code a little space between the rows then?  O:-)
You can throw a little margin via css between them, shouldn't be hard.

Maybe, but it would be great to see that as a fix for future releases.  ;)
Title: Re: buttons not in a row
Post by: Flavio93Zena on January 12, 2016, 08:50:15 am
I don't think I can enable spellchecker to enable that pester button, so I am afraid I cannot suggest it without seeing it :/
Title: Re: buttons not in a row
Post by: Jorin on January 12, 2016, 08:55:06 am
You can still look at my screenshots.  ;)
Title: Re: buttons not in a row
Post by: Flavio93Zena on January 12, 2016, 09:06:12 pm
Yeah and I can surely edit css from a screenshot, LOL.
Title: Re: buttons not in a row
Post by: Jorin on January 13, 2016, 01:05:48 am
You can't? Time for an upgrade!  :D

Sorry, this was a misunderstanding. I didn't know you want to look in the code. I meant the dev team with my suggestion.
Title: Re: buttons not in a row
Post by: emanuele on January 13, 2016, 03:24:36 am
Ahhh.... wait!
The problem is not what I was thinking, the problem is with the translation!
See the two attachments.
The text is so long that pushes the buttons, that normally are on the same line, down making them appear as two rows of buttons.

If you want to give it some spacing, you can add some margin:
Code: [Select]
#post_confirm_buttons span, #post_confirm_buttons input {
    margin-top: 0.75em;
}
Otherwise you can force the buttons below the legend:
Code: [Select]
.shortcuts {
    float: none;
    display: block;
    text-align: left;
}
Title: Re: buttons not in a row
Post by: Jorin on January 13, 2016, 03:28:04 am
Oh great. This will be a real problem for us translators 'cause sometimes there is no short translation for the buttons which makes sense.  :-\

Edit: As you can see in my screenshots I already shortened the shortcut text so there will be more space for the buttons. I have to think about the best solution in this matter.
Title: Re: buttons not in a row
Post by: emanuele on January 13, 2016, 04:04:31 am
I think everything (legend and buttons) was put on the same line to avoid lots of empty space.
An option could be to have the legend below the buttons aligned with the "draft last saved" string.
That may be enough to arrange everything (or most at least).

Maybe @Spuds or @TE have other ideas. O:-)
Title: Re: buttons not in a row
Post by: Jorin on January 13, 2016, 04:12:49 am
I think I prefer to delete the shortcut text. You have to use the mouse for everything in the board's use, so why do you want to use shortcuts in the editor page? When this text is deleted, the buttons will have all space they need.

Ideas are always welcome!  :)
Title: Re: buttons not in a row
Post by: TE on January 13, 2016, 04:19:32 am
maybe just remove the float for the shortcuts text and make it display:block, so it is displayed in its own row.

Code: [Select]
.shortcuts {
    font-size: .857em;
    /* float: left; */
    overflow: hidden;
    display: block;
}