ElkArte Community Modern, Free, Powerful
Community building forum software

(05:06:25 AM) elk_core: [Elkarte] Spuds opened pull request #525: Latest theme updates from Ant (master...AntUpdates)  http://git.io/UwXc5w
(12:20:27 PM) elk_core: [Elkarte] norv pushed 13 new commits to master: http://git.io/aRbp0g
(12:20:27 PM) elk_core: Elkarte/master 7847f09 Antechinus: ! remove depreciated reset class from the templates...
(12:20:27 PM) elk_core: Elkarte/master fcbfd55 Antechinus: ! Minor class and layout changes to BoardIndex.template.php...
(12:20:27 PM) elk_core: Elkarte/master 59d1671 Antechinus: ! spacing/formatting...

(08:44:39 AM) elk_core: [Elkarte] norv opened pull request #527: Unit testing (master...unittest)  http://git.io/YC4jPg

(02:30:59 PM) elk_core: [Elkarte] Spuds opened pull request #528: ! Update images in white theme (master...AntUpdates)  http://git.io/UiVUTQ
(02:34:01 PM) elk_core: Elkarte/master 90ff501 Antechinus: ! Update images in white theme ... moose with gass...
(02:34:01 PM) elk_core: Elkarte/master fc20151 Norv: Merge pull request #528 from Spuds/AntUpdates...

(02:53:24 PM) elk_core: [Elkarte] Spuds opened pull request #529: ! Some updates to the calendar template and css (master...AntUpdates)  http://git.io/BCS3yw

(03:32:04 PM) elk_core: [Elkarte] emanuele45 opened pull request #530: Profile attachments (master...profile_attachments)  http://git.io/-rJaKg

(04:29:04 PM) elk_core: [Elkarte] eurich opened pull request #531: Refactoring display controller (master...refactoring_display)  http://git.io/r4WV9A

(05:04:57 PM) elk_core: [Elkarte] emanuele45 opened pull request #532: Error log was still showing the wrong file (obviously). Also added a fun... (master...really_fix_backtrace)  http://git.io/ylvj2w
(05:05:32 PM) ***emanuele turned on the IRC client just to see elk_core post something
(05:06:56 PM) elk_core [~elk_core] entered the room.
(05:06:56 PM) elk_core: [Elkarte] emanuele45 pushed 2 new commits to master: http://git.io/AxrtyQ
(05:06:56 PM) elk_core: Elkarte/master 23d8945 emanuele: Error log was still showing the wrong file (obviously). Also added a function to the template layers class to prevent sending out the lower layers in case of errors (should avoid quite a bit of errors in the log)...
(05:06:56 PM) elk_core: Elkarte/master b267d90 emanuele45: Merge pull request #532 from emanuele45/really_fix_backtrace...
(05:06:56 PM) elk_core left the room.

(05:09:07 PM) elk_core: [Elkarte] emanuele45 opened pull request #533: Some $smcFunc leftovers (master...fix_all)  http://git.io/Tos9hQ
(05:25:02 PM) emanuele: darn, it's still broken...

(05:47:29 PM) elk_core: [Elkarte] eurich opened pull request #534: Fix for #520 (master...theme_fixes)  http://git.io/3y1QRQ

(06/16/2013 12:09:07 AM) ichbin: Any reason we can't just add another hook for people to override the front page?
(12:09:37 AM) ichbin: Dispatcher.class --- call_integration_hook('integrate_frontpage', array(&$default_action));
(12:21:11 AM) emanuele: well...technically...it's already there...
(12:21:19 AM) emanuele: now that I think about it
(12:21:36 AM) ichbin: apparently I haven't thought about it. lol How is it already there?
(12:23:04 AM) emanuele: ohh....no scratch that...
(12:23:17 AM) ***emanuele should be in the bed at that time
(12:23:19 AM) emanuele: lol
(12:23:57 AM) ichbin: haha, no problem. Glad I didn't miss anything obvious.

(01:19:02 AM) elk_core: [Elkarte] emanuele45 opened pull request #535: And yet another one... No, backtrace is not nice... (master...error_backtrace_again)  http://git.io/G_Yk2A
(03:53:52 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/wgJ4KA
(03:53:52 AM) elk_core: Elkarte/master 85ee266 emanuele: And yet another one... No, backtrace is not nice... ...
(03:53:52 AM) elk_core: Elkarte/master f6965e6 Norv: Merge pull request #535 from emanuele45/error_backtrace_again...

(03:54:25 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/mZJ3Qg
(03:54:25 AM) elk_core: Elkarte/master 42e3333 emanuele: Some $smcFunc leftovers...
(03:54:25 AM) elk_core: Elkarte/master af5a4b0 Norv: Merge pull request #533 from emanuele45/fix_all...

(03:56:08 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/Srxhwg
(03:56:08 AM) elk_core: Elkarte/master 158c991 Thorsten Eurich: removed the last remain <ul class="reset" ... fixes #520...
(03:56:08 AM) elk_core: Elkarte/master a339ae3 Norv: Merge pull request #534 from eurich/theme_fixes...

(06:33:18 AM) Norv: > (12:09:37 AM) ichbin: Dispatcher.class --- call_integration_hook('integrate_frontpage', array(&$default_action));
(06:33:18 AM) Norv: I removed it during dispatcher coding, and I didn't add it back. Add it
(06:37:29 AM) Norv: It'll have a behavior which IMO is buggy: I think it'll call all hooks added by more than one addon, when only the last added will/should be executed. But that's on the todo list for hooks refactoring.
(06:40:22 AM) ichbin: Hiya Norv!
(06:40:48 AM) ichbin: Sorry was afk there for a minute. No problems. Didn't know you had added that at one point. But, I'll go ahead and add that in and send a PR.
(06:47:19 AM) Norv: Thank you! You need it for the homepage and tinyportal, I guess.
(06:49:10 AM) ichbin: Yep, have been pondering about coding some portal stuff for elkarte. Not sure if I want to start over though. lol
(06:54:45 AM) Norv: Afaik you wanted to revamp tinyportal code. Dunno, for what I saw it'd be much better anyway to revamp it on elk code. It should be far less work too
(07:04:09 AM) Norv: Making it easy for addons/themes is an essential goal, and we've been trying (specially for addons) to make the code seamless to add to
(07:07:06 AM) ichbin: Thank you. I wish I could spend more time helping and learning. It looks like my last commit did not have the sign-off in it. Did I mess that up?

(06:55:55 AM) elk_core: [Elkarte] IchBin opened pull request #537: Adding hook for mod to set its own front page. (master...master)  http://git.io/L9Prgg
(07:00:37 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/RAIO3w
(07:00:37 AM) elk_core: Elkarte/master ca9d04c ichbin: Adding hook option for a mod to set the default front page.

(07:20:03 AM) Norv: Indeed, it didn't
(07:20:31 AM) Norv: Not sure what you use as git client, just about every one of them should have a way to set sign-off

(07:34:02 AM) elk_core: [Elkarte] IchBin pushed 3 new commits to master: http://git.io/6tih0w
(07:34:02 AM) elk_core: Elkarte/master 8decff8 ichbin: Adding hook option for a mod to set the default front page....
(07:34:02 AM) elk_core: Elkarte/master 409330e ichbin: Merge branch 'master' of https://github.com/IchBin/Elkarte
(07:34:02 AM) elk_core: Elkarte/master e387df4 ichbin: Merge branch 'master' of https://github.com/elkarte/Elkarte

(07:36:00 AM) ichbin: hmm... not sure why it's not picking it up. I updated my commit in my repo. Have been using the Git Gui. Must not have selected the sign-off option. Hope I just didn't screw something up. It seemed to have merged nothing...
(07:38:33 AM) ichbin: Ah looks like my sign-off made it in. But there are a couple of merges that seemed to have done nothing. Sorry for any confusion....
(08:33:06 AM) Norv: Argh... wait

(08:44:03 AM) elk_core: [Elkarte] IchBin opened pull request #538: Small syntax fix (master...master)  http://git.io/OC0FxA

(08:45:04 AM) Norv: you really didn't need to try to fix this in elk master. Now the state of the history is worse IMO, because it has useless merges and repeated commits. But I won't reset it, it'd be yet worse lol

(08:46:13 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/Gn46QA
(08:46:13 AM) elk_core: Elkarte/master 4d8201f ichbin: Fixed some syntax with one too many parentheses....
(08:46:13 AM) elk_core: Elkarte/master e03fe11 Norv: Merge pull request #538 from IchBin/master...

(08:47:31 AM) Norv: My suggestion is to create new branches, for any issue you'd like to PR in. Never commit on your master branch, simply, will save a lot of headaches
(08:47:42 AM) ichbin: Sorry. When I was using the GUI and I amended my last commit, it automatically asked me to commit to elk master. I didn't know of any other way to fix it. Next time I'll ask for some help if I get something like that.
(08:48:29 AM) ichbin: ok, I'll just create a bugfixes branch and use that.
(08:48:53 AM) ichbin: oh hey, I already have one. I forgot it's been so long... lol
(08:56:00 AM) Norv: Yes, that's what it did. It was already pulled in elk master, that made it a problem. In elk master, we shouldn't amend commits (not even commit directly (only merge PRs)). Amending elk master means overwriting what is already published, its history, what we others may have already pulled in our repos, that's asking for a lot of trouble.
(08:56:58 AM) Norv: On our own branches, we do amending or forcing commits, but definitely not in elk master.
(08:57:42 AM) ichbin: So elk will never get the amended commit then?
(08:58:42 AM) ichbin: Seems you should want an amended commit, in particular for a sign-off.
(09:00:07 AM) Norv: Well now it did. It would've been better if we just let it be. No, the issue is, I should've noticed it's not signed-off and not merge it in the first place. After I merged it, it's better not amended (after all, it was a line of code).
(09:00:52 AM) ichbin: haha, true. Learned my lesson. I won't commit anymore in Elk.
(09:00:53 AM) ichbin:
(09:03:19 AM) Norv: I don't know if we will ever have a (seemingly) problem (i.e. a big commit not signed-off), you'd better slap me to pay more attention before merge! Hey, more eyes on PRs should catch it in just about all cases
(09:04:37 AM) Norv: Then again, lack of sign-off on commits from people I know they'd sign-off the license is not an "issue" at all. (only a procedure). The license is guaranteed either way.
(09:05:08 AM) Norv: Hehe!
(09:06:01 AM) Norv: (And I'd sign off it in a release. So there.)
(09:09:37 AM) ichbin: haha, good.

(05:14:10 PM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/_UtBpg
(05:14:11 PM) elk_core: Elkarte/master 181bb89 Norv: Add SimpleTest unit test framework....
(05:14:11 PM) elk_core: Elkarte/master ea46150 Norv: Add tests, for each of the forum components....
(05:14:49 PM) emanuele: We have unit testing!
(05:14:59 PM) emanuele: And now we need someone to write tests!
(05:26:28 PM) ***Norv innocently volunteers emanuele. Hey, have you seen the web tester?
(05:28:23 PM) Norv: Nah. Everyone writes tests. As we can, anyway. The start may be slightly more difficult, given our codebase and all. nods

(10:41:59 AM) elk_core: [Elkarte] norv opened pull request #542: escape_wildcard_string() fix wasn't committed. (master...db_fix)  http://git.io/AcwPPw
(10:47:31 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/VzOI1g
(10:47:31 AM) elk_core: Elkarte/master 1684a34 Norv: escape_wildcard_string() fix wasn't committed....

(01:01:40 PM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/6Hzn6w
(01:01:40 PM) elk_core: Elkarte/master 8f6e1e0 Antechinus: ! Some updates to the calendar template and css...
(01:01:40 PM) elk_core: Elkarte/master 8ea396b Antechinus: ! scope=col is needed, putting it back...
(01:01:40 PM) elk_core: Elkarte/master 8d27ea1 Norv: Merge pull request #529 from Spuds/AntUpdates...

(01:20:30 PM) elk_net: [elkarte.net] norv opened pull request #7: Update to 2013-06-17 (master...update)  http://git.io/zbV7Cw
(01:20:58 PM) elk_net: [elkarte.net] norv pushed 3 new commits to master: http://git.io/_T_ymw
(01:20:58 PM) elk_net: elkarte.net/master 7ae77f4 Norv: Update (2013-06-17)...
(01:20:58 PM) elk_net: elkarte.net/master 45118f7 Norv: Fix for db method call....

(03:08:23 PM) elk_core: [Elkarte] norv opened pull request #544: Likes subs fix (master...like_db)  http://git.io/0GxhbQ
(03:08:54 PM) elk_core: Elkarte/master f09d02b Norv: Wrong column name in likes subs....

(03:10:03 PM) elk_core: [Elkarte] Spuds opened pull request #545: A few small issues fixed, see commits (master...fixins)  http://git.io/wauwtg

(03:45:44 PM) elk_core: [Elkarte] norv opened pull request #546: Microformats tweaks (master...microformats_tweaks)  http://git.io/zQftfw
(04:00:05 PM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/Yg8lcg
(04:00:05 PM) elk_core: Elkarte/master e52a2a4 Norv: Document webslices....
(04:00:05 PM) elk_core: Elkarte/master 06b003f Norv: Remove smf format of feed (it was rdf anyway)...

(04:35:11 PM) Norv: emanuele ... how come this isn't merged...? https://github.com/elkarte/Elkarte/pull/530
(04:36:02 PM) ***Norv is growing old. Stupid question: have you made two on this issue, or am I crazy, because I thought I took it in...
(04:36:10 PM) emanuele: mmm
(04:36:15 PM) emanuele: good question...
(04:36:18 PM) Norv: lol
(04:36:27 PM) emanuele: I had a moment I found some duplicated commits here and there...
(04:37:36 PM) ***emanuele does a pull and checks
(04:37:56 PM) emanuele: nope, it's not there in the code
(04:38:29 PM) emanuele: BTW I didn't know the template_TEMPLATE_init functions!
(04:38:34 PM) elk_core [~elk_core] entered the room.
(04:38:34 PM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/TT48ug
(04:38:34 PM) elk_core: Elkarte/master 60f13c6 emanuele: Show links in the profile table show attachments - Thanks Ant for...
(04:38:34 PM) elk_core: Elkarte/master 72ec024 emanuele: Allow themes to load a certain number of attachments in the profile page...
(04:38:34 PM) elk_core: Elkarte/master 393df62 Norv: Merge pull request #530 from emanuele45/profile_attachments...
(04:38:34 PM) elk_core left the room.
(04:39:55 PM) Norv: Lets do it then... I had a couple problems lately with merges, to not overwrite stuff.

(04:51:04 PM) elk_core: [Elkarte] norv opened pull request #547: Small fixes (PR 545) (master...s_fixes)  http://git.io/ndOz9Q
(04:51:34 PM) elk_core: [Elkarte] norv pushed 5 new commits to master: http://git.io/Og5oQw
(04:51:34 PM) elk_core: Elkarte/master cbee379 Spuds: ! This one is a class now, let the dispacher do its thing...
(04:51:34 PM) elk_core: Elkarte/master 49961ef Spuds: ! old check from before moving the query to subs...
(04:51:34 PM) elk_core: Elkarte/master 641134a Spuds: ! missed the _tolist pm pbe template...

(05:45:13 PM) elk_net: [elkarte.net] norv opened pull request #8: A few more updates as made on site (master...more_updates)  http://git.io/4Vj6Pw
(05:45:41 PM) elk_net: [elkarte.net] norv pushed 3 new commits to master: http://git.io/iTA7wA
(05:45:41 PM) elk_net: elkarte.net/master ac734cf Norv: Logo, icons, and calendar updates on site....
(05:45:41 PM) elk_net: elkarte.net/master 268875e Norv: Add logo to _white and _green....
(05:45:41 PM) elk_net: elkarte.net/master 5896930 Norv: Merge pull request #8 from norv/more_updates...

(10:55:58 PM) emanuele: Norv there is still some issues with the "new" next to the topics
(10:58:18 PM) Norv: On site?
(11:20:52 PM) emanuele: yep
(11:21:36 PM) emanuele: I noticed the most recent topic I think
(06/18/2013 01:28:00 AM) ***emanuele can't see the "like" button...
(01:28:13 AM) ***emanuele thinks Norv doesn't want to allow me like things...

(05:19:07 PM) Trekkie101_Away: Hey Norv
(05:36:14 PM) Trekkie101: Is the calendar up for any sort of revamp, does anyone use it?
(05:37:45 PM) Norv: Internal revamp, yes (without much insistence). External - user visible features - no
(05:38:06 PM) Trekkie101: Might I suggest a tiny improvement?
(05:38:21 PM) Trekkie101: Ill even try and code it myself
(05:39:07 PM) Trekkie101: Turn on posting events by default to registered users, currently I think it's admins only
(05:39:25 PM) Norv: Really? Sure
(05:40:04 PM) Trekkie101: I just never see it being used
(05:40:10 PM) Trekkie101: Well, properly
(05:41:03 PM) Norv: Quite. Well, it can't become a must-do, imo, but like many others it's seeing work with the code to make it easier to change/add stuff by mods or us, in the future

(09:54:00 PM) elk_core: [Elkarte] emanuele45 opened pull request #549: Ajax improved (master...ajax_improved)  http://git.io/RQhkBw

(02:24:46 AM) elk_core: [Elkarte] emanuele45 opened pull request #553: Removed db backup (master...remove_db_backup)  http://git.io/qsMY8A

(10:28:40 AM) elk_core: [Elkarte] norv opened pull request #555: Language strings tweaks (master...various)  http://git.io/aCJY_w
(10:31:42 AM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/U9X-rw
(10:31:42 AM) elk_core: Elkarte/master 98394d9 Norv: Tweaked a couple of error messages....
(10:31:42 AM) elk_core: Elkarte/master 28704dc Norv: Language strings fixes. Theme uninstallation should speak...

(11:59:06 AM) elk_core: [Elkarte] emanuele45 opened pull request #556: Dir capitalization (master...dir_capitaliz)  http://git.io/Y9XmwA
(12:08:27 PM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/Mw6YxA
(12:08:27 PM) elk_core: Elkarte/master 2ac096d emanuele: Sources to sources...
(12:08:27 PM) elk_core: Elkarte/master 7300c46 emanuele: Packages to packages...

(12:06:59 PM) elk_core: [Elkarte] norv opened pull request #557: Refactoring display (TE) (master...te_refactoring_display2)  http://git.io/CmJ8PQ
(12:12:25 PM) elk_core: [Elkarte] norv pushed 17 new commits to master: http://git.io/N4lsZg
(12:12:25 PM) elk_core: Elkarte/master 8916c83 Thorsten Eurich: methods visibility...
(12:12:25 PM) elk_core: Elkarte/master 273f4d5 Thorsten Eurich: db query to subs...
(12:12:25 PM) elk_core: Elkarte/master ea25f51 Thorsten Eurich: again, db query to subs...

(02:30:25 PM) ***Dragooon has never used kate
(02:31:19 PM) ***emanuele didn't know what to use the first time he used linux and now he is used to it...
(02:31:53 PM) Dragooon: I don't remember what I used to use when I was on Linux
(02:31:59 PM) Dragooon: I remember using Zend Studio for a while
(02:32:41 PM) emanuele: I don't like IDEs...it becomes too difficult to write bugs

(02:38:56 PM) Dragooon: What did I miss?
(02:39:20 PM) emanuele: That I like write bugz!
(02:39:27 PM) emanuele:
(03:05:47 PM) Dragooon_: You like bugs eh?
(03:05:56 PM) Dragooon_: You're like me. I write more bugs than features
(03:06:04 PM) Dragooon_: Just see Wedge's discussions for example

(04:09:14 PM) elk_core: [Elkarte] Spuds opened pull request #558: Theme Updates II (master...AntUpdatesII)  http://git.io/GI_6uA

(04:16:48 PM) Norv: emanuele antispam questions mess things up
(04:17:15 PM) emanuele: I read TE's message, but I the site works for me...
(04:20:12 PM) Norv: I removed them from the site, lol oops.
(04:20:51 PM) Norv: you haz admin account
(04:21:15 PM) Norv: <-- busy breaking everything even with tests
(04:23:01 PM) emanuele: When did you remove them?
(04:23:20 PM) emanuele: ohhh... nevermind
(04:23:38 PM) ***emanuele tested it when he was still sleepy

(03:13:47 PM) The topic for #elkarte is: This is ElkArte so very official channel. Please note: the channel is public and may be logged and archived publicly at any time.

(04:28:10 PM) Norv: Come on, Ema, please don't worry about bs. Or well, it's hard to ignore since you're in the middle of it, but seriously.
(04:30:59 PM) emanuele: the backup thing?
(04:31:02 PM) Norv: Yeah.
(04:31:34 PM) emanuele: ohh... it was asked so many times that I thought it was easier to just drop it, maybe it's better
(04:31:54 PM) emanuele: and since it was easy I sent it to Elk too just in case
(04:32:25 PM) emanuele: you were too shy to tell me it is useless
(04:34:15 PM) Norv: It does just what we settled for, iirc after a public thread. I've tested it back a while ago, and it was working with quite a big db. I think the warnings will be helpful, too. You don't get awards for this one