Skip to main content
Topic: IRC (Read 107538 times) previous topic - next topic
0 Members and 4 Guests are viewing this topic.

Re: IRC

Reply #315

(11:44:45 PM) ***Norv has fixed a bit in modcenter, and... ok it still works. Was thinking that now was a good time to bail on me. :P

(12:11:10 AM) Norv: [On SMFQuiz mod] This looks like a good test run for Elk. See how easy it'd be to write these features I'm seeing here and how it'll be like.
(12:13:21 AM) ***emanuele is now concentrated on #tags
(12:13:33 AM) emanuele: I had a couple of ideas, but I forgot them lol, after that if I can avoid feature cat and his blog, it may be a nice test
(12:15:47 AM) emanuele: Though for me it would require quite a bit of time due to my repulsion for javascript...
(12:18:25 AM) ***Dragooon loves JS
(12:18:46 AM) Dragooon: It's the absolute best tool to go into depression and die
(12:18:59 AM) emanuele: ROFL
(12:21:20 AM) Norv: Oh no, cat's blog is the coolest, and it haz no js!
(12:21:30 AM) emanuele: lol
(12:21:45 AM) Norv: O:-)
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #316

(12:26:24 AM) emanuele: Should does it make sense to "clean up" (whatever that means) the display_controller branch and submit it or better keep it as an experiment?
(12:33:36 AM) Dragooon: Yes
(12:33:53 AM) ***Dragooon doesn't know anything about it. But still..I think I should give some positive feedback
(12:35:51 AM) emanuele: lol
(12:36:37 AM) ***Dragooon should actually check out elk instead of annoying people here
(12:46:45 AM) Dragooon: Batman!
(12:47:05 AM) emanuele: NaNNaNNaNNaNNaNNaNNaN

(12:48:24 AM) emanuele: Norv: $settings['strict_doctype']
(12:48:28 AM) emanuele: can we kill it?
(12:48:36 AM) emanuele: O:-)
(12:48:40 AM) ***emanuele likes kill
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #317

> emanuele: Should does it make sense to "clean up" (whatever that means) the display_controller branch and submit it or better keep it as an experiment?
(01:06:35 AM) Norv: I think it's worth submitting Ema. Can't get much better (and if it can, it can from there), and it's more readable than those 800 lines
(01:07:38 AM) Norv: I doubt extensibility, but that's not a problem. At the end, what we probably want there, is mainly a hook to allow you to access $context before template, isn't it?

(01:09:05 AM) ***Norv haz just come back after another set of reworking modcenter... without testing yet. If it works this time too, I declare the award yours on place :P
(01:11:22 AM) Norv: Oh come on! It works. :D
(01:11:40 AM) ***Norv thinks that emanuele should go to sleep and not read the log.

(01:19:51 AM) emanuele: Depends...depends...
(01:22:37 AM) Norv: https://github.com/norv/elkarte/commit/de0ea90faa01036a3f7d4d73c1ff811984529dbc
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #318

(04:17:18 PM) elk_core: [Elkarte] Spuds opened pull request #574: Theme Updates III (master...AIII)  http://git.io/quAptw

(04:29:49 PM) Dragooon: Elkarte has autoloading?
(04:53:00 PM) Norv: No. It implements a seamless loading of controllers with a certain naming pattern, but no autoloading.
(04:55:44 PM) Dragooon: Okay

(05:12:43 PM) elk_core: [Elkarte] emanuele45 opened pull request #575: Split controller (master...split_controller)  http://git.io/SkUSPA

(05:39:19 PM) elk_core: [Elkarte] norv opened pull request #576: Controllers (part ...) (master...controllers)  http://git.io/QTYR1g

(06:15:36 PM) elk_core: [Elkarte] emanuele45 opened pull request #577: Error pages (master...error_pages)  http://git.io/UWdpLw
(07:44:27 PM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/zfglKQ
(07:44:27 PM) elk_core: Elkarte/master f641cf0 emanuele: A couple of missing require in Draft controller......
(07:44:27 PM) elk_core: Elkarte/master 9b98d8d emanuele: Passed $filter to numErrors and restored correct pagination of filtered errors...
(07:44:27 PM) elk_core: Elkarte/master 0e0dfe7 Norv: Merge pull request #577 from emanuele45/error_pages...
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #319

(06:39:04 PM) emanuele: The PM controller is scary too...
(06:51:45 PM) Dragooon: Anything PM is scary!

(07:13:28 PM) elk_core: [Elkarte] eurich opened pull request #578: Themes.php refactoring (master...manage_themes)  http://git.io/UXcv0g

(08:19:38 PM) Norv: just to note, your vision on PMs sounds very good to me. Once we redesign PMs implementation as we'd want, to add pages pulling PMs in different 'views' can easily be made by addons (or even us but *separately*! :D)
(08:21:01 PM) ***Norv has an obsession on separation of code.
(08:53:40 PM) ***emanuele was considering "separate" the PMs as well
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #320

(01:31:06 AM) elk_core: [Elkarte] norv pushed 18 new commits to master: http://git.io/zfP_tg
(01:31:06 AM) elk_core: Elkarte/master ffa2412 Antechinus: ! remove plainbox from display template...
(01:31:06 AM) elk_core: Elkarte/master 12a5d91 Antechinus: ! updates to page index layout, top/bottom controls,...
(01:31:06 AM) elk_core: Elkarte/master 14bfd54 Antechinus: ! Remove simplebox class from markup...

(01:50:04 AM) elk_core: [Elkarte] norv pushed 19 new commits to master: http://git.io/g7xUnw
(01:50:04 AM) elk_core: Elkarte/master 54b97d1 Thorsten Eurich: cleaning from unused vars and $db init.....
(01:50:04 AM) elk_core: Elkarte/master f7800b6 Thorsten Eurich: methods visibility, forgot $db init....
(01:50:04 AM) elk_core: Elkarte/master d828f67 Thorsten Eurich: moved function get_file_listing() to subs....
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #321

(02:11:05 AM) elk_core: [Elkarte] emanuele45 opened pull request #579: Random refactoring (master...random_refactoring)  http://git.io/fdkd3g

(02:21:08 AM) groundup: http://silex.sensiolabs.org/contributors <-- I like that
(02:27:29 AM) emanuele: Nice! :D

(04:08:25 PM) elk_core: [Elkarte] eurich opened pull request #580: Rebuilding the blue variant. (master...rebuild_old_variants)  http://git.io/iltWIA

(05:16:09 PM) elk_core: [Elkarte] eurich opened pull request #581: relative time fix (master...relative_time_fixes)  http://git.io/PSAt_g

(06:34:16 PM) ***emanuele is tempted to cleanup completely PM controller and start from scratch...
(06:39:29 PM) ***Norv removes PM controller.
(06:39:35 PM) Norv: Thy wish is my command :P
(06:54:59 PM) emanuele: darn...I squashed a commit that was just a WIP...
(07:05:16 PM) ***emanuele thinks Norv wants a lot of bugz in PMs
(07:08:59 PM) Norv: Nope, doesn't, lol
(07:09:28 PM) Norv: PMs are cool stuffs. Well visibly. :P
(07:10:23 PM) Norv: Well, seriously, isn't cleaning mercilessly (not wipe, but mercilessly modes, etc) going to make a change?
(07:11:57 PM) emanuele:  hope...though every once in a while I come back to the idea of a "radical" change in PMs (that I'm working on) and I start asking myself if it wouldn't be faster to just write it lol
(07:12:59 PM) emanuele: BTW: https://github.com/emanuele45/Dialogo/blob/master/sources/controllers/PersonalMessage.controller.php#L203
(07:13:07 PM) emanuele: Any idea what the 'view' is?
(07:13:21 PM) emanuele: It changes the view, but I'm not sure how
(07:13:34 PM) emanuele: ...and why it is there in the first place
(07:20:37 PM) Norv: https://github.com/emanuele45/Dialogo/blob/master/themes/default/PersonalMessage.template.php#L581
(07:23:53 PM) emanuele: ?
(07:24:17 PM) ***emanuele wants to use createList there one day or another
(07:33:06 PM) Norv: It sends view param, so apparently it changes the view (convo mode)... But I have no idea if it works. Must be very old code, I think
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #322

(07:26:49 PM) elk_core: [Elkarte] AaronVanGeffen opened pull request #582: Title attributes in display template (master...master)  http://git.io/fo_CNg

(07:27:04 PM) ***TimeVortex is avoiding his studies for a bit
(07:27:27 PM) TimeVortex: Fixed a tidbit and sent in my first PR to you guys. :P Don't expect too much.
(07:27:46 PM) TimeVortex: I better not have broken anything in my PR. :P
(07:33:15 PM) Norv: Thank you TimeVortex! ;D

(07:34:55 PM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/z2mFJw
(07:34:55 PM) elk_core: Elkarte/master c0652ed Thorsten Eurich: relative time: grammar corrections for quotes...
(07:34:55 PM) elk_core: Elkarte/master 6171cd2 Norv: Merge pull request #581 from eurich/relative_time_fixes...

(07:38:26 PM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/fUurfQ
(07:38:26 PM) elk_core: Elkarte/master 7b2033a Aaron van Geffen: Removed superfluous title attribute for reply numbers;...
(07:38:26 PM) elk_core: Elkarte/master a586fd0 Norv: Merge pull request #582 from AaronVanGeffen/master...

(07:41:42 PM) groundup: Instead of <div class="windowbg2"> for posts change that to article. Instead of <a id="msg123"> change that to <article id="123"> add a class="unread" for unread posts
(07:42:00 PM) groundup: Just thought of that because of Aaron's PR
(07:45:41 PM) groundup: Use rel="author" for article authors
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #323

(07:42:07 PM) Norv: emanuele: tbh I was thinking we (you, when you're in the mood for a forum post explaining stuff?) could organize a hunt for places for createList(). *sagenods*.
(07:42:30 PM) ***emanuele thinks there aren't many left... lol
(07:42:44 PM) Norv: I remember there was one in admin... and there's Packages
(07:43:31 PM) Norv: I suppose PackageServers too (off-hand speaking, didnt check)
(07:44:03 PM) emanuele: Packages already uses createList (it's overall a bit ugly but it works)
(07:44:14 PM) Norv: Ah ok. Sorry :D
(07:44:29 PM) emanuele: PackageServers...mmm...never looked at that...lol
(07:44:38 PM) emanuele: Do we "need" it?
(07:45:02 PM) emanuele: I always wondered if it really used

(07:45:29 PM) elk_core: [Elkarte] norv pushed 4 new commits to master: http://git.io/JavZxQ
(07:45:29 PM) elk_core: Elkarte/master de417c5 Thorsten Eurich: welcome back, blue variant :P...
(07:45:29 PM) elk_core: Elkarte/master ca49fe0 Thorsten Eurich: blue variant: some adjustments, colors etc.....
(07:45:29 PM) elk_core: Elkarte/master 2318763 Thorsten Eurich: blue variant: more small improvements...
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #324

(07:47:39 PM) Norv: IMO, PackageServers is definitely way underused, to what it should be. In my perspective, the proprietary 'centralization' to sm.org has a lot to do with the reasons. But yeah, UI improvements and real documentation on how to use it, should help
(07:51:48 PM) Norv: It's trivial to make a package server on your site. But, well, people make big mods for downloads instead. *headscratch*. Perhaps even an admin feature to enable or set your own package server may help? Or an editor interface (if entirely basic) for the xml file? Ok, maybe as features it's overkill (and a bit risky) but, some very visible way to do it.

(07:47:32 PM) TimeVortex: Norv: no probs! Glad to be of some help, even if only a little.
(07:49:04 PM) TimeVortex: Norv: I think the absolute timestamp should always be shown on hover, by the way, not just on topic display (e.g. also on the board and message index)
The best moment for testing your PR is right after you merge it. Can't miss with that one.

 

Re: IRC

Reply #325

Dumping this, as have decided a new topic is better.
Last Edit: June 23, 2013, 05:39:06 pm by Antechinus
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: IRC

Reply #326

Quote from: Antechinus – Dumping this, as have decided a new topic is better.
That's ok, but we have quote to new topic. It'd have linked it here. ;)

Instead, I'll just link it for people to know to refer to.

Quote from: TestMonkey – (07:41:42 PM) groundup: Instead of <div class="windowbg2"> for posts change that to article. Instead of <a id="msg123"> change that to <article id="123"> add a class="unread" for unread posts
(07:42:00 PM) groundup: Just thought of that because of Aaron's PR
(07:45:41 PM) groundup: Use rel="author" for article authors
Semantics, HTML5, and other gruesomeness.
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #327

(06/24/2013 01:03:35 AM) ***Norv has just cleaned up MoveTopic controller of queries and brags about it :P
(01:04:58 AM) emanuele: Now do it with PersonalMessage! :P
(01:06:01 AM) Norv: But-but. Wouldn't want to spoil it for ya. ;D
(01:07:09 AM) emanuele: lol

(01:34:11 AM) Norv: What is the use of printpage? (serious question in a sense)
(01:35:28 AM) ***Norv has cleaned the last bit of the other action handlers of Topic controller, but action_printpage() still prevents it to be clean of them pesky queries.
(01:35:41 AM) ***emanuele has never used it
(01:36:13 AM) emanuele: though I remember someone asked even for a "print" version of the memberlist
(01:36:54 AM) Norv: Mmm. This print view... can't really be done with css stuffs alone, I'd think...
(01:37:32 AM) emanuele: I think it should be possible
(01:38:08 AM) emanuele: Probably the original idea was to create a simplified black&white version of the page with much less informations
(01:38:35 AM) Norv: Yes. Well you also have pagination to get rid of... and probably more I don't remember atm
(01:38:42 AM) emanuele: Also printpage (AFAIR) doesn't use the callback even though it prints all the messages in a topic
(01:38:48 AM) Norv: Yep
(01:39:40 AM) emanuele: But:
(01:40:04 AM) groundup: view all, print. Seems simple enough
(01:40:06 AM) emanuele: who is going to print "in one go" all the messages of a topic?
(01:42:51 AM) Norv: The smileys and stuff processing must not be done, too, for print view.
(01:43:27 AM) Norv: So you think normal pagination should be kept?
(01:45:30 AM) emanuele: Difficult to guess how people could use a feature when you have never used it (and AFAIR I never printed pages from the internet except a couple of maps from google)
(01:45:53 AM) ***Norv is confused, cause I don't see how it could be done instead. I blame 2 am, but, hrm.

(01:48:49 AM) emanuele: ROFL 1.3 GB of prettyURL cache!
(01:49:05 AM) emanuele: no, that's wrong, it can't be
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #328

(12:13:34 AM) elk_core: [Elkarte] norv pushed 12 new commits to master: http://git.io/Q-5L5w
(12:13:35 AM) elk_core: Elkarte/master 62a1f70 Thorsten Eurich: unused code $ globals.....
(12:13:35 AM) elk_core: Elkarte/master 3e13d99 Thorsten Eurich: $db init wasn't needed...
(12:13:35 AM) elk_core: Elkarte/master 841a9d3 Thorsten Eurich: unused globals, blank line....

(04:44:05 AM) elk_core: [Elkarte] IchBin opened pull request #587: Clear error log buttons (master...bugfixes)  http://git.io/vI1S_w
(11:27:19 AM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/BA6zFQ
(11:27:19 AM) elk_core: Elkarte/master 05aff09 ichbin: I want buttons to remove log entries at the top too. :)...
(11:27:19 AM) elk_core: Elkarte/master f63e05b ichbin: I want buttons to remove log entries at the top too. :)...
(11:27:19 AM) elk_core: Elkarte/master 67a0ce9 Norv: Merge pull request #587 from IchBin/bugfixes...
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: IRC

Reply #329

(11:33:23 AM) elk_core: [Elkarte] norv opened pull request #588: Picks (master...picks)  http://git.io/NKIUiw
(11:34:03 AM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/ZKZ5MA
(11:34:03 AM) elk_core: Elkarte/master 353f431 Antes: apostrophe causing error....
(11:34:03 AM) elk_core: Elkarte/master 65ab52e Norv: fix syntax potential issue....
(11:34:03 AM) elk_core: Elkarte/master c4aff1b Norv: Merge pull request #588 from norv/picks...

(12:27:10 PM) elk_core: [Elkarte] norv opened pull request #589: Ant themeupdates (master...ant_themeupdates)  http://git.io/NdrdYg
(01:30:46 PM) elk_core: [Elkarte] norv pushed 4 new commits to master: http://git.io/b3DU4w
(01:30:46 PM) elk_core: Elkarte/master 80ec9ba Antechinus: All this bundle does is convert the remaining transitional doctypes to HTML5....
(01:30:46 PM) elk_core: Elkarte/master 077f74c Antechinus: Removes the last examples of .titlebg2 from Elk (Calendar.template.php and Search.template.php)...
(01:30:46 PM) elk_core: Elkarte/master dc8a7e1 Antechinus: Basic cleanup for help pop-up markup and CSS....
The best moment for testing your PR is right after you merge it. Can't miss with that one.