Skip to main content
Topic: This darn editor... stop screwing my undo!!! xD (Read 4339 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

This darn editor... stop screwing my undo!!! xD

Is it possible to disable the editor undo? (Even on a personal level.)
It's completely different from any other undo I use (including the browser's one) and I lose more text thanks to the internal undo than the one I'm able to save...

Or maybe have it on on the WYSIWYG and disabled on the "normal"?

 emanuele hopes one day the mobile apps will implement their own undo/redo so that it will be less random and more consistent...

ETA: of course if it is not possible... who cares! :P
Last Edit: April 19, 2016, 08:49:01 am by emanuele
Bugs creator.
Features destroyer.
Template killer.

Re: This darn editor... stop screwing my undo!!! xD

Reply #1

Anything is possible!

The undo/redo thing is just a plugin, so no different from being able to disable drafts for a user, just would need to add the option to the look/layout area.

That said, what is it messing up / doing wrong?


Re: This darn editor... stop screwing my undo!!! xD

Reply #2

@Spuds It does very weird things with the cursor and it breaks normal undo to boot. I say just let the button click do its own thing without interfering with any keyboard shortcuts.

Edit: btw, @ mentions seem to be broken. I thought it was just that I was trying PHP7 on my local install, but it's here too.

Re: This darn editor... stop screwing my undo!!! xD

Reply #3

@Frenzie What's broken about the @?
Bugs creator.
Features destroyer.
Template killer.

Re: This darn editor... stop screwing my undo!!! xD

Reply #4

Oh, maybe it's the WYSIWYG? @Orange-kun‍ ? (Just to avoid repeated mentions to Frenzie‍  :P)
Bugs creator.
Features destroyer.
Template killer.

Re: This darn editor... stop screwing my undo!!! xD

Reply #5

Quote from: Spuds – That said, what is it messing up / doing wrong?
Okay, now it doesn't work. xD
Apparently on paste or on "insert quote" it stops working.

Dunno, maybe I have overreacted... I'll give it a second try. :)
Bugs creator.
Features destroyer.
Template killer.

Re: This darn editor... stop screwing my undo!!! xD

Reply #6

@emanuele nah, I don't use wysiwig normally. But it's working for you o. O

Edit: oh perhaps it was the wysiwig or full reply page.

Oh wait, the broken preview thing may be it.

Re: This darn editor... stop screwing my undo!!! xD

Reply #7

@Spuds Just testing.

Edit: hm, that seems to have worked.

Re: This darn editor... stop screwing my undo!!! xD

Reply #8

I'm not seeing the mention pulldown in the quick reply area (with the full editor) but its fine on the post screen.

Re: This darn editor... stop screwing my undo!!! xD

Reply #9

@Spuds It's not the pulldown I'm talking about (I don't know if that worked or not) but the fact that in http://www.ElkArte.net/community/index.php?topic=3525.msg25144#msg25144 there's no link or anything. I tried with a couple of testing accounts on a local install and nothing worked there either, but like I said I was checking out PHP7.

Re: This darn editor... stop screwing my undo!!! xD

Reply #10

Well, if there is no pull down for sure doesn't work and it can be javascript broken client-side, or the data not fetched server-side.
If there is the pull down but it still doesn't work it could be javascript client-side not properly storing the member id in the form, or server side not properly using the id.
So there are a couple of possibilities.

BTW, apparently uploaded avatars are completely missing... realized only now. xD
Bugs creator.
Features destroyer.
Template killer.

Re: This darn editor... stop screwing my undo!!! xD

Reply #11

Ah, with JS disabled they don't seem to work? Interesting, I thought it was just like the automatic URL linking.

Re: This darn editor... stop screwing my undo!!! xD

Reply #12

Nope, since it seemed a bit bothersome to have to parse the message on post to take out the names, look-up the members table potentially multiple times, etc. I went for the lazy way: cutting down all the edge cases, the idea is the pull down saves the selected member id and is sent to the server, then php uses this to send the notification.
Bugs creator.
Features destroyer.
Template killer.


Re: This darn editor... stop screwing my undo!!! xD

Reply #14

hmm....

Okay, now I feel like I have an idea.
Bug one:
1) click reply,
2) start typing,
3) after a while use ctrl+z (or click the button,
=> anything you have typed is gone.

Bug two:
1) click reply,
2) start typing,
3) after a while use ctrl+z (or click the button,
4) the whole post is gone,
5) start typing again,
6) after a while use ctrl+z (or click the button,
=> the undo doesn't work any more.

Of course, since I'm using a... peculiar system, more testing is recommended.

ETA: actually this should really go to bug reports, right?
Bugs creator.
Features destroyer.
Template killer.