ElkArte Community

Title: old_url and jsoption
Post by: scripple on March 22, 2015, 01:25:37 pm
When trying to update to 1.0.3. I ran into a conflict with one of my mods.  The conflict is on the old_url line where you added a check for ";api".  The reason I have a mod to that line is I added "js" to the checks.  This was done because jsoption in themes/default/scripts/script.js is called without ;xml and improperly causes old_url to be set to something bad.

Roughly a year ago we discussed adding ;xml to this call but I don't think it ever happened.
http://www.elkarte.net/community/index.php?topic=1320.msg8975#msg8975

I haven't actually verified the ;xml doesn't get appended at some point in scripts.js so I thought I could raise this issue again before I remove my js check on old_url.  If it has been fixed please let me know and I'll remove the js check.  If not maybe this would be a good time to fix the call to jsoption.
Title: Re: old_url and jsoption
Post by: emanuele on March 22, 2015, 01:44:39 pm
Arg... bundled with two other reports I lost track of it.

Well, now it's at github so it will not be forgot: https://github.com/elkarte/Elkarte/issues/1999
Title: Re: old_url and jsoption
Post by: scripple on March 22, 2015, 01:47:28 pm
Thanks.  I'll update my mod to work with 1.0.3 for now then.
Title: Re: old_url and jsoption
Post by: emanuele on April 01, 2015, 03:25:05 pm
https://github.com/emanuele45/Dialogo/commit/f58bcfd94f34e6b6f086cfa08cfc4fee5efda38d