ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: forumsearch0r2 on February 19, 2014, 03:19:03 am

Title: OpenID login broken
Post by: forumsearch0r2 on February 19, 2014, 03:19:03 am
I can't log in with OpenID anymore. "Supplied OpenID provider not found".
Title: Re: OpenID login broken
Post by: TE on February 19, 2014, 03:35:24 am
ups, yes.. probably my fault.. :o  I'll check.
Title: Re: OpenID login broken
Post by: TE on February 20, 2014, 04:25:16 pm
@Spuds , @emanuele
need help with this..
That bug exsists since 11. february and I can reproduce it with 0c53f86 but not with cc0c6b3 (see screenshot).
the Problem is' there's no code related to OpenID in both revisions..
Maybe I misread my git log?

Title: Re: OpenID login broken
Post by: emanuele on February 20, 2014, 05:25:27 pm
/me is innocent no matter what. :P
Title: Re: OpenID login broken
Post by: emanuele on February 20, 2014, 06:04:29 pm
/me blames the keyboard
It's a missing (another) double quote on the login page, after
Code: [Select]
name="cookieneverexp
at line 75.

@Spuds do you want to fix it here?

Never mind it's not enough...
Title: Re: OpenID login broken
Post by: Spuds on February 20, 2014, 06:50:46 pm
Also found a small bug in the curlFetch class where it was sending things as a post request when it should not.  That was due to me adding in a missing var declaration so a !isset now needs to be !empty   ...    Still not sure this has fixed it though!
Title: Re: OpenID login broken
Post by: TE on February 21, 2014, 01:48:30 am
Quote from: Spuds – Also found a small bug in the curlFetch class where it was sending things as a post request when it should not.
yep, that's probably the issue  ... the whole communication part seems to be broken. it's looking like there's no Response from the remote ..
https://github.com/elkarte/Elkarte/pull/1410 should fix it, right? merged the PR, I'll test OpenID soon...
Title: Re: OpenID login broken
Post by: TE on February 21, 2014, 10:06:58 am
@Spuds fixed, great catch :+1:
Title: Re: OpenID login broken
Post by: forumsearch0r on March 13, 2014, 01:00:35 pm
Was about time!  :-\  :D