Skip to main content ↑ ↓
Topic: OpenID login broken (Read 2843 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

OpenID login broken

I can't log in with OpenID anymore. "Supplied OpenID provider not found".

Re: OpenID login broken

Reply #1 –

ups, yes.. probably my fault.. :o  I'll check.
Thorsten "TE" Eurich
------------------------

Re: OpenID login broken

Reply #2 –

@Spuds , @emanuele
need help with this..
That bug exsists since 11. february and I can reproduce it with 0c53f86 but not with cc0c6b3 (see screenshot).
the Problem is' there's no code related to OpenID in both revisions..
Maybe I misread my git log?

Thorsten "TE" Eurich
------------------------

Re: OpenID login broken

Reply #3 –

 emanuele is innocent no matter what. :P
Bugs creator.
Features destroyer.
Template killer.

Re: OpenID login broken

Reply #4 –

 emanuele blames the keyboard
It's a missing (another) double quote on the login page, after
Code: [Select]
name="cookieneverexp
at line 75.

@Spuds do you want to fix it here?

Never mind it's not enough...
Last Edit: February 20, 2014, 06:11:41 pm by emanuele
Bugs creator.
Features destroyer.
Template killer.

Re: OpenID login broken

Reply #5 –

Also found a small bug in the curlFetch class where it was sending things as a post request when it should not.  That was due to me adding in a missing var declaration so a !isset now needs to be !empty   ...    Still not sure this has fixed it though!

Re: OpenID login broken

Reply #6 –

Quote from: Spuds – Also found a small bug in the curlFetch class where it was sending things as a post request when it should not.
yep, that's probably the issue  ... the whole communication part seems to be broken. it's looking like there's no Response from the remote ..
https://github.com/elkarte/Elkarte/pull/1410 should fix it, right? merged the PR, I'll test OpenID soon...
Thorsten "TE" Eurich
------------------------

Re: OpenID login broken

Reply #7 –

@Spuds fixed, great catch :+1:
Thorsten "TE" Eurich
------------------------
 

Re: OpenID login broken

Reply #8 –

Was about time!  :-\  :D
-