Print Page - Slogan in Place of Logo

Title: Slogan in Place of Logo
Post by: ahrasis on January 14, 2018, 02:10:00 am

As mention in current theme settings:

QuoteSite slogan:
(Add your own text for a slogan here. It will replace the default logo.)

However, when we placed a slogan in default theme, the logo is never replaced but stay on top of the slogan.

The relevant code in index.template.php:

Code: [Select]

				<span id="logobox">
					<img id="logo" src="', $context['header_logo_url_html_safe'], '" alt="', $context['forum_name_html_safe'], '" title="', $context['forum_name_html_safe'], '" />', empty($settings['site_slogan']) ? '' : '
					<span id="siteslogan">' . $settings['site_slogan'] . '</span>', '
				</span>

It seems it is the same for both 1.1 and 1.0. I know the fix is simple but is this intended?

Title: Re: Slogan in Place of Logo
Post by: emanuele on January 14, 2018, 03:05:36 am

/me smells a "oops I forgot to clean up" by a certain dev whose name starts and ends with an "e". O:-)

Title: Re: Slogan in Place of Logo
Post by: ahrasis on January 15, 2018, 02:06:44 am

I am not sure how (I forget) but I'll PR.

Title: Re: Slogan in Place of Logo
Post by: emanuele on February 22, 2018, 03:15:20 pm

I seem to remember you sent the PR, right @ahrasis ?

Title: Re: Slogan in Place of Logo
Post by: ahrasis on February 22, 2018, 05:28:43 pm

Yeah, I think I did it.

ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: ahrasis on January 14, 2018, 02:10:00 am