I'd say it's a bug and here is what I noticed:
- I created a new custom icon called mobile (I used a copy of one existing image file renaming it to mobile.png)(Link-5772)
- when opening a new topic or posting a reply you can choose the custom icon from dropdown but it is not displayed in topic view. If you try to edit the post using the complete editor (More -> Edit) you will get the same result, custom icon displayed in editor but not visible in topic view(Link-5774) (Link-5776)
- strange is if I use the Quick Edit option I see the default icon instead of my custom icon. Changing the icon from Quick edit works and icon is visible after edit.(Link-5778) (Link-5780)
You are right : it's exactly the problem.
The probem is for a new topic or a reply. An example :(Link-5783) (Link-5785)
This appears to be caused by MessageTopicIcons.class.php not loading in the custom icons, it only loads in the known default ones. I have a fix proposal that I'll place on github for review.
My proposal for review ... https://github.com/Spuds/Elkarte/commit/c5983054e54da453ed2d868e7b67d61db1009645
Thank you to try to solve this bug.
I don't understand what to do with the files in github ! I must just take these files and replace the same on a test forum ?
If you want to test, you would take this (https://raw.githubusercontent.com/Spuds/Elkarte/c5983054e54da453ed2d868e7b67d61db1009645/sources/subs/MessageTopicIcons.class.php) version of MessageTopicIcons.class.php and replace sources/subs/MessageTopicIcons.class.php
You would then have to edit the file sources/subs/TopicUtil.class.php
$icon_sources = new MessageTopicIcons(!empty($modSettings['messageIconChecks_enable']), $settings['theme_dir']);
$icon_sources = new MessageTopicIcons(!empty($modSettings['messageIconChecks_enable']), $settings['theme_dir'], $topics_info);
But not this is just a proposal at this point, there may be a better fix ;)
This issue should be tracked so hopefully it can be fixed before 1.1.4 is released.
Your proposal is in test but nothing change : the new icon is stil not display after submit, but if i edit my message the icon is here.
What I did fixed the icon not displaying correctly in the topic listing. Unfortunately is a different error than the one being discussed here!
I've been looking into the error discussed above, and while doing that, I've found yet another issue with them! Hope to have a proper fix for all of these issues soon.
Thank you Spuds ! :D
Use this file (https://raw.githubusercontent.com/elkarte/Elkarte/388d21fd69cfe529518b0863296f62947a01ad2e/sources/subs/MessageTopicIcons.class.php) and replace sources/subs/MessageTopicIcons.class.php
That should fix one more of the issues ...
A great thank you Spuds !
It works fine.
I would to clic to a like button but no Like button is display ! I can see somme Likes made by other users but buttons for me.
i'm back with the same problem !
I just installed the 1.1.7 package from 1.1.6 and the problem with the icon come back.
I had an error on the MessageTopicIcons.class.php to update to 1.1.7 and just now i understand it is because i changed the file to resolve an another problem !
Maybe is it possible to fix this bug in the 1.1.7 package ?
I let the bug like this for now.
I'll have to get into my wayback machine and see what I fixed the first time !
Could you describe what you are doing so I can fix this properly? I made some 1.1.7 changes so that the default message icons now use SVG images, and only if you enable custom message icons will you see the non default ones. Disabling custom message icons should also prevent former custom ones from showing.
3 years ago to solve this problem i just replaced the file by yours.
Is it what you need ?
No, don't do that ... its an old file.
I can't remember what I was doing last night so I was just trying to get a fresh recap of the issue since there have been several releases of the software been then and 1.1.7 .
Sorry, the issue is exaclty the same as decribe here :
Not sure for this part :
I remember about this bug, but I cannot reproduce it anymore using a clean install (1.1.6 + 1.1.7 test package installed)
=== edit ===@augras
make sure you have "Enable customized message icons" option enabled in ACP -> Forum -> Smileys and Message Icons -> Settings
If you are using a custom theme, please make sure these edits were done to that themes files (if they exist)
Thank you Spuds.
I use Elkarte Light with no changes, or i don't remember (but i really don't think).
I take a look to the files and comme back.
It's ok : the 2 files are in 1.1.7 and all the modifications are here.
I mean the code was already in the files but it still doesn't work.
I'm on hollidays for the week but i will test on a fresh install at my back.
OK please report back.
I noticed you are using Flarum style on your site so there could be a small compatibility issue with that and 1.1.7 but I have not checked into that.
Have a great time off.
On a fresh 1.1.6+1.1.7 elkarte :
after Enable customized message icons i added a camera.png with Video entry... i can choose this in the message but still standard icon displayed.
Flarum style works fine with 1.1.7 and in flarum page the camera icon is corretly displayed !
With Elkarte light theme : doesn't work(Link-6913)
With Flarum : it works(Link-6915)
It's the same thing on my old Elkarte and the fresh one.
Don't you hate when you know you tested something to make sure it worked, and then it does not ! Darn I know I tested that, off to look at what I mussed up.
I believe I found the error.
In file /sources/subs/MessageTopicIcons.class.php
Please give that a try and let me know if it fixes it for you.
Don't worry, i'm here to remeber that to you ! ;)
But you finally won !(Link-6917)
Thank you again,
I know something:
glad it is solved now!