ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: badmonkey on August 17, 2017, 09:53:00 pm

Title: Email notification sends incorrect message
Post by: badmonkey on August 17, 2017, 09:53:00 pm
1.1 RC1.  When receiving email notifications of Likes, the message states the member added you as a buddy rather than the member Liked your message.  
Title: Re: Email notification sends incorrect message
Post by: emanuele on August 18, 2017, 05:55:48 am
hmm... are you getting it here?
What notification frequency do you have? (Daily or weekly?)
Title: Re: Email notification sends incorrect message
Post by: badmonkey on August 18, 2017, 07:06:54 am
Haven't configured notifications here.  May try that.  The errant message is with instant notification.   ;)
Title: Re: Email notification sends incorrect message
Post by: emanuele on August 18, 2017, 09:40:19 am
Would you mind trying with the most recent code?
It may have been fixed in between RC1 and the currently almost RC2.

You can just take the github download https://github.com/elkarte/Elkarte/archive/development.zip extract it and replace your the sources directory. It would be best to replace also themes. and everything (just in case), though you may miss some of the most recent fixes you reported here and that you fixed by hands (I'm not sure if they have been already integrated).
Title: Re: Email notification sends incorrect message
Post by: badmonkey on August 18, 2017, 02:39:41 pm
It is the most recent code, sans about a 10 days or so.   ;)
Title: Re: Email notification sends incorrect message
Post by: emanuele on August 19, 2017, 03:20:39 pm
https://github.com/elkarte/Elkarte/pull/2974/commits/80eacd8656f890c48f423e59f437953655f9158b
Title: Re: Email notification sends incorrect message
Post by: badmonkey on August 19, 2017, 03:54:20 pm
Thanks eman!  You da man!   8)
Title: Re: Email notification sends incorrect message
Post by: emanuele on August 19, 2017, 06:18:04 pm
Actually, it was a bit more bugged than I thought. Discarded the previous fix and created:
https://github.com/elkarte/Elkarte/pull/2974/commits/c411c5b54ec9054e7776b7c7a07cf85f4f7f4cf8
should be better, but I may be missing something obvious again.