Re: $context -> loadTheme() setupThemeContext()
Reply #2 –
A couple of things I think loadTheme is doing and do not belong there:
if (isset($_SERVER['HTTP_HOST']) || isset($_SERVER['SERVER_NAME']))
if (isset($detected_url) && $detected_url != $boardurl)
if ($context['user']['is_guest'] && empty($context['user']['name']))
if ((!empty($modSettings['mail_next_send']) && $modSettings['mail_next_send'] < time() && empty($modSettings['mail_queue_use_cron'])) || empty($modSettings['next_task_time']) || $modSettings['next_task_time'] < time())
Do we still need that one?
context['character_set'] = 'UTF-8';
Probably for "compatibility"?
I'd say let's put a @deprecated tag and let's start to phase it out.