I'm starting to package up Elk 1.1.10, below are the key updates/fixes that will be included. If you have experienced other bugs (than those listed) please report them now. From the below list, the most interesting are:
- A fix for MySql 8.0.2+
- Additional fixes for PHP 8.x
- Changed the behavior of JS/CSS minimization. Currently it combines CSS and above/below fold JS files into single files and minimizes those. The new behavior removes that combining and simply minimizes each individual file and includes each file in the output. It now also minimizes (read remove white space) any inline CSS and JS that is included. The former combining behavior was a good practice when sites were HTTP/1.1 and had limited concurrent connections, but with HTTP/2 being more prevalent now, that constraint is no longer a concern as its multiplexing feature eliminates the need for concurrent connections. Should you need the old behavior you will need to do a file edit, but really its time to move on.
1.1.10 Changelog
- Below are the key changes in 1.1.10, the full change listing is (here (https://github.com/elkarte/Elkarte/compare/master...patch_1-1-10)).
Feature Enhancements
- [Enhancement] Update to a new JS minimizer lib (ref (https://github.com/elkarte/Elkarte/commit/01bb1f0cd)).
- [Enhancement] Improve the live news formatting with MD->HTML (ref (https://github.com/elkarte/Elkarte/commit/910d578c4)).
- [Enhancement] Enhance js/css combiner to allow minimizing only and add capability for inline js and css (ref (https://github.com/elkarte/Elkarte/commit/f7ba4d504)).
- [Enhancement] New option to place spider in a restrictive group (not just based on) (ref (https://github.com/elkarte/Elkarte/commit/d72bf3641)).
General Improvements
- [Improve] Add ability to use tab specific help in place of generic (ref (https://github.com/elkarte/Elkarte/commit/ce44ebf81)).
- [Improve] Video linking should be deferred (ref (https://github.com/elkarte/Elkarte/commit/c5d7e0a08)).
- [Improve] News fader can be deferred (ref (https://github.com/elkarte/Elkarte/commit/21b25197e)).
- [Improve] Do not add ORDER BY NULL to INSERT queries containing sub-selects (ref (https://github.com/elkarte/Elkarte/commit/0ec5f1933)).
- [Improve] Add a simple function to check if a deferred resource is available for use (ref (https://github.com/elkarte/Elkarte/commit/525149a58)).
- [Improve] Update push.js to the latest (prevents addeventlistener error) (ref (https://github.com/elkarte/Elkarte/commit/b9c8d15b3)).
- [Improve] Editor startup code (smiley box etc) moved to its own plugin to allow deferring (ref (https://github.com/elkarte/Elkarte/commit/d702a3cca)).
- [Improve] Place cursor at start of editor box when modifying a message, also move editor into view when reply / modify is used for better UI (ref (https://github.com/elkarte/Elkarte/commit/52f2321f0)).
Bugs Fixed
- [bugfix] ! listing group members failed to create a page index resulting in one long list (ref (https://github.com/elkarte/Elkarte/commit/e18635a85)).
- [bugfix] ! Do not call JS functions if its not needed/available (such as in ACP) (ref (https://github.com/elkarte/Elkarte/commit/c423ff7ce)).
- [bugfix] ! like stats was shown wrong 1-n order, improve formatting, wrong number of likes on messages (ref (https://github.com/elkarte/Elkarte/commit/a7a0e9ab4)).
- [bugfix] ! datePublished should be in ISO 8601 in the metadata for best acceptance (ref (https://github.com/elkarte/Elkarte/commit/50e042b80)).
- [bugfix] ! Prevent page jump when wizzy is on, undo enabled and QR is empty, e.g. <p><br></p> (ref (https://github.com/elkarte/Elkarte/commit/a29e1924d)).
- [bugfix] ! un-notify via guest (email link) results in an empty board name query_wanna (ref (https://github.com/elkarte/Elkarte/commit/64e4cac92)).
- [bugfix] ! Youtube thumbnail is not always at that location, update to use an oembed call to find it (ref (https://github.com/elkarte/Elkarte/commit/3096977ef)).
- [bugfix] ! Topics could be inaccessible when unsubscribe via email link was used, resulting in an error (ref (https://github.com/elkarte/Elkarte/commit/1bc9e192b)).
- [bugfix] ! Fx would throw a defer console error (ref (https://github.com/elkarte/Elkarte/commit/e8996b629)).
- [bugfix] ! Regex in re-validate mentions was using a range vs simple character (ref (https://github.com/elkarte/Elkarte/commit/743e14d68)).
- [bugfix] ! Prevent scheduled task form generating a query_see_board error, now set to deny it (0=1) if it happens (ref (https://github.com/elkarte/Elkarte/commit/277fa5951)).
- [bugfix] ! id_msg was set to late for use in signature parseBBC (addon issue) (ref (https://github.com/elkarte/Elkarte/commit/5e3f84217)).
- [bugfix] ! Drop attachments was not setting a proper response header resulting in bad XML response (ref (https://github.com/elkarte/Elkarte/commit/4e925795e)).
- [bugfix] ! Regression issue in HTML2BBC conversion due to using value which is empty. (ref (https://github.com/elkarte/Elkarte/commit/1227e2e7d)).
- [bugfix] ! Do not send PbE when its a PM warning, they cant reply anyway (ref (https://github.com/elkarte/Elkarte/commit/e87aa6586)).
- [bugfix] ! Revert smart quote removal as some old db's are still being imported/converted (ref (https://github.com/elkarte/Elkarte/commit/ff0dd64ae)).
- [bugfix] ! Allow for an empty board description (ref (https://github.com/elkarte/Elkarte/commit/79497161f)).
- [bugfix] ! Junk document header was being returned on empty html2bbc conversion and empty board description (ref (https://github.com/elkarte/Elkarte/commit/5e7bc0e0a)).
- [bugfix] ! Pull the updated combiner back to core, now allowing individual compression (ref (https://github.com/elkarte/Elkarte/commit/ee163b5a6)).
- [bugfix] ! Headers that needed updating (ref (https://github.com/elkarte/Elkarte/commit/be038ba95)).
- [bugfix] ! Install/update changes for 1.1.10 (ref (https://github.com/elkarte/Elkarte/commit/7e0369f7b)).
- [bugfix] ! Special case for fatal error template so its output properly (ref (https://github.com/elkarte/Elkarte/commit/6af71d41b)).
- [bugfix] ! use BETWEEN just so its not a hideous >= <= construct (ref (https://github.com/elkarte/Elkarte/commit/6d31a78c3)).
- [bugfix] ! Support various ways to chmod 0755 755 '0755' '755' due to php typecast (ref (https://github.com/elkarte/Elkarte/commit/57658cf90)).
- [bugfix] ! fix #3716 posts by guest generated a metadata error (ref (https://github.com/elkarte/Elkarte/commit/3df0e827b)).
- [bugfix] ! w/o that index search querys bound by "days" is very slow (ref (https://github.com/elkarte/Elkarte/commit/1737bfba6)).
- [bugfix] ! Prevent error log message, this function is also depreciated (ref (https://github.com/elkarte/Elkarte/commit/08468d3c6)).
- [bugfix] ! Show more quotes need to be redone on a quick modify (ref (https://github.com/elkarte/Elkarte/commit/44b38a12b)).
- [bugfix] ! Make sure html2bbc is included when it needed for inbound email (ref (https://github.com/elkarte/Elkarte/commit/c6249d2cc)).
- [bugfix] ! Can not use "row" in SELECT with newer mysql. Fixes DD sorting with smileys (ref (https://github.com/elkarte/Elkarte/commit/eb1e97622)).
- [bugfix] ! Make sure getloadavg returns something useful (ref (https://github.com/elkarte/Elkarte/commit/79b2f54fb)).
- [bugfix] ! Point to the theme / addons sites (ref (https://github.com/elkarte/Elkarte/commit/1c4ea5822)).
- [bugfix] ! fix #3709 the return value of strpos() should always be explicitly checked (ref (https://github.com/elkarte/Elkarte/commit/604974285)).
- [bugfix] ! fix #3710 Double $txt['mc_posts'] in ModerationCenter.english.php (ref (https://github.com/elkarte/Elkarte/commit/437f7a125)).
- [bugfix] ! Improve the no menu by checking for function as well. This due to routing from moderation areas (ref (https://github.com/elkarte/Elkarte/commit/3583d6568)).
- [bugfix] ! var was being added to late for use in ajax header (ref (https://github.com/elkarte/Elkarte/commit/3b13a2bdf)).
- [bugfix] ! Need to output any js vars as well for pre/post (ref (https://github.com/elkarte/Elkarte/commit/ff4467ecc)).
- [bugfix] ! Consolidate quote trimming function to single area (ref (https://github.com/elkarte/Elkarte/commit/11228e8d9)).
- [bugfix] ! Admin settings for site time format were not being honored (ref (https://github.com/elkarte/Elkarte/commit/5ed113e3c)).
- [bugfix] ! Edit all option in board permissions was not working (ref (https://github.com/elkarte/Elkarte/commit/a3c3f8051)).
- [bugfix] ! fix #3703 missing language string (ref (https://github.com/elkarte/Elkarte/commit/f9b7d0fb0)).
- [bugfix] ! fix #3702 cursor can be trapped in quote/code block (ref (https://github.com/elkarte/Elkarte/commit/da316e6fc)).
- [bugfix] ! fix #3701 Guest verification search never passes (ref (https://github.com/elkarte/Elkarte/commit/fdabdd32b)).
- [bugfix] ! upgrading from 1.0.x to 1.1.x was not properly working (ref (https://github.com/elkarte/Elkarte/commit/e3ad51ce1)).
PHP 8.x updates
- [8.x] ! PHP.2 depreciation sending non countable (ref (https://github.com/elkarte/Elkarte/commit/3d742738d)).
- [8.x] ! mb_strlen(): Passing null to parameter #1 ($string) of type string is deprecated (ref (https://github.com/elkarte/Elkarte/commit/5581830df)).
- [8.x] ! Depreciation notice raised when creating a page index. (ref (https://github.com/elkarte/Elkarte/commit/273568c08)).
- [8.x] ! Custom field check exception with wrong value count sent to vsprintf (ref (https://github.com/elkarte/Elkarte/commit/af3e6b9e0)).
- [8.x] ! Prevent warning on null object in strtolower (ref (https://github.com/elkarte/Elkarte/commit/19a32074b)).
- [8.x] ! BB issue with newer 8.x version of PHP (ref (https://github.com/elkarte/Elkarte/commit/9f180f468)).
- [8.x] fix #3700 Error when adding PM rules on php 8.2 (ref (https://github.com/elkarte/Elkarte/commit/52aae3abf)).
- [8.x] fix #3715 uninitialized array (ref (https://github.com/elkarte/Elkarte/commit/8e6ea8ee9)).
- [8.x] ! Another little 8.x bump in the road, improper variable initialization (ref (https://github.com/elkarte/Elkarte/commit/724020c36)).
- [8.x] ! fix #3706 edit all option in board permissions was not working (#3706) (ref (https://github.com/elkarte/Elkarte/commit/036d66ee9)).
- [8.x] ! There is irony that the error class has an error (ref (https://github.com/elkarte/Elkarte/commit/d7816baae)).
Great but there is no package to test yet?
Guessing by his post, not yet. :wink:
I read that but this is a formal release note thread so I imagine a test package if not a ready package is attached but there is none so I asked.
I'll have one up today ... I had intended to put "preliminary" in the subject but .... :cry:
Here is the patch file that you can run on Elk 1.1.9 via the package manager.
Just to note, it adds a new index to the messages table, so if you have a large forum (400k+ messages) this can take some time and you run the risk of a timeout. Its not critical to have this new index and one could add it with phpmyadmin or good old CLI. I'll look to make that an optional step for those with larger forums.
As always, do this on a backup of your site :head_bandage: :hammer:
Thanks a lot. I will be testing it with php8.3 since its the latest.
Cool .... I've not done any 8.3 testing so I'd be interested to hear your findings.
I did find another 8.x typecast error buried deep in the code that I'll add in 1.1.10 final
Be sure to post the edit here, too...
I'd hate to have to uninstall/reinstall the patch....LOL
Here is an updated 1.1.10 package. It has the following changes
- fixed another php8 issue in bad behavior
- fixed a php8 depreciation notice in spider stats
- fixed gibberish being returned for an empty new board description
- added option to move crawlers into the restrictive group which allows you to limit them to specific boards (easier than robot txt)
I'm attaching an updated GenericControls.template.php which is in your themes/default directory.
We have a behavior (due to the version of the editor we use) that causes the editor to sometimes move into view when the page loads, and sometimes not, its a bit complicated with browser and editor plugins interaction .... and you probably don't even notice :D
Moving the editor into view, I think, is a generally nice. There are some places where you don't want that to happen, for example quick reply or a comments box below an article as those are not the focus of the page, but modify or reply I think it makes sense.
The other behavior we have is when you go to edit a post (not quick edit but full modify) the post loads and the editor has scrolled to the bottom of the post and places the cursor there. Its not as noticeable on a short post, but if you have a long post its obvious.
Attached is a proposal that will fix/standardize both behaviors. The editor will load the message to modify and begin at the start of the message, not the end. It will also move the editor to the page top (modify/reply/etc) since that is the focus of what you are doing. So give the below a try, its just one file, save your old one so you can revert, and let me know what you think :thinking:
ETA its in the latest patch file attached in a later post
Seems like a go, to me.
I like the new behavior.
The jumping to the end on modify, was really annoying. :tongue:
Unfortunately, I do not have a test environment to test this update :embarrassed:
which is the suggested version to use with elkarte 1.1.10? IIRC it was 8.1 not 8.2.
It should run fine under either ... I've been doing all my testing under 8.2 just to try and stay ahead of things.
Seems like 8.2 will trigger more deprecation notices than 8.1, but it could simply be things I missed in 8.1 and 1.1.9 :zipper_mouth:
I've been testing 1.1.10 for a few days and have found a few more 8.2 glitches, but not many, and certainly in remote areas.
All php8 including 8.3 should be usable on 1.1.10.
LOL yeah, I only just noticed it and was like, what the heck, why is it doing that !
I never thought the day would come that PHP would be changing faster than the software running on it.
Yes I agree it should, but I've not been testing on it :frowning_face: My dev site is 8.2 and the sites I run are on mostly on 8.2 with a few still back on 7.4 :shushing_face:
Here is a yet another updated 1.1.10 package. It has the following changes from the last one
- Prevent a few more PHP 8.2 depreciation notices that I was able to find
- Scroll editor to page top when using reply/modify/etc
- Move a couple of editor startup functions to the ready event in the moveto plugin
- When editing, ensure the editor view starts at the top the text not the bottom
- Pagination was not honored when viewing a list of members in a member group (the entire list was shown)
- Prevent a deferred error in FireFox with the editor custom tags
- Do not call JS functions when they are not available (seen only as a console error in the ACP)
I've been running the previous patch on a few low traffic sites, and this addresses anything (php) that I saw in the error log
ETA: This version of the patch file has been removed, be sure to uninstall it when the final is released :wink:
Welp :punch: :punch: :head_bandage:
Found a couple of more minor things that I have fixed.
Like Stats:
- Was showing the top 10 most liked posts, but not in 1-N order, was also showing the count wrong due to wrong value used in template
- Was not formatting numbers so you would end up with 1234 and not 1,234 or 1.234
- Was showing the wrong number of likes on a topic, it had the right number but wrong value was used in the template
Structured Data
- Saw a google suggestion that the Datetime property was missing a timezone. In some more reading that should have been set as ISO8601 or YYYY-MM-DDTHH:MM:SS+00:00 so now it will be.
I found and fixed/enhanced a couple of other things. Not sure anyone really cares to read these on-going pre-release updates :man_shrugging: so I'll save myself some time and simply note them in the final release notes.
But yes. Thanks for your work! :thumbsup:
Been running 1.1.10 live on a few sites, monitoring for any issues.
I made one update today, not really a bug, but an inconsistency that you I could only see when running an addon. It was one of those non-bugs that took 10x as long to figure out as a real bug LOL
Anyway I think its getting close to packing this up as in on my test sites I'm not seeing any errors (well other than users who can't remember their passwords LOL)
Not sure if you noticed this, but after this version of the patch, I make a new board and add description, but for some reason, the description vanishes. As if never entered. Confirmed this on 3 sites. No errors in the log.
Seems like there's something missing when saving, that does not include the description.
I see that as well ... fixed on my local, it was a side effect of the fix when no description was given. I've test all the combos I could think of this time and it will be fixed in 1.1.10 final.
Thanks for the report
Sounds like my kind of fix - compensate for a "no description" situation and then make everything "no description." Voilla! 😛
(I had a foreman who the business owner decided needed some formal management training, and the next "course" segment available for him to attend was "Dealing With Problem Employees". It was the only management course he ever took, and from then on his management approach was to turn every employee into a problem employee so he knew how to manage them.)
It kind of made sense when I typed it in last night LOL :tongue: