ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: TestMonkey on December 07, 2012, 02:31:50 pm

Title: attachmentz
Post by: TestMonkey on December 07, 2012, 02:31:50 pm
;D
Title: Re: attachmentz
Post by: TestMonkey on December 07, 2012, 07:05:15 pm
:-\ attach....

# enable extensive checks
# attach a file that will fail

=> error message (expected)
=> the post went through... (unexpected)
Title: Re: attachmentz
Post by: TestMonkey on December 07, 2012, 07:07:45 pm
without extensive checks.
Title: Re: attachmentz
Post by: Spuds on December 09, 2012, 12:51:59 pm
Quote from: TestMonkey – :-\ attach....

# enable extensive checks
# attach a file that will fail

=> error message (expected)
=> the post went through... (unexpected)
Yes ... interesting that ... the error page that shows up with continue / back on an attachment error is after the system has posted whatever it could ... continue and you are done, back and you are modifying an existing message.

So now with an attachment error you do not loose your post but something does not seem quite right ....
Title: Re: attachmentz
Post by: emanuele on September 23, 2013, 04:01:22 pm
I think the reason is/was that the checks on the attachments are done after the message is saved.
Now the checks are all done before, but the errors are added after, so now I'm trying to fix the behaviour.
Title: Re: attachmentz
Post by: emanuele on September 25, 2013, 04:02:09 pm
https://github.com/elkarte/Elkarte/pull/832
Title: Re: attachmentz
Post by: Spuds on September 25, 2013, 06:23:23 pm
Holy crap, look at all those PR's ... your a wildman ... and I like it !
Title: Re: attachmentz
Post by: emanuele on September 25, 2013, 06:30:07 pm
/me feels we need more tests... lol

...but then we should run them and fix the bugs...nahh let's go on like that for another wile. :P