ElkArte Community

General => Showcase => Topic started by: Frenzie on April 12, 2016, 03:40:07 pm

Title: The DnD Sanctuary
Post by: Frenzie on April 12, 2016, 03:40:07 pm
Right, so I migrated. Have a look-see if you want. ;)

http://thedndsanctuary.eu
Title: Re: The DnD Sanctuary
Post by: Spuds on April 12, 2016, 04:37:35 pm
Looking good !! 
Title: Re: The DnD Sanctuary
Post by: meetdilip on April 12, 2016, 05:09:39 pm
Quote from: Frenzie – Right, so I migrated. Have a look-see if you want. ;)

http://thedndsanctuary.eu

Congrats.
Title: Re: The DnD Sanctuary
Post by: emanuele on April 13, 2016, 02:06:53 am
Great to hear! :D
Title: Re: The DnD Sanctuary
Post by: Frenzie on April 13, 2016, 06:28:53 am
Thanks! :)
Title: Re: The DnD Sanctuary
Post by: radu81 on April 13, 2016, 08:19:37 am
I like it  ;)  your first impressions? or better impression from your users? There is something they miss from the old forum?
Title: Re: The DnD Sanctuary
Post by: Frenzie on April 13, 2016, 09:55:41 am
It's not that different from SMF. ;) Mostly it's just nice that mobile works out of the box without any effort. What I'm missing? Essentially all of the add-ons I've posted are the answer to that question, except obviously I made sure those features weren't missing prior to actually migrating. Besides that, the built-in Bad Behavior doesn't seem to have an option to set your honey pot link. Also there's no Stop Forum Spam mod, but I've got permission to port Stop Spammer. I despise CAPTCHAs and SFS is really good at catching the few bots that get through the cracks of your security questions when you do without a CAPTCHA.
Title: Re: The DnD Sanctuary
Post by: radu81 on April 13, 2016, 03:12:24 pm
I agree is not different from smf, but some people don't love changes :)
I don't have problems with spammers and imo Bad Behavior works fine in elkarte, I see 1059 elements blocked in the last 7 days. There is almost a year since no spammer register on my forum, probably because I am using questions and answers in italian.

I don't know if it worth the effort to port Stop Forum Spam to elkarte since nobody here complained abut spam users, but that's your choice ;)

QuoteMostly it's just nice that mobile works out of the box without any effort.
that was also the main reason for me too
Title: Re: The DnD Sanctuary
Post by: emanuele on April 13, 2016, 03:49:32 pm
The more the better, isn't it? ;D
Title: Re: The DnD Sanctuary
Post by: Frenzie on April 13, 2016, 03:50:46 pm
Apparently there are some issues with the autoembed (http://thedndsanctuary.eu/index.php?topic=2348.msg54182#msg54182), though it's unclear to me what they might be.

Bad Behavior is great of course, but in my experience it's more effective against what amounts to DOS attacks (bots racking up all your CPU and bandwidth by stupidly trying the registration page over and over again) than against slightly more sophisticated spam that actually manages to register. Questions work alright but they're no panacea. I suppose it helps to have a language other than English.

SFS comes in after something got through the initial defenses. The cream of the crop of Russian spam, in other words. Bad Behavior + SFS == as good as no spam at all.
Title: Re: The DnD Sanctuary
Post by: emanuele on April 13, 2016, 05:59:43 pm
hmm... the one in reply 68 (http://thedndsanctuary.eu/index.php?topic=2348.msg54193#msg54193) works fine for me on SeaMonkey 2.40, FF 45.0 and Opera 12.16 (all of them on Linux).

Maybe, ask him to try if this one works: http://www.elkarte.net/community/index.php?topic=2604.0
Title: Re: The DnD Sanctuary
Post by: Frenzie on April 14, 2016, 02:41:48 am
That one is video-BBC. This one (http://thedndsanctuary.eu/index.php?topic=2348.msg54180#msg54180) is the Elk JS. There must be some relation to the JS insertion, except that it shouldn't really be any different from just sticking an IFRAME directly into the HTML.

PS Real Opera ftw \m/
Title: Re: The DnD Sanctuary
Post by: Frenzie on April 14, 2016, 04:38:52 am
Apparently the [shadow] tag is being missed. I see the culprit (https://github.com/elkarte/Elkarte/pull/1240). :P

@emanuele
The autoembed isn't working on this site either
Quote from: http://thedndsanctuary.eu/index.php?topic=2348.msg54237#msg54237@Frenzie    No....same as before...Times out on every browser I try (FF 3 versions, Chrome 2 versions, Qupzilla, Avant, IE, Palemoon, & this go round Otter got Error 99)...does not work on any of my browsers unless I click the upper left link above the image that says YouTube video:, but that opens a new tab, takes me to youtube.com, & there & only there will it play the video.

JFYI.....when I hover the image I do see the proper url to the video. Hope that helps you.
Title: Re: The DnD Sanctuary
Post by: emanuele on April 14, 2016, 05:25:42 am
That means it's not a bug in your addon... :P

Never used any Opera after 12.16! xD

Quote from: Frenzie – The autoembed isn't working on this site either
And that exhausts all the ideas for me. LOL

If it is only him, I'm close to think it's something on his end (maybe a domain blocked for some reason?), if someone else is able to replicate it and we can have an idea of what is going on, then it may be easier to debug.
Title: Re: The DnD Sanctuary
Post by: Frenzie on April 14, 2016, 08:05:57 am
Closer inspection of the DOM shows there is in fact a slight difference.

Mine, based on what you got when clicking "embed" in YouTube a few years back. It still seems to be the same today (should have a class or inline max-width actually)
Code: [Select]
<iframe src="//www.youtube.com/embed/6h_GChgSv_A" allowfullscreen="" width="560" height="315" frameborder="0"><a href="http://www.youtube.com/watch?v=6h_GChgSv_A" target="_blank" class="new_win">http://www.youtube.com/watch?v=6h_GChgSv_A</a></iframe>

Elk (note the lack of www)
Code: [Select]
<iframe style="max-width: 98%; max-height: auto;" src="//youtube.com/embed/6h_GChgSv_A?rel=0&amp;autoplay=1" allowfullscreen="" width="640px" height="385px" frameborder="0"></iframe>

That automatically redirects you

Code: [Select]
$ curl -v http://youtube.com/embed/6h_GChgSv_A
*   Trying 194.78.0.167...
* Connected to youtube.com (194.78.0.167) port 80 (#0)
> GET /embed/6h_GChgSv_A HTTP/1.1
> Host: youtube.com
> User-Agent: curl/7.47.0
> Accept: */*
>
< HTTP/1.1 301 Moved Permanently
< Date: Thu, 14 Apr 2016 12:03:53 GMT
< Server: gwiseguy/2.0
< Location: http://www.youtube.com/embed/6h_GChgSv_A
< Content-Length: 0
< Content-Type: text/html
< X-XSS-Protection: 1; mode=block
<
* Connection #0 to host youtube.com left intact

I'll send a PR to fix this up, but a useless redirect is just a minor detail you shouldn't even notice.
Title: Re: The DnD Sanctuary
Post by: emanuele on April 14, 2016, 08:23:29 am
Considering both of them are broken for SmileyFaze, indeed just a minor make-up.
For completeness' sake, ask him to try this one as well: http://www.elkarte.it/testembed.html
There are 4 variants (with and without https and www), it would be useful to know if he is able to open all of them or only some (and which ones in case).
Title: Re: The DnD Sanctuary
Post by: Frenzie on April 14, 2016, 08:52:10 am
Hm? The first (with www) isn't broken; it's just unclear yet whether the second is broken due to DOM insertion or lack of www. :P Your second is the one that's been proved to work, but your testcase will hopefully shed some light on the situation.

I'd figure it's probably something like noscript or adblock opposing the redirect for some reason, if it weren't that it seems to happen in all browsers.

PS It's preferable not to use quirksmode for testcases. ;)
Title: Re: The DnD Sanctuary
Post by: emanuele on April 14, 2016, 11:39:57 am
/me was just utterly lazy... O:-)
Title: Re: The DnD Sanctuary
Post by: Frenzie on April 14, 2016, 12:03:24 pm
The effort of adding <!DOCTYPE html>. Oh, the humanity! :P

Btw, I noticed that although simple HTML works, it seems to be broken in some older posts.

http://thedndsanctuary.eu/index.php?topic=150.msg7555#msg7555
http://thedndsanctuary.eu/index.php?topic=79.msg15921#msg15921
http://thedndsanctuary.eu/index.php?topic=300.msg47604#msg47604

Checking in the DB

Old post:
Code: [Select]
This might be worth a try. The rules are simple: post a nice random picture or illustration.<br><br>I'll start with one for jax: [url=https://www.behance.net/gallery/Year-of-the-Horse/13678495]the year of the horse[/url].<br><br>&lt;img src="http://polymathicmonkey.smugmug.com/Frans/Random/n-6nZJF/i-R5JHwp8/0/S/year-of-the-horse-on-behance-S.jpg"&gt;

Repost:
Code: [Select]
This might be worth a try. The rules are simple: post a nice random picture or illustration.<br /><br />I'll start with one for jax: [url=https://www.behance.net/gallery/Year-of-the-Horse/13678495]the year of the horse[/url].<br /><br />&lt;img src=&quot;http://polymathicmonkey.smugmug.com/Frans/Random/n-6nZJF/i-R5JHwp8/0/S/year-of-the-horse-on-behance-S.jpg&quot;&gt;

The <br /> makes no difference. The key is in the unencoded quotation marks.

Now I just need to capture them all… this'll probably do.[1]
Code: [Select]
SELECT *  FROM [icode]elkdnd_messages[/icode] WHERE [icode]body[/icode] LIKE '%src="%' OR [icode]body[/icode] LIKE '%href="%'

And then to convert them somehow, but without overreaching.

Edit: submitted as #103 (https://github.com/OpenImporter/openimporter/issues/103).
Title: Re: The DnD Sanctuary
Post by: Frenzie on April 15, 2016, 06:21:24 am
@emanuele Yup, it's the redirect. First and second are working, third and fourth are not.
Title: Re: The DnD Sanctuary
Post by: emanuele on April 15, 2016, 07:16:04 am
Interesting... well, at least it's easy to fix. :P

/me tracks to backport to 1.0.8 if even released
Title: Re: The DnD Sanctuary
Post by: Frenzie on April 16, 2016, 05:23:46 am
@emanuele I asked him to go to youtube.com and www.youtube.com to confirm once again what I had already deduced. I can only assume it must be nameserver related, but I shouln't bother him any further. :P (Besides, what does one type on Windows instead of dig domain? Does some version of host exist there? :P)