ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: Jorin on November 16, 2015, 01:22:32 am

Title: [1.0.5] theme bug with hamburger image?
Post by: Jorin on November 16, 2015, 01:22:32 am
I installed 1.0.5 yesterday and today I find this. I am using a custom css file for my theme. I have this problem in both of my forums, and I'm browsing them with IE now. You can check here:

http://support.elkarte-hilfe.de/index.php/topic,2.0.html

It seems my custom css is missing something what's coming with 1.0.5? If so, maybe we have to find a way for future releases to prevent such problems when somebody is using a custom css file? If there is a way...  :-\
Title: Re: [1.0.5] theme bug with hamburger image?
Post by: emanuele on November 16, 2015, 08:40:38 am
The problem is you have to update the index.css of your theme with he few changes done to bring that little button there, so: first this (https://github.com/elkarte/Elkarte/commit/559b0cc4f521ab8198f09b9c6f7127e15c02dcce) and then this (https://github.com/elkarte/Elkarte/commit/18b0fcd5bc95ca62bab3209e5834875d13af6dde).

Odd Elk didn't try to install to the custom theme... or maybe the changes to custom themes have to be explicitly approved? I never tried, I should... :-[
Title: Re: [1.0.5] theme bug with hamburger image?
Post by: Jorin on November 16, 2015, 08:55:56 am
I had some error messages with the custom theme while the update proccess. As usual I ignored them. My own fault.  O:-)  But I don't know why the package manager can't insert the new code into the custom css file.

I will try to fix it the next days. I am really busy this week. Thanks for pointing me in the right direction!  :)
Title: Re: [1.0.5] theme bug with hamburger image?
Post by: emanuele on November 16, 2015, 05:14:40 pm
I didn't use custom for a couple of reasons: 1) it may not be there, 2) it may already contain something that could override "core" declarations (even though that last one, for a new "feature" doesn't really make sense O:-)).
Title: Re: [1.0.5] theme bug with hamburger image?
Post by: ahrasis on November 16, 2015, 07:18:25 pm
Quote from: Jorin – But I don't know why the package manager can't insert the new code into the custom css file.
I remember it was pointing me to that with error, so I did it manually. But the Display.template.php fixes, I can't remember I was warned. Anyway, thanks for pointing that @emanuele .
Title: Re: [1.0.5] theme bug with hamburger image?
Post by: Jorin on November 30, 2015, 10:38:18 am
Another problem with this: When I click on the button on my smartphone the button disappears and nothing else is happening.
Title: Re: [1.0.5] theme bug with hamburger image?
Post by: wintstar on November 30, 2015, 12:03:03 pm
For me it works in all Themes.

http://elkarte.scaricare.de/index.php?action=forum
Title: Re: [1.0.5] theme bug with hamburger image?
Post by: radu81 on November 30, 2015, 02:31:47 pm
it works because you are an admin or a moderator.

I just tryed on my forum with a normal account and I can confirm what Jorin said:

 
Quote from: Jorin – Another problem with this: When I click on the button on my smartphone the button disappears and nothing else is happening.

Imo should be disabled for normal users ;)
Title: Re: [1.0.5] theme bug with hamburger image?
Post by: scripple on November 30, 2015, 04:07:23 pm
Is this any different than what I reported before and is already being tracked?

http://www.elkarte.net/community/index.php?topic=2997.0
Title: Re: [1.0.5] theme bug with hamburger image?
Post by: Jorin on December 01, 2015, 01:17:50 am
No, not different, it's the same. Sorry. I missed your topic.  O:-)
Title: Re: [1.0.5] theme bug with hamburger image?
Post by: wintstar on December 01, 2015, 04:29:03 am
Have you loaded a .css from Bootstrap?


Title: Re: [1.0.5] theme bug with hamburger image?
Post by: Jorin on December 01, 2015, 06:02:58 am
As this is happening here, @emanuele should answer this.  ;)
Title: Re: [1.0.5] theme bug with hamburger image?
Post by: wintstar on December 01, 2015, 06:48:13 am
You have on your board the same problem
Title: Re: [1.0.5] theme bug with hamburger image?
Post by: Jorin on December 01, 2015, 07:06:39 am
I haven't made the changes @emanuele posted here till now:

Quote from: emanuele – The problem is you have to update the index.css of your theme with he few changes done to bring that little button there, so: first this (https://github.com/elkarte/Elkarte/commit/559b0cc4f521ab8198f09b9c6f7127e15c02dcce) and then this (https://github.com/elkarte/Elkarte/commit/18b0fcd5bc95ca62bab3209e5834875d13af6dde).

Odd Elk didn't try to install to the custom theme... or maybe the changes to custom themes have to be explicitly approved? I never tried, I should... :-[

The problem posted here:

Quote from: Jorin – Another problem with this: When I click on the button on my smartphone the button disappears and nothing else is happening.

...is another one with the button. I think.  ;)
Title: Re: [1.0.5] theme bug with hamburger image?
Post by: wintstar on December 01, 2015, 08:07:39 am
In my ElkArte demo board works the hamburger menu. That's why I do not understand it why it does not work here and in your board.
Title: Re: [1.0.5] theme bug with hamburger image?
Post by: Jorin on December 01, 2015, 08:56:43 am
Maybe my custom.css is the problem at my board(s). But why do I have the problem here? I am sure here is no custom.css involved.
Title: Re: [1.0.5] theme bug with hamburger image?
Post by: wintstar on December 01, 2015, 08:59:44 am
No, i think here is another problem. (http://www.elkarte.net/community/themes/default/css/custom.css)


Title: Re: [1.0.5] theme bug with hamburger image?
Post by: emanuele on December 09, 2015, 04:31:24 pm
You are missing a couple of pieces, well, more than just two, but I'm not entirely sure which one are really missing, so I'll send you the file with the minimum amount of changes.
The problem is not with your custom.css because there is no custom.css around. If you used a custom.css probably there was no issues, but that's another story. ;)
Title: Re: [1.0.5] theme bug with hamburger image?
Post by: Jorin on December 10, 2015, 12:56:05 am
There is no custom.css? There should be, in bluesky/css/light.  :o
Title: Re: [1.0.5] theme bug with hamburger image?
Post by: emanuele on December 10, 2015, 02:11:45 am
But that's just for the "variant", and it's just colors in fact. ;)
I was talking about the "main" css, index.css.
Title: Re: [1.0.5] theme bug with hamburger image?
Post by: Jorin on December 10, 2015, 02:24:30 am
Hm, I thought the custom.css must be in the variant folder? I only have one there. Is this a mistake?

Edit: And in this custom.css I have only the codes I changed, not all. A second mistake?
Title: Re: [1.0.5] theme bug with hamburger image?
Post by: emanuele on December 10, 2015, 08:22:46 am
custom.css can be used both at "theme level" and "variant level", so you can have a custom.css in the same directory as index.css and it will work, and you can have a custom_variantname.css in your _variantname directory as you have.
You can have both.

In the custom css files there shall be only the changed code, it would be pointless to replicate the whole css. ;)
Title: Re: [1.0.5] theme bug with hamburger image?
Post by: Jorin on December 10, 2015, 08:26:28 am
Hm, then I made everything correct.  :)

Okay, another idea. What do you think is the best way to change some colors?

1. Use the default theme and change the css files? Save them, so when the default theme is updated, I can overwrite the css files with my own? I will then have the problem of using old css files, missing codes in them, etc.

2. Use the custom css files, but with less codes?

Any other idea?
Title: Re: [1.0.5] theme bug with hamburger image?
Post by: emanuele on December 10, 2015, 08:37:31 am
I'm a bit in a hurry so I'll be short: the best way is not to change default things.

If you want to change colors to your own theme, do what you are already doing: edit the custom.css file.
If you want to change colors of the default theme, create a custom css file and put it in the default theme.
In both cases, the custom css will override the default one and the theme will show the new colors and not those of the default theme.

Quote from: Jorin – Hm, then I made everything correct.  :)
So you didn't change anything on purpose in your index.css compared to the default one?
If so, just pick the attached file (index.css from elk 1.0.5) and overwrite the one in your theme directory.
This will likely fix any issue so far (except for one that is planned to be fixed in 1.0.6).
Title: Re: [1.0.5] theme bug with hamburger image?
Post by: Jorin on December 10, 2015, 08:45:34 am
I changed a few little things in index.css, I didn't know I can use a custom file there too. I will keep my changes in a custom index.css in the future. If I remember right, I kept a notice what I changed in this file.

Thank you very much!