ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: NetFlag on November 28, 2013, 03:40:13 am

Title: Post moderation failed to guests
Post by: NetFlag on November 28, 2013, 03:40:13 am
Hello again!  ;)
Permissions set to:
Post new topics, but hide until approved [checked]
Post replies to topics, but hide until approved [checked]

Works fine for registered users!
For guests, only new topics works as well. Replies can not post. ElkArte ignore the permission set in ACP and replies the LoginBox.

Regards
NetFlag
Title: Re: Post moderation failed to guests
Post by: emanuele on November 28, 2013, 05:56:53 am
mmm...again that one with guests...

Thanks for the report! ;D
Title: Re: Post moderation failed to guests
Post by: NetFlag on November 28, 2013, 02:52:19 pm
Looks like its not a problem of the masses. For me it is an importend feature. So its one of the first things I have to check out.

Regards
NetFlag
Title: Re: Post moderation failed to guests
Post by: emanuele on November 28, 2013, 03:14:05 pm
I tried quickly to replicate it a few moments ago, but I was not able to.
As a guest I was able to post and the message appeared as unapproved...

I have to do some more tests.
Title: Re: Post moderation failed to guests
Post by: NetFlag on November 29, 2013, 01:37:00 am
Hey emanuele,
to reproduce create a new thread as a guest. Then try to reply. No go.
I should become something more precise. Sorry!
Title: Re: Post moderation failed to guests
Post by: emanuele on November 29, 2013, 07:32:04 am
Ahhh.... right, now I remember it!

Yes, it's still the one I was thinking about, I didn't remember exactly how to trigger it.
By chance did you use the post moderation page to set your permissions or the permissions page? (Yeah, I know, too many pages... :-\)
Title: Re: Post moderation failed to guests
Post by: NetFlag on November 29, 2013, 07:40:42 am
In post moderation page there is no option for guests. Only Global Moderator and Moderator. ElkArte != SMF. ;)
Title: Re: Post moderation failed to guests
Post by: emanuele on November 29, 2013, 08:41:14 am
Then that was another bug... (Fixed in the meantime)

About the main bug, here it is the fix:
https://github.com/emanuele45/Dialogo/commit/a5225a6d1f30166611b4ca196c7c2552e287b5c9

That piece of code is not exactly wonderful to read... :P