Package Manager - Current/Older version icons not displayed January 31, 2016, 07:43:50 pm Package Manager/Browse Packages/Add-on packages> bottom right of table shows the 'current version' and 'older version' .png icons but the icons are not displayed next to the packages. The Installed Packages table does not show any icon for current or older.I would have thought there be three icons to show the state of the packages; current/installed, older, and uninstalled icon as well?
Re: Package Manager - Current/Older version icons not displayed Reply #1 – February 02, 2016, 09:45:17 pm @emanuele
Re: Package Manager - Current/Older version icons not displayed Reply #2 – February 03, 2016, 02:40:38 am I cannot properly test it right now because pacman is behaving like a dumb on my setup... I have to understand if something is badly broken or it's just a matter of mixing broken packages, directory, symlinks all in one place.ETA: anyway, just to clarify, the icons should show up only if the same package is uploaded more than once and the two versions are different. Pacman is not checking "remotely" if the package is outdated. At least not for now.
Re: Package Manager - Current/Older version icons not displayed Reply #3 – February 03, 2016, 06:34:23 pm Hmmmm .... well in that case maybe the bug is between my ears. I have Miserable User installed and did a test upload of the package again. Must be the same versions as I were presented with an error stating the file already existed on the server and should be deleted...etc. Probably not a bug at all and more my not being clear on the intent of the icons. Probably confusing it with an SMF mod for icons for installed/uninstalled packages. Sorry for the bother.
Re: Package Manager - Current/Older version icons not displayed Reply #4 – February 03, 2016, 10:18:27 pm QuoteETA: anyway, just to clarify, the icons should show up only if the same package is uploaded more than once and the two versions are different. Pacman is not checking "remotely" if the package is outdated. At least not for now.Thats my understanding of those esoteric icons as well ... For remote checking, part of that was implemented in the "package server" code. If you go to package servers (in your admin panel) and select Browse next to the ElkArte Third-party Add-ons Site .... Then you should see red dots next to packages that you have installed that are older than whats currently available on the Add-on site. That code is not perfect as it relies on the data in the package descriptions on the Addon site being correct and updated when the package is updated (meaning its up to the package maintainer to do it right or do it at all)
Re: Package Manager - Current/Older version icons not displayed Reply #5 – February 04, 2016, 06:07:50 pm Quote from: Spuds – February 03, 2016, 10:18:27 pmQuoteETA: anyway, just to clarify, the icons should show up only if the same package is uploaded more than once and the two versions are different. Pacman is not checking "remotely" if the package is outdated. At least not for now.Thats my understanding of those esoteric icons as well ... For remote checking, part of that was implemented in the "package server" code. If you go to package servers (in your admin panel) and select Browse next to the ElkArte Third-party Add-ons Site .... Then you should see red dots next to packages that you have installed that are older than whats currently available on the Add-on site. That code is not perfect as it relies on the data in the package descriptions on the Addon site being correct and updated when the package is updated (meaning its up to the package maintainer to do it right or do it at all)Ahhhh .... I see now. The only red dots that showed up were for the Avatars from BKE and they referenced a GitHub download; though the versions were the same on GH and my site.Which leads me to this .... The icons are always shown on the first tab, Browse Packages; but are used only on the third-party add-on drop down. Should these icons even be shown on the first tab then as they reference no information there?Incidentally, your Miserable User add-on did show up but it had no green or red icon next to it.
Re: Package Manager - Current/Older version icons not displayed Reply #6 – March 02, 2016, 11:59:32 am Finally I'm back to this !First an important note, those icons and the download link will "miss" from time to time, nature of the beast I'm afraid. Its dependent on the data it gets from the addon site, which is dependent on the data from the authors, which is dependent on how much sleep or alcohol they consumed when they submitted the PR.So with the intro out of the way .... I do see an improvement opportunity (sounds better than bug) on matching versions, so I'll get that fixed. There are also some inconsistency / gaps in the UI / Icons which we should clean up. So my proposal is the following:Addon Site Version [1]Installed VersionNot Installed but Downloaded VersionNot DownloadedCurrentCheck mark/ No Button[2]Green Dot / Disabled ButtonDownload ButtonOldCheck mark / No Button[3]Green Dot / Disabled Button Download ButtonNewGreen + / DL Button[4]Red Dot / Download ButtonDownload ButtonOther thoughts or ideas on what should be presented. Right now not all of those indicators exist but the basic information to do so does. Maybe a bouncing parrot if there is an update available Also one last question, currently the listing is sorted by last updated vs name ... what do folks prefer ?1 As compared to YOUR version ↵2 or Current Version Installed↵3 As above since what you have is newer than whats on the addon site↵4 or Update Available Button ↵
Re: Package Manager - Current/Older version icons not displayed Reply #7 – March 02, 2016, 03:44:40 pm Bouncing parrot?!?!? Did someone say bouncing parrot?
Re: Package Manager - Current/Older version icons not displayed Reply #8 – March 02, 2016, 06:08:10 pm Quote from: Spuds – March 02, 2016, 11:59:32 amMaybe a bouncing parrot if there is an update available xDQuote from: Spuds – March 02, 2016, 11:59:32 amAlso one last question, currently the listing is sorted by last updated vs name ... what do folks prefer ?I tend to prefer name. At least, if I got what we are talking about. xDAlso, it may be worth at some point, consider to "merge" the two pages: list of packages and list of installed packages. With just a tiny bit of js-trickery it would be rather easy to hide all the not installed packages and keep only the installed ones. Less code to take care of, the better!
Re: Package Manager - Current/Older version icons not displayed Reply #9 – March 02, 2016, 07:44:25 pm Last question first ..... I prefer the sort by name idea. I almost always do a lookup by the name. I like the idea of combining the Browse Packages and Installed Packages. I sort of did not really understand the need for Browse as there already is a Download Packages function/tab.Maybe something like...Package Name | Installed Version | Newest Version | Download | Install | Uninstall |Tater-Tots 1.0 2.0 <blue> <green> < red > <button> <button> <button>I like the idea of a fair amount, but balanced space between each of the buttons and for each button to have a colour. The colour buttons would be a visual cue to the hapless admin to not accidentally uninstall a package. I think it adds a nice touchy feely look to the display. I do not know that there is a need to have the word Addon(s) in the list at all. At present there is a little bit of 'wording nuance' in the heading. In this case it is Addon Packages then with a list titled Add-on Name. Where this all gets skewed is the next display is Avatar Packages with a list titled Add-on Name. Same for Smiley Packages. So, to me the first heading should not say Addon Packages but perhaps Mod Packages and a list title of Mod Name, the next heading would be Avatar Packages and a list title of Avatar Name, etc.I hope that made sense. I always look at the visual stuff from the mind of the user and look for inconsistencies in visual display, wording and meaning. So, not being critical about a previous decision but I think the wording of the packages and their heading should be more reflective of the package types themselves.Thanks!
Re: Package Manager - Current/Older version icons not displayed Reply #10 – March 02, 2016, 10:42:02 pm The installed tab is completely useless and needs to be dropped, not combined with anything IMOThe browse tab is broken and needs to be fixed, mainly those indicators don't really work The package server area is semi broken, only some of which can be addressed since we do not really control that data. I've made some fixes that I'll submit for 1.0.7. Not sure what I'll do with the indicators, mostly likely will be simple FA icons on that page.The names, description, revision levels, etc etc are defined in the package files, they are simply "reported" by the software. Ditto for the package server listing.
Re: Package Manager - Current/Older version icons not displayed Reply #11 – March 03, 2016, 07:06:45 am Quote from: derived – March 02, 2016, 10:30:49 pmlisted packages do need to have a clear description....some don't.also, package name, and listed name, aren't necessarily the sameThis is not about a 'description' in the package it self. It is about the use of accurate words from one heading to the next. Frankly, as far as package names, descriptors, and the such...I strongly believe there should be a mandatory standard required of packages so users have a thorough understanding of the package and the software handles and displays all packages the same.
Re: Package Manager - Current/Older version icons not displayed Reply #12 – March 03, 2016, 12:39:25 pm This is the current state, of the package server page.I improved some of the detection parameters so it does a better job of determining whats installed vs downloaded, and whats old vs current. If it detects you have the current version installed or downloaded, it does not present a download button. If you have it installed or downloaded and a newer version is found, you are informed with text and the download button.[1]If you don't have a copy, and it has a link for the file, you get the download button.Packages are name sorted, and added some basic column alignment1 It still says download vs update since it can't update from there ATM. Maybe in 1.1, if it was 100% hook based we could have an Update button where the old package is uninstalled, the new downloaded and installed. I have some concerns about that since we can be dealing with 3rd party sites from that interface.↵
Modern, Free, Powerful