Text only | Text with Images

ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: emanuele on August 16, 2014, 03:44:16 am

Title: DOMDocument::saveHTML()
Post by: emanuele on August 16, 2014, 03:44:16 am
Quote from: Jorin – She gets a lot of error messages in the log, I am not. Here is one of her error messages:

QuoteArt des Fehlers: Generell
2: DOMDocument::saveHTML() expects exactly 0 parameters, 1 given
http://ea.puppenstubenforum.de/index.php?action=movetopic2;current_board=2;topic=9.0
Datei: /var/www/web3/html/ea/sources/subs/Html2Md.class.php
Zeile: 355
hmm... I'll try to check but that one is probably for @Spuds.
Title: Re: DOMDocument::saveHTML()
Post by: Spuds on August 16, 2014, 06:50:20 am
POOP !

Quote5.3.6    The node parameter was added.
  :'(

I'll have to add a function to support that for versions of php < 5.3.6 ...
Title: Re: DOMDocument::saveHTML()
Post by: emanuele on August 16, 2014, 06:54:11 am
LOL

/me suggest to label the code as PHP < 5.3.6 so that we can get rid of it as soon as we go PHP > 5.3.6. O:-)

@Jorin can you ask her what version of php is she using?
Title: Re: DOMDocument::saveHTML()
Post by: Spuds on August 16, 2014, 09:04:18 am
This PR (https://github.com/Spuds/Elkarte/commit/6c627cc5d02ffa72e7cb9b0863f23bbb622c26f1) should fix those errors (assuming it was the 5.3.6 issue) ... just replace those two files with these new ones.
Text only | Text with Images