Text only | Text with Images

ElkArte Community

Elk Development => Theme development => Topic started by: AaronB on April 13, 2014, 11:57:39 am

Title: Misplaced Character in Quick Search for Logs
Post by: AaronB on April 13, 2014, 11:57:39 am
See the attached image.

Occurs in Logs>Administartion Log and Logs>Moderation Log.

The character is the vertical bar and appears to the right of the 'Go' button.

Div ID is 'quick_log_search'

Code: [Select]
<input class="button_submit" type="submit" value="Go" name="is_search">
|  

I can find it ... but I don't know how to fix it.   :D
Title: Re: Misplaced Character in Quick Search for Logs
Post by: emanuele on April 14, 2014, 09:12:53 am
On a "normal" theme it looks like the attached.
In your case it seems you added a float:left I think.

To remove the pipe char (the "|").... meh, you have to edit Modlog.controller.php, the line is:
Code: [Select]
' . ($context['can_delete'] ? '|&nbsp;

ETA: ehm... forgot the attachment... O:-)
Title: Re: Misplaced Character in Quick Search for Logs
Post by: AaronB on April 18, 2014, 08:06:06 pm
Well, that is embarassing.  :)  Yep, I am guilty of that change.  Sorry for the post.  :)
Title: Re: Misplaced Character in Quick Search for Logs
Post by: Spuds on April 18, 2014, 08:47:40 pm
Don't ask how many times we have done that before  O:-)
Title: Re: Misplaced Character in Quick Search for Logs
Post by: emanuele on May 02, 2014, 12:01:55 pm
lol
No problem, dig around and you'll find funnier things from me as well. :P
Title: Re: Misplaced Character in Quick Search for Logs
Post by: Ant59 on May 02, 2014, 03:07:03 pm
Quote from: emanuele – On a "normal" theme it looks like the attached.
In your case it seems you added a float:left I think.

To remove the pipe char (the "|").... meh, you have to edit Modlog.controller.php, the line is:

Code: [Select]
' . ($context['can_delete'] ? '|&nbsp;

ETA: ehm... forgot the attachment... O:-)

This is another thing that should not be in the controller. Theme's should be delivered with data to layout, not HTML :)

I'm slowly going through and trying to eradicate these issues when I find them :D
Title: Re: Misplaced Character in Quick Search for Logs
Post by: Spuds on May 02, 2014, 10:28:57 pm
Indeed ... find them and eradicate them ! I will not say how much has been removed to date, or how many inline styles that were removed (or how much is still left to go ! )
Text only | Text with Images