ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: Jorin on February 13, 2014, 05:09:33 am

Title: Google+ profile field
Post by: Jorin on February 13, 2014, 05:09:33 am
I think I found another one in Beta 2... Text inserted in profile field:

Quotegoogle.com/+JörgHelfmann73

URL opened in browser:

Quotehttp://fairflixxt.de/google.com/+JörgHelfmann73

(fairflixxt.de is my domain).
Title: Re: Google+ profile field
Post by: meetdilip on February 13, 2014, 05:32:44 am
I guess you need to use

Quotehttp://www.google.com/+JörgHelfmann73
Title: Re: Google+ profile field
Post by: Jorin on February 13, 2014, 05:51:15 am
Yep. Great, thanks. Shame on me.  :-[

Thought I didn't need the "http" because the Facebook profile field too needs only the facebook name, not the complete URL. So the two fields are not working the same kind of way? Maybe this should be better described.
Title: Re: Google+ profile field
Post by: emanuele on February 13, 2014, 07:21:07 am
Yep, LinkedIn and G+ are a bit inconsistent with FB and Twitter...

I'm not sure which one is better, probably the best would be to ask for the url, but "silently" (or explicitly) accept the username too for twitter and FB, something like: "URL or username of your FB/Twitter account".
I think when I wrote my SMF mod I did it that way because G+ and LI provide the full url, while FB and Twitter are more oriented towards the use of the username.

Opinions are welcome.
Title: Re: Google+ profile field
Post by: TE on February 13, 2014, 02:01:57 pm
yeah, it's somewhat inconsistent but that's the nature of those fields..
LinkedIn and G+ can have various formats ..

plus.google.com/103918273618145415664
or just google.com/+ThorstenEurich

Since you can add various other services yourself (e.g. MySpace, Xing or whatever) there's always the possibility of an inconsistency. I'd leave it as it currently is...
Title: Re: Google+ profile field
Post by: meetdilip on February 13, 2014, 07:43:06 pm
Quote from: Jorin – Yep. Great, thanks. Shame on me.  :-[

Thought I didn't need the "http" because the Facebook profile field too needs only the facebook name, not the complete URL. So the two fields are not working the same kind of way? Maybe this should be better described.

Anytime. :)

No questions are stupid, only answers are ;)
Title: Re: Google+ profile field
Post by: meetdilip on February 13, 2014, 07:46:28 pm
Quote from: emanuele – Yep, LinkedIn and G+ are a bit inconsistent with FB and Twitter...

I'm not sure which one is better, probably the best would be to ask for the url, but "silently" (or explicitly) accept the username too for twitter and FB, something like: "URL or username of your FB/Twitter account".
I think when I wrote my SMF mod I did it that way because G+ and LI provide the full url, while FB and Twitter are more oriented towards the use of the username.

Opinions are welcome.

May be we can just describe the format in which the url/username to be entered above the box.
Title: Re: Google+ profile field
Post by: Jorin on February 13, 2014, 11:43:24 pm
(Google)+1  :D
Title: Re: Google+ profile field
Post by: emanuele on February 14, 2014, 05:38:29 am
Good point, an example is usually a good thing! :D

It may (but that's more for "later") be an option to add some kind of "validation", via javascript and/or php so that "broken" fields are verified and corrected where possible, or return an error.
Title: Re: Google+ profile field
Post by: emanuele on February 04, 2015, 05:20:40 pm
To consider for 1.0.3 a little change of some text with an example?

@Jorin I just noticed the FB profile you are using here is broken, I think you used the whole url?
Title: Re: Google+ profile field
Post by: Jorin on February 06, 2015, 02:11:16 am
Quote from: emanuele – @Jorin I just noticed the FB profile you are using here is broken, I think you used the whole url?

Yep. Fixed.
Title: Re: Google+ profile field
Post by: emanuele on March 21, 2015, 09:42:34 am
Tracked: https://github.com/elkarte/Elkarte/issues/1998
Title: Re: Google+ profile field
Post by: emanuele on August 23, 2015, 08:26:03 am
I was looking into this: a little "warning" is already there:
QuoteThis is your Google+ profile url.
maybe it should be made a little more clear, something like:
QuoteEnter the full url to your Google+ profile.
does it look better?

Slightly related, the current way, in G+ and LinkedIn profiles, you can enter whatever url you want. It may be worth change the input mask from "no html" to a regexp and validate the url is actually pointing to one of the two social networks, for example for G+ it could be:
Code: [Select]
/^https*:\/\/(plus\.google\.com\/\d+|(plus\.)?google\.com\/\+.*)/
for LinkedIn it could be:
Code: [Select]
/^https*:\/\/(\w{2,4}\.)?linkedin\.com\/in\/.*/
Title: Re: Google+ profile field
Post by: Wizard on August 26, 2015, 03:52:32 am
From what I heard, Google plus is going to have the fate of Orkut. They have already detached Photos and there was a blog post from Google saying that YouTube too will be free.