ElkArte Community

Is there any way short of writing custom code to add a new button to the button array that has an onclick script instead of a link?  Or since the buttons with sub_buttons are very much select like, is there a way to make one actually be a select?  Meaning you select the option from the drop down and it changes the button name and passes a value in on submit?

It'd be possible, but with the proviso that you couldn't make it part of the array as such, AFAIK. The thing is the array is set up to deal with anchors, not onclick. What I think you would have to do is add a button outside the array, like the header upshrink. That uses onclick and is styled to look like the other buttons, but is not part of the array in Sources.

Same applies for using selects.

Perhaps the array could have an id field, then a script could be attached via an external script assigning an onclick function to a button with that id.  This would be a future change though as I don't think the array holds IDs.  Or is selecting on an href doable and reasonable?

Buttons already have id's that depend on the actions they perform. So yes, you could do it that way I suppose. I hadn't thought it through.

For instance, the "Messages" button is #button_pm. As long as an action is defined for the button, it'll get a suitable id.

It seems sub-buttons don't have id's though.  Can they if the right field is set in the array?

Dunno. Never tried it. I suppose the back end code could be tweaked so they did, if it's not allowed already. I'd suggest adding an id on a test site and seeing what happens.

Yeah I'll have to look at the array and see what field needs to be added.

Edit:  Didn't see an obvious tag in the array that creates the id on main buttons vs sub-buttons.

Maybe use the key of the array?

foreach ($button['sub_buttons'] as $child_act => $childbutton)

foreach ($childbutton['sub_buttons'] as $grandc_act => $grandchildbutton)

Can't check right now, if you confirm it works I can add it later. ;)

Works to add ids to childbuttons, not sure what buttons have grandchild buttons and have a meeting to rush off to this morning so can't do anything more but thanks for this.

Ok, I gave it a try and noticed the admin menu has 3rd level buttons.  I decided to make the ids be button_$act_$child_act, and button_$act_$child_act_$grandc_act as the odds of a name collision at that point are lower than just using one of the subvariables.

I then ran the main page through an html5 validator and it was fine.  Here's the modified code secion.

		// Any 2nd level menus?
		if (!empty($button['sub_buttons']))
		{
			echo '
							<ul class="menulevel2">';

			foreach ($button['sub_buttons'] as $child_act => $childbutton)
			{
				echo '
								<li id="button_', $act , '_', $child_act, '" class="listlevel2', !empty($childbutton['sub_buttons']) ? ' subsections" aria-haspopup="true"' : '"', '>
									<a class="linklevel2" href="', $childbutton['href'], '" ', isset($childbutton['target']) ? 'target="' . $childbutton['target'] . '"' : '', '>', $childbutton['title'], '</a>';

				// 3rd level menus :)
				if (!empty($childbutton['sub_buttons']))
				{
					echo '
									<ul class="menulevel3">';

					foreach ($childbutton['sub_buttons'] as $grandc_act => $grandchildbutton)
						echo '
										<li id="button_', $act, '_', $child_act, '_', $grandc_act, '" class="listlevel3">
											<a class="linklevel3" href="', $grandchildbutton['href'], '" ', isset($grandchildbutton['target']) ? 'target="' . $grandchildbutton['target'] . '"' : '', '>', $grandchildbutton['title'], '</a>
										</li>';

					echo '
									</ul>';
				}

Haven't attached a script to any of them yet but I don't see why it would be a problem.

In theory there shouldn't be id collision (any identical key name should be avoided because it could be a problem in future possible menu editors O:-)).
The problem with a hierarchical structure is that the moment the position of the menu is changed (for whatever reason) you have to change the the javascript too. If that is acceptable, okay we can use that. I would prefer the "simple" one (also because the IDs generated are looooooong).
Let me know. ;D

I prefer the short form too, I just wasn't sure since you hadn't been setting id's on the sub_buttons if there was any confidence they would be unique.  Since you're happier with the short form I say definitely go that way.  Especially with your point about what happens if a button moves.

And if you notice any duplicate id, feel free to report it as bug! ;D

So it seems this never made it into the baseline.  Should I assume it's been rejected?

More likely it slipped out of sight... O:-)

Fair enough.  I suppose I should figure out that github pull request thing some day.

There is a bit of a learning curve with Git, but once you get used to it, and learn to use it, its pretty powerful.  

I have not even gotten pissed off at Git in many months which is awesome  :)

Several decent free gui interfaces if you don't want to use the command line (I use TortoiseGit, and only use the command line when I need to teach Git a lesson lol)

Well I've sent git style patches to kde in the past, but that's about the limit of my use of git.

Just to follow up here,  I did submit a pull request on github to add these classes.  If you get a chance take a look and let me know if I got it right.

Yep, I've seen it. Thanks! ;D
Tomorrow I should have some free time (this week has been more busy than expected, sorry).