The entity " is getting unparsed. It should remain & quot; (without the space). Even happens in code tags.
Let me see about the other entities:
" => "
' => &apos
< => <
& => &
Yep. Quote and add the ; to test.
ehh... I never really understood why entities are translated... :-\
FYI: it isn't broken on SMF
Sigh
Yeah, we discovered this bug in a private conversation, randomly. :/
This is caused by our Utill function which set the htmlspecialchars flag to not double encode by default.
So although those characters are being saved as show meaning if you enter " ; that's what is saved in the DB, however to actually display it that way you need to do a & ;quot ; junk.
So to fix,
1) could enable double encode by default, but that gets ugly in some cases.
2) Just double encode in the preview and post areas, so in post.controller do
$form_message = Util::htmlspecialchars($_REQUEST['message'], ENT_QUOTES, 'UTF-8', true);
and
$_POST['message'] = Util::htmlspecialchars($_POST['message'], ENT_QUOTES, 'UTF-8', true);
3) Just do it for code blocks? Is there a reason to display it as the entity outside of a code block?
Not sure the answer but I know that it shouldn't just do it in code blocks.
Has this been fixed in the end? O:-)
Don't know if I got all the places, but this was the first pass ... https://github.com/elkarte/Elkarte/commit/9d412fc631e47e7b47a7e414b62b441ab756a79b
Tests?
" => "
' => '
< => <
& => &
" & < or " & <