ElkArte Community

Elk Development => Feature Discussion => Topic started by: TE on May 10, 2013, 11:49:55 am

Title: nested functions in Packages.php
Post by: TE on May 10, 2013, 11:49:55 am
Something really odd: function sort_table_first($a, $b) is defined inside public function action_install(). There are more like that in Packages.php
Technically it's allowed but do we want this? IMO it isn't really good practice..
Title: Re: nested functions in Packages.php
Post by: TestMonkey on May 10, 2013, 11:54:35 am
I tend to agree... They were probably not meant to be reused so defined where needed, but we don't need to continue the practice methinks.