Hey everyone,
A few days ago I've completed the like posts stats feature for my SMF 'Like posts' mod. Finally, it seems to reach a stable state.
I've started porting the same for elkarte as well over
here (https://github.com/siddhartha-gupta/Elkarte/tree/LikeStats). Currently, its in a broken state and I'm trying to complete it by weekend. All suggestions/advices are most welcomed.
Just a suggestion, how about adding a timestamp column in 'message_likes', as it'll help in creating more meaning full stats, like best liked message in past 1 months etc.
Makes some sense ...
@emanuele what do you think?
Guess it's possible, why not?
@Spuds @emanuele... So seems to be a change for dev branch?
I'd say yes if the intention is to make this standard in 1.1 ... I don't like adding a column this late in the game for 1.0 but if its the right thing to do for a smooth 1.1, adding a time column is safe, if just a bit messy O:-)
Missed that one, sorry! :-[
Let's say the general rule of thumb is: once in beta the db-schema should not change until final, unless something is (badly) broken.
This makes much easier testing and upgrading, also it allows to reduce the complexity of the upgrade script/s, making development easier (or at least less messy), because from one version to another there is just one step of upgrade.
Thinking about it a bit, I would say change the db schema (only adding columns though, not renaming or removing) during future patches would be acceptable.
For example for 1.0.1 that change could be added.
nods ... I was torn writing what I did.
I was thinking that without the column (unused in 1.0 but populated) would make the 1.1 update immediately useful vs full of lost stats since you can't back build that missing data. 1.01 would minimize the loss for sure and keeps 1.0 on track.
Heres the PR - https://github.com/elkarte/Elkarte/pull/1761
Just bit confused about which sql file do I need to update while updating from 1.0 to 1.0.1 :-[