Text only | Text with Images

ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: Frenzie on March 23, 2022, 03:31:33 am

Title: Quick edit fails to update text in 2.0 dev
Post by: Frenzie on March 23, 2022, 03:31:33 am
Steps:

1. Post something
2. Click quick edit
3. Make some changes, click save
4. Nothing changes until a page refresh

Expected: changes immediately
Title: Re: Quick edit fails to update text in 2.0 dev
Post by: ahrasis on March 23, 2022, 08:58:31 am
My suspect is this new quick reply as I remember my addon did have that problem.
Title: Re: Quick edit fails to update text in 2.0 dev
Post by: DeadMan on March 23, 2022, 10:24:58 am
Sounds to me like it lost the quick refresh that usually happens when you save a quick edit. Especially if it shows the changes after a refresh.
Title: Re: Quick edit fails to update text in 2.0 dev
Post by: Frenzie on March 23, 2022, 10:28:43 am
It's supposed to update the DOM/innerHTML of the message with the new content, yes.
Title: Re: Quick edit fails to update text in 2.0 dev
Post by: Spuds on March 23, 2022, 12:51:40 pm
Should be fixed now, be sure to flush your browser cache as I had to change a JavaScript file

I had added a header check, and under some circumstances, it was not being sent so the page refresh failed.
Title: Re: Quick edit fails to update text in 2.0 dev
Post by: Frenzie on March 23, 2022, 12:55:51 pm
Alright, I'll test on this message.

Edit: and it works! :)

Edit 2: hm, by refreshing the whole page? No, it's just things moving about a bit… I feel like that didn't used to happen, or at least not noticeably.
Text only | Text with Images