ElkArte Community

Elk Development => Bug Reports => Topic started by: Jorin on July 19, 2016, 09:12:29 am

Title: mentions with "-"
Post by: Jorin on July 19, 2016, 09:12:29 am
A mention @username is not working if the username has a "-" in it. I have a user called Holger-Timm. The mention in the editor finds the username, I click on it, but when the post is saved only the first part of the username is a hyperlink and leads to another profile (the one of Holger, but not of Holger-Timm).
Title: Re: mentions with "-"
Post by: emanuele on July 21, 2016, 11:00:55 am
hmm... interesting.
In theory it should work, but probably in practice there is some regex somewhere that doesn't consider the - as a valid character... I feel, but I may be wrong.
Title: Re: mentions with "-"
Post by: emanuele on July 27, 2016, 04:36:06 pm
xref http://www.elkarte.net/community/index.php?topic=3898.0
Title: Re: mentions with "-"
Post by: Joshua Dickerson on September 29, 2016, 11:36:25 am
Why don't we just include all characters? I don't see an issue. You can always close the dialog for the user tagging and it has to start with an @
Title: Re: mentions with "-"
Post by: badmonkey on December 09, 2016, 09:30:51 am
We might include spaces in usernames as well.  Specifically a user has a space as the second character, if that helps.   ;)
Title: Re: mentions with "-"
Post by: Spuds on December 09, 2016, 03:07:45 pm
This https://github.com/Spuds/Elkarte/commit/3fb8ec7d9fd01fead17b2a7649ef759d64352630 will allow spaces in the mention names (meaning the drop down will not close up when you hit space)
Title: Re: mentions with "-"
Post by: badmonkey on December 10, 2016, 10:23:22 pm
Many thanks Spuds!  :)
Title: Re: mentions with "-"
Post by: Jorin on August 17, 2017, 12:58:08 am
Quote from: emanuele – hmm... interesting.
In theory it should work, but probably in practice there is some regex somewhere that doesn't consider the - as a valid character... I feel, but I may be wrong.

Still having the issue...  :(
Title: Re: mentions with "-"
Post by: emanuele on August 17, 2017, 05:00:59 am
Yep, it was not fixed. :P