ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: meetdilip on July 13, 2015, 06:13:57 am

Title: No full edit in Mobile view
Post by: meetdilip on July 13, 2015, 06:13:57 am
I made a post via Firefox browser for Android which I got through Google Play ( my apps are normally the latest versions available ). There was only " Quote " and " Quick Edit " buttons available in reponsive view. I tried my best to get it edited without success.
Title: Re: No full edit in Mobile view
Post by: Jorin on July 13, 2015, 06:35:04 am
Try to rotate your device and try it horizontal. Some buttons will appear if they have enough room.

@emanuele This doesn't work with iPhone 6 Plus (my girlfriend has one). It will zoom the whole mobile view but will not use more space in horizontal view. I can make screenshots later if you need them.
Title: Re: No full edit in Mobile view
Post by: emanuele on July 13, 2015, 07:28:17 am
I guess hide the "more" is not really that necessary at low resolution.
Title: Re: No full edit in Mobile view
Post by: meetdilip on July 13, 2015, 03:10:23 pm
I was using Portrait mode on a 5" screen.
Title: Re: No full edit in Mobile view
Post by: emanuele on July 18, 2015, 04:15:14 am
Tracked: https://github.com/elkarte/Elkarte/issues/2133
Title: Re: No full edit in Mobile view
Post by: radu81 on July 19, 2015, 01:45:27 pm
I can confirm, it was noticed on my forum also ;)
Title: Re: No full edit in Mobile view
Post by: emanuele on July 22, 2015, 02:37:05 pm
Fixed at: https://github.com/emanuele45/Dialogo/commit/984d24b157ea5273a316a6e02663eb15d4eb4b86
Title: Re: No full edit in Mobile view
Post by: radu81 on July 24, 2015, 10:58:49 am
what about the other buttons like "Move"  "Delete"  "Close" "Sticky"...  is there a way to show them on mobile ? On my nexus5 I see those buttons in horizontal mode, but one moderator with an older smartphone told me that there is no way for him to use to use those buttons on mobile. If needed I can attach a screenshot
Title: Re: No full edit in Mobile view
Post by: emanuele on July 24, 2015, 11:47:16 am
In index.css, find:
Code: [Select]
#moderationbuttons, a.linklevel1.button_strip_notify,
and change it to:
Code: [Select]
a.linklevel1.button_strip_notify,

I guess nowadays it's no more acceptable not do have moderation tools on mobile devices... :-\
Title: Re: No full edit in Mobile view
Post by: radu81 on July 24, 2015, 02:52:57 pm
that worked, thanks Emanuele. Just curious, will this be integrated into the newer version of elkarte?
Title: Re: No full edit in Mobile view
Post by: radu81 on July 24, 2015, 05:14:05 pm
there is a little problem with those buttons, I attach the screenshot I just received:
Title: Re: No full edit in Mobile view
Post by: emanuele on July 24, 2015, 05:29:44 pm
Try adding:
Code: [Select]
#moderationbuttons, #display_jump_to {
    display: block;
}
Title: Re: No full edit in Mobile view
Post by: radu81 on July 25, 2015, 06:04:33 pm
nope, that didn't work. I did not see any difference
Title: Re: No full edit in Mobile view
Post by: emanuele on July 25, 2015, 06:13:35 pm
arg... scrap that code, wrong, wrong, wrong.

Code: [Select]
#display_jump_to {
    float: right;
}

You could remove the float:none from the media query, but adding it back the float:right through custom.css makes it "upgrade-proof" (somehow). ;)
Title: Re: No full edit in Mobile view
Post by: radu81 on July 25, 2015, 06:18:51 pm
Thank you!  ;)
Title: Re: No full edit in Mobile view
Post by: emanuele on July 25, 2015, 06:24:44 pm
yv. :D
Title: Re: No full edit in Mobile view
Post by: emanuele on July 27, 2015, 06:13:12 am
Any objection adding that one too to 1.0.5?
Title: Re: No full edit in Mobile view
Post by: Jorin on July 27, 2015, 06:32:26 am
Oh, I like it very much that there are not all buttons visible on small screens. Makes the view very clear.
Title: Re: No full edit in Mobile view
Post by: ahrasis on July 27, 2015, 06:38:36 am
Quote from: Jorin – Oh, I like it very much that there are not all buttons visible on small screens. Makes the view very clear.

I on the other hand like the button to be removed. I mean just text and not too many of them.
Title: Re: No full edit in Mobile view
Post by: emanuele on July 27, 2015, 07:22:46 am
I'll experiment a bit if an "hamburger" to show then only on request is easy to add. That could cover both views. :)

ETA: see the attachments.
Title: Re: No full edit in Mobile view
Post by: radu81 on July 27, 2015, 08:34:08 am
For me is ok to be added to next release. There is no other way to moderate (move, delete, or lock a topic) from mobile. I also like the idea of grouping them into one button.
Title: Re: No full edit in Mobile view
Post by: Spuds on July 27, 2015, 08:59:14 am
The consolidated button thing is a pretty common solution, makes some good sense as well.

Is there a way to have a "show desktop" version when doing responsive layouts?
Title: Re: No full edit in Mobile view
Post by: emanuele on July 27, 2015, 09:13:19 am
Looking around on the interweb there are some javascript hacks to do a "show desktop", but it would be quite messy I think... :-\
Title: Re: No full edit in Mobile view
Post by: emanuele on August 09, 2015, 03:58:23 pm
Added here: https://github.com/emanuele45/Dialogo/commit/559b0cc4f521ab8198f09b9c6f7127e15c02dcce
Title: Re: No full edit in Mobile view
Post by: Flavio93Zena on August 09, 2015, 04:24:09 pm
...
Code: [Select]
i class="fa fa-2x fa-bars hamburger_30
Really? ...  :-X  :-\
Title: Re: No full edit in Mobile view
Post by: Spuds on August 09, 2015, 07:11:40 pm
I would gladly pay you tuesday for a hamburger today :D
Title: Re: No full edit in Mobile view
Post by: Flavio93Zena on August 09, 2015, 08:30:38 pm
I was serious though, that kind of class doesn't make sense and makes it harder to figure out what something is... Why did you use those "Hamburgers" thingies? D:
Title: Re: No full edit in Mobile view
Post by: Spuds on August 09, 2015, 08:34:11 pm
Well hamburger is the alternative name for the bars icon, since it looks like a hamburger.  Go to font awesome http://fortawesome.github.io/Font-Awesome/icons/ and enter hamburger in to the search bar and see what comes up ;)
Title: Re: No full edit in Mobile view
Post by: Flavio93Zena on August 09, 2015, 09:06:41 pm
headdesk  ::)  O:-)
Title: Re: No full edit in Mobile view
Post by: emanuele on August 10, 2015, 08:25:54 am
LOL

Call it "bars" it could have been even more confusing (I'm pretty sure we already have some kind of "bar" somewhere), at least it's something you don't usually have in your CSS. :P