Re: loadJavascriptFile()
Reply #1 –
I'd agree that validate should be true once force_current is set ... the rest meh
Re: loadJavascriptFile()
Reply #5 –
[off topic]
Buzz off, Aussie.
[/off topic]
On the rest: yeah, that's why I would have expected a clear 'fallback to default' behavior.
Although it sort of was... I guess I just don't see how those params were supposed to mix.
SpudsMan, thank you for the experiment! I see you already avoided the check on default. IMHO this solution is very good.
For me it remains to be seen tbh, if those functions (in particular loadCSSFile()) bring enough value... Does it make sense to be used by add-ons? Recommended for their use? Personally I'm taking for granted that the answer is yes, at least for js, but I don't think they're ready for it... Since I'm on the line for shooting at anyway, I'll dare add: they'd need custom paths for that.
Re: loadJavascriptFile()
Reply #7 –
Javascript is probably fairly safe, although I can think of times when I might want to modify it. However, that can usually be done in the template by inserting the relevant values where you call the js. It's not quite as neat as modifying the source, but it will work in a pinch. So, if that can be done, as a compromise for overhead I'd be fine with calling js from default.
One thing to be wary of is where the js files contain presentation. That should defintiely be theme-dependent. If it's all structural/functionality then default is fine.
Of course, anyone running their own site can still do what they like with the source, and probably will.
Re: loadJavascriptFile()
Reply #12 –
I would like to see these just become part of a Theme class where you'd standardize some of these settings.
Re: loadJavascriptFile()
Reply #14 –
Good start. I prefer protected over private but I am glad to see progress.