ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: Antechinus on December 05, 2012, 08:49:37 pm

Title: [Bug] Quoting to quick reply haz major bugz
Post by: Antechinus on December 05, 2012, 08:49:37 pm
Just try quoting a post that contains other quotes. Gives a "message body empty" error. 

FF17, W7.
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: TestMonkey on December 05, 2012, 09:55:07 pm
Quote from: Antechinus" date="1354758577" link=topic="12.msg31#msg31Just try quoting a post that contains other quotes. Gives a "message body empty" error.

FF17, W7.

Does it.
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: Spuds on December 05, 2012, 10:04:08 pm
w/o the full editor test

ETA worked fine
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: Spuds on December 05, 2012, 10:07:27 pm
Quote from: Spuds – w/o the full editor test

ETA worked fine
some stuff going on with da full .... but it still worked OK?
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: Spuds on December 05, 2012, 10:09:32 pm

Quote from: Spuds – some stuff going on with da full .... but it still worked OK?

How about on by default?
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: Spuds on December 05, 2012, 10:10:27 pm
Quote from: Spuds" date="1354763372" link=topic="12.msg36#msg36How about on by default?
qr -preview -post test  ... worked fine?  confused :P
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: TestMonkey on December 05, 2012, 10:15:22 pm
Quote from: Spuds" date="1354763247" link=topic="12.msg35#msg35some stuff going on with da full .... but it still worked OK?

Sorta... but:

Okay the second two have nothing to do with this topic.
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: TestMonkey on December 05, 2012, 10:28:47 pm
Save another draft... if you can.
Update: it replaces the old, when you keep writing. Okay, but then, the section 'Load drafts' ... wait.


On a different note,
Is it only me or the icons in quick reply (full editor) are far too big? Same for standard post page. (ignore if it's only me)
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: Antechinus on December 06, 2012, 12:37:35 am
Quote from: TestMonkey" date="1354762507" link=topic="12.msg32#msg32Does it.
Lesse if it does it again.
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: Antechinus on December 06, 2012, 12:38:00 am
Quote from: Antechinus" date="1354772255" link=topic="12.msg45#msg45Lesse if it does it again.
Code: [Select]
	// Show information about events, birthdays, and holidays on the calendar.
if ($context['show_calendar'])
{
echo '
<li class="smalltext">';
Quote from: Antechinus" date="1354772255" link=topic="12.msg45#msg45Lesse if it does it again.
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: Antechinus on December 06, 2012, 12:40:23 am
Aha! Ok, reproduced it. Try quoting the post above this. The one with quote followed by code followed by quote. ;)

Oh and also note that the quoteheader links are broken. Formatting is up the poo and the link aint linked.
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: Antechinus on December 06, 2012, 12:46:12 am
Quote from: TestMonkey" date="1354764527" link=topic="12.msg42#msg42On a different note,
Is it only me or the icons in quick reply (full editor) are far too big? Same for standard post page. (ignore if it's only me)
It's only you. They're a pretty good size IMO. FFS, http://en.wikipedia.org/wiki/Fitts%27s_law


 
The current icons and buttons should not be made any smaller. If any change was going to be made, I would make them bigger. In fact for general usability there is much to be said for padding out the smileys to match the size of the toolbar buttons. This can be done with a visible background, or just by adding css padding to the images themselves.
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: TestMonkey on December 06, 2012, 11:36:35 am
Quote from: Antechinus –
Code: [Select]
	// Show information about events, birthdays, and holidays on the calendar.
if ($context['show_calendar'])
{
echo '
<li class="smalltext">';
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: Spuds on December 08, 2012, 07:13:14 pm
Quote from: Antechinus – Aha! Ok, reproduced it. Try quoting the post above this. The one with quote followed by code followed by quote. ;)

Oh and also note that the quoteheader links are broken. Formatting is up the poo and the link aint linked.
The quoteheaader link is a problem with sceditor. 

I've put a temp patch in place but the official fix from Sam will be a couple of days out.  Basically when you swapped in and out of source->wizzy->source the attributes would get wrapped in quotes.  So author=Antechinus  would become author="Antechinus" and so on with all the attributes.  Then parse_bbc would not know what to do cuz its parse_bbc you see.

I'll work on the preview not working first time next :)
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: TestMonkey on December 08, 2012, 07:28:18 pm
Thank you! :D

Surprise from 1.4.0 looks like  8)
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: Spuds on December 09, 2012, 01:14:01 pm

Quote from: Antechinus –
Quote from: Antechinus" date="1354772255" link=topic="12.msg45#msg45Lesse if it does it again.
Code: [Select]
	// Show information about events, birthdays, and holidays on the calendar.
if ($context['show_calendar'])
{
echo '
<li class="smalltext">';
Quote from: Antechinus" date="1354772255" link=topic="12.msg45#msg45Lesse if it does it again.
That was not "working" since the Remove nested quotes when quoting option was set, so it was doing what it was supposed to do, strip quotes inside the quote .... almost seems like that option should be level N+1 or something ... oh well turned it off to make this post
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: TestMonkey on December 09, 2012, 01:51:18 pm
Quote from: Spuds –
Quote from: Antechinus –
Quote from: Antechinus" date="1354772255" link=topic="12.msg45#msg45Lesse if it does it again.
Code: [Select]
	// Show information about events, birthdays, and holidays on the calendar.
if ($context['show_calendar'])
{
echo '
<li class="smalltext">';
Quote from: Antechinus" date="1354772255" link=topic="12.msg45#msg45Lesse if it does it again.
That was not "working" since the Remove nested quotes when quoting option was set, so it was doing what it was supposed to do, strip quotes inside the quote .... almost seems like that option should be level N+1 or something ... oh well turned it off to make this post

That option's behavior is so non-intuitive and bewildering. Yeah it could be argued it "simplifies" posts sometimes, but it misses information you could always edit out if you don't want it.

/me knows Ant will disagree.
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: Antechinus on December 09, 2012, 03:51:05 pm
I strip nested quotes on the site I run. It's a good option IMO. Most users simply will not clean up things when the quotes start building to ridiculous levels. Stripping it all down to one level is much better in practice, even though it's sometimes inconvenient for people who are responsible enough to not just blindly keep hitting "Quote".

IMO, we should keep that option. Although if an N+1 option can be made bug-free easily then that would be great too, but it may be more difficult than some people think.
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: emanuele on December 10, 2012, 04:20:10 am
/me hates quote altogether.
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: TestMonkey on December 10, 2012, 04:56:05 am


/me quotes emanuele for posterity.
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: emanuele on December 10, 2012, 05:39:28 am
QFTW!
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: emanuele on December 18, 2012, 05:19:54 am
It's only me or quotes are completely broken now?
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: Spuds on December 18, 2012, 10:56:40 am

Quote from: emanuele – It's only me or quotes are completely broken now?
You know for someone who works on bug reports as much as you do, you sure write some crappy descriptions of what you are experiencing :P :D :P 

This was done as a quote to QR with full editor on and shown by default ... seemed to be fine?
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: emanuele on December 18, 2012, 01:04:39 pm
Quote from: emanuele – It's only me or quotes are completely broken now?
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: emanuele on December 18, 2012, 01:05:36 pm
(http://img826.imageshack.us/img826/4866/screen83x.th.png) (http://img826.imageshack.us/i/screen83x.png/)

mmm...
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: FF / MFG on December 18, 2012, 01:07:30 pm
Quote from: emanuele – It's only me or quotes are completely broken now?
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: emanuele on December 18, 2012, 01:08:18 pm
mmm...something is not working (something badly processed by parse_bbc? or something not properly escaped?) when non-admins posts.

ETA: no, it's also others:
http://www.spudsdesign.com/dialogo/index.php?topic=12.msg34#msg34

Take a look at my post with the image and the url: the image is working properly, the closing tag of the url is ignored and the entire post is linked.
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: Spuds on December 18, 2012, 01:17:00 pm
You know that looks like a bug  :o I would suspect its something to do with the editor script ... well the extensions that is ... remember bug hunting is fun for the entire family!
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: emanuele on December 18, 2012, 02:33:23 pm
I thought the same! :P
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: emanuele on December 18, 2012, 02:33:56 pm
Quote from: Spuds – You know that looks like a bug  :o
I thought the same with js disabled.
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: Spuds on December 18, 2012, 04:26:35 pm
Should be all fixed ....
Title: Re: [Bug] Quoting to quick reply haz major bugz
Post by: emanuele on December 18, 2012, 06:17:17 pm
You are teh best!