ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: Antechinus on December 31, 2012, 02:47:11 am

Title: All teh javascript is borken.
Post by: Antechinus on December 31, 2012, 02:47:11 am
Just installed the latest GitHub build on local. None of the js seems to work. Hey ho. :P

What stage is all this refactoring at?
Title: Re: All teh javascript is borken.
Post by: Spuds on December 31, 2012, 10:55:01 am
This site is running the current github repo ... javascript seems to be fine here (relatively speaking lol)
Title: Re: All teh javascript is borken.
Post by: TestMonkey on December 31, 2012, 03:14:32 pm
Quote from: Antechinus – What stage is all this refactoring at?

We have usually kept at all times compatibility with the rest of the code. PRs are batches of commits which try to completely (not partially) change some of the code while keeping the behavior, and in this sense compatibility with the rest of the code.
Obvious misses aside - those easy to fix once you stumble upon them.

By the way, that's the meaning of "refactoring": change some of the implementation while keeping the behavior identical.
Of course, since we don't have unit tests things are more likely to break. Which again, is why we use PRs, and code review, before we merge them in the master branch of the main repo.


Re: javascript. Try to switch to 'local' instead of cdn. Does it work?
Title: Re: All teh javascript is borken.
Post by: Antechinus on December 31, 2012, 11:45:46 pm
Ah. That seems to be it. Looks like it wont call the cdn to local host sites, which is a bit odd seeing as links to the web usually work. Anyway I set it to local source and it works now. Worth noting. :)
Title: Re: All teh javascript is borken.
Post by: Antechinus on January 27, 2013, 06:10:00 pm
I'm going to close this one. Having to use local source for jQ on a desktop local host is not really something that's worth bug-tracking for a production build.

ETA: Topic moving is borken. Can stay here then. :P

Hey cool. It makes the moved topic topic/redirect/whatever but doesn't move the actual topic.