ElkArte Community

Elk Development => Theme development => Topic started by: AaronB on March 26, 2014, 09:45:22 pm

Title: Minor Aestectics in Modify Board / Recycle Board
Post by: AaronB on March 26, 2014, 09:45:22 pm
Admittedly I am a touch OCD about symmetry ...  :-[  so the following, while not earth shattering to most is something that falls into a catagory that I consider non symmetrical.   :)  


See attached images. In the first image the first 'note' box is a .infobox class and looks rather proper with the little stick pin; especially for being called a 'note'. The second box has the word 'note' but no stick pin image and is from the class .information.

By editing ManageBoards.template.php, line 636 and changing this:

Code: [Select]
echo '<div class="information">', $txt['mboards_recycle_disabled_delete'], '</div>';

to this:

Code: [Select]
echo '<div class="infobox">', $txt['mboards_recycle_disabled_delete'], '</div>';

I achieved the symmetry shown in the second image. OCD crisis over.  ;D

I realise this seems minor to most people, but these little items like this are what add to the polished look of the user interface. Please consider adding the above changes.

thanks
Title: Re: Minor Aestectics in Modify Board / Recycle Board
Post by: TE on March 27, 2014, 01:22:24 am
Thanks for the report.
mhh, why seperate boxes at all? wouldn't it make more sense to combine both messages in a single box?
Title: Re: Minor Aestectics in Modify Board / Recycle Board
Post by: emanuele on March 27, 2014, 05:34:04 am
Makes sense TE!
Title: Re: Minor Aestectics in Modify Board / Recycle Board
Post by: TE on March 27, 2014, 07:27:15 am
https://github.com/eurich/Elkarte/commit/6ede593edc68bf2c6598679f6cc13799681678ef
Not sure If we schould remove the "Note: " from the second language string?
Title: Re: Minor Aestectics in Modify Board / Recycle Board
Post by: emanuele on March 27, 2014, 08:19:17 am
Probably...
Title: Re: Minor Aestectics in Modify Board / Recycle Board
Post by: AaronB on March 27, 2014, 06:00:06 pm
Yes, I just downloaded the corrections and I think that it would look better to remove the second 'Note:' from the string. Aside from that the new message does look much better combined and placed at the top.

edit: spelling
Title: Re: Minor Aestectics in Modify Board / Recycle Board
Post by: emanuele on June 30, 2014, 03:13:39 am
Was the "note" removed?
I don't remember...
Title: Re: Minor Aestectics in Modify Board / Recycle Board
Post by: AaronB on June 30, 2014, 05:39:05 pm
Nope ... the second note is still there. Perhaps the two different strings can be combined and only one string called in the template?
Title: Re: Minor Aestectics in Modify Board / Recycle Board
Post by: AaronB on June 30, 2014, 06:22:03 pm
.
Title: Re: Minor Aestectics in Modify Board / Recycle Board
Post by: emanuele on July 02, 2014, 06:45:21 pm
https://github.com/elkarte/Elkarte/pull/1703

One day we may want to merge the two strings... not now though, otherwise I could be killed... O:-)
Title: Re: Minor Aestectics in Modify Board / Recycle Board
Post by: Spuds on July 02, 2014, 08:24:58 pm
Quote from: emanuele – https://github.com/elkarte/Elkarte/pull/1703

One day we may want to merge the two strings... not now though, otherwise I could be killed... O:-)
LOL ... I was worried about even removing unused ones !